Skip multiple servers testbed parsing on branch 202405#19217
Closed
w1nda wants to merge 2 commits intosonic-net:202405from
Closed
Skip multiple servers testbed parsing on branch 202405#19217w1nda wants to merge 2 commits intosonic-net:202405from
w1nda wants to merge 2 commits intosonic-net:202405from
Conversation
w1nda
requested review from
StormLiangMS,
prgeor,
wangxin and
yxieca
as code owners
Collaborator
|
/azp run |
|
Azure Pipelines will not run the associated pipelines, because the pull request was updated after the run command was issued. Review the pull request again and issue a new run command. |
w1nda
requested review from
bingwang-ms and
lizhijianrd
and removed request for
StormLiangMS,
prgeor,
wangxin and
yxieca
lizhijianrd
approved these changes
Jun 27, 2025
Member
Author
|
/azp run |
|
Commenter does not have sufficient privileges for PR 19217 in repo sonic-net/sonic-mgmt |
Member
Author
|
Hi @bingwang-ms , cloud you help merge this PR? |
Janetxxx
approved these changes
Jun 30, 2025
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
Author
|
Hi @bingwang-ms, cloud you help merge this PR? |
Blueve
approved these changes
Jul 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes # (issue)
In PRs: #15643 and #15881
We implemented multi-servers testbed design, however, to enable parsing multi-servers testbed definition, raise this PR to fix key error.
The code is already in master branch, and we only need the four lines code to be backport to 202411 and 202405
Type of change
Back port request
Approach
What is the motivation for this PR?
In PRs: #15643 and #15881
We implemented multi-servers testbed design, however, branch 202411 will raise key error when parsing multi-server testbed defination
How did you do it?
Check if key exists before visit
How did you verify/test it?
Define multi-servers testbed in testbed.yaml and run test on single server testbed.
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation