Skip to content

[Smartswitch] Fix test issues in the dpu platform test#19181

Merged
bingwang-ms merged 1 commit intosonic-net:masterfrom
congh-nvidia:dpu_platform
Jul 3, 2025
Merged

[Smartswitch] Fix test issues in the dpu platform test#19181
bingwang-ms merged 1 commit intosonic-net:masterfrom
congh-nvidia:dpu_platform

Conversation

@congh-nvidia
Copy link
Copy Markdown
Contributor

@congh-nvidia congh-nvidia commented Jun 25, 2025 •
edited
Loading

Description of PR

Summary:
For test case test_restart_pmon, we need a post check after restarting pmon, otherwise the pmon could not be fully started and it will fail the next case.
For test case test_pcie_link and test_system_health_state, need to restore the DPU "admin on" status if the check after shutdown DPUs fails.

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • New Test case
    • Skipped for non-supported platforms
  • Test case improvement

Back port request

  • 202205
  • 202305
  • 202311
  • 202405
  • 202411
  • 202505

Approach

What is the motivation for this PR?

How did you do it?

How did you verify/test it?

Run the test on SN4280 in regression, all passing.

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

@congh-nvidia
Fix test issues in the dpu platform test
c2d6f9c 
1. Need a post check after restarting pmon, otherwise the pmon could not fully started and it will fail the next case.
2. Need to restore the DPU admin on status if the check after shutdown DPUs fails.

Change-Id: I80538d3a66b9c5c7d590f51d7c6703f62e982fe4
@mssonicbld
Copy link
Copy Markdown
Collaborator

mssonicbld commented Jun 25, 2025

/azp run

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines bot commented Jun 25, 2025

Azure Pipelines successfully started running 1 pipeline(s).

@KrisNey-MSFT
Copy link
Copy Markdown

KrisNey-MSFT commented Jun 25, 2025

hi @prsunny - looks like this needs a reviewer pls

@KrisNey-MSFT
Copy link
Copy Markdown

KrisNey-MSFT commented Jul 1, 2025

@prsunny - looks like we have an approval, how about a merge?

@prsunny
Copy link
Copy Markdown
Contributor

prsunny commented Jul 3, 2025

@vvolam , merging the PR. Please take a look and let me know any concerns.

prsunny
prsunny approved these changes Jul 3, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@prsunny prsunny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vvolam

vvolam
vvolam approved these changes Jul 3, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@vvolam vvolam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @nissampa FYI.

@bingwang-ms bingwang-ms merged commit a12ad95 into sonic-net:master Jul 3, 2025
10 checks passed
mssonicbld pushed a commit to mssonicbld/sonic-mgmt that referenced this pull request Jul 4, 2025
@congh-nvidia @mssonicbld
Fix test issues in the dpu platform test (sonic-net#19181)
1459db7 
1. Need a post check after restarting pmon, otherwise the pmon could not fully started and it will fail the next case.
2. Need to restore the DPU admin on status if the check after shutdown DPUs fails.

Change-Id: I80538d3a66b9c5c7d590f51d7c6703f62e982fe4
@mssonicbld
Copy link
Copy Markdown
Collaborator

mssonicbld commented Jul 4, 2025

Cherry-pick PR to 202505: #19406

@mssonicbld mssonicbld mentioned this pull request Jul 4, 2025
Merged
11 tasks
mssonicbld pushed a commit that referenced this pull request Jul 4, 2025
@congh-nvidia @mssonicbld
Fix test issues in the dpu platform test (#19181)
d1ba977 
1. Need a post check after restarting pmon, otherwise the pmon could not fully started and it will fail the next case.
2. Need to restore the DPU admin on status if the check after shutdown DPUs fails.

Change-Id: I80538d3a66b9c5c7d590f51d7c6703f62e982fe4
nissampa pushed a commit to nissampa/sonic-mgmt_dpu_test that referenced this pull request Aug 7, 2025
@congh-nvidia @nissampa
Fix test issues in the dpu platform test (sonic-net#19181)
3b09ce2 
1. Need a post check after restarting pmon, otherwise the pmon could not fully started and it will fail the next case.
2. Need to restore the DPU admin on status if the check after shutdown DPUs fails.

Change-Id: I80538d3a66b9c5c7d590f51d7c6703f62e982fe4
ashutosh-agrawal pushed a commit to ashutosh-agrawal/sonic-mgmt that referenced this pull request Aug 14, 2025
@congh-nvidia @ashutosh-agrawal
Fix test issues in the dpu platform test (sonic-net#19181)
9e74fce 
1. Need a post check after restarting pmon, otherwise the pmon could not fully started and it will fail the next case.
2. Need to restore the DPU admin on status if the check after shutdown DPUs fails.

Change-Id: I80538d3a66b9c5c7d590f51d7c6703f62e982fe4
@congh-nvidia congh-nvidia deleted the dpu_platform branch September 8, 2025 09:23
vidyac86 pushed a commit to vidyac86/sonic-mgmt that referenced this pull request Oct 23, 2025
@congh-nvidia @vidyac86
Fix test issues in the dpu platform test (sonic-net#19181)
8548733 
1. Need a post check after restarting pmon, otherwise the pmon could not fully started and it will fail the next case.
2. Need to restore the DPU admin on status if the check after shutdown DPUs fails.

Change-Id: I80538d3a66b9c5c7d590f51d7c6703f62e982fe4
opcoder0 pushed a commit to opcoder0/sonic-mgmt that referenced this pull request Dec 8, 2025
@congh-nvidia
Fix test issues in the dpu platform test (sonic-net#19181)
782a528 
1. Need a post check after restarting pmon, otherwise the pmon could not fully started and it will fail the next case.
2. Need to restore the DPU admin on status if the check after shutdown DPUs fails.

Change-Id: I80538d3a66b9c5c7d590f51d7c6703f62e982fe4

Signed-off-by: opcoder0 <[email protected]>
gshemesh2 pushed a commit to gshemesh2/sonic-mgmt that referenced this pull request Dec 16, 2025
@congh-nvidia @gshemesh2
Fix test issues in the dpu platform test (sonic-net#19181)
1bfd77f 
1. Need a post check after restarting pmon, otherwise the pmon could not fully started and it will fail the next case.
2. Need to restore the DPU admin on status if the check after shutdown DPUs fails.

Change-Id: I80538d3a66b9c5c7d590f51d7c6703f62e982fe4
Signed-off-by: Guy Shemesh <[email protected]>
AharonMalkin pushed a commit to AharonMalkin/sonic-mgmt that referenced this pull request Dec 16, 2025
@congh-nvidia @AharonMalkin
Fix test issues in the dpu platform test (sonic-net#19181)
621d28d 
1. Need a post check after restarting pmon, otherwise the pmon could not fully started and it will fail the next case.
2. Need to restore the DPU admin on status if the check after shutdown DPUs fails.

Change-Id: I80538d3a66b9c5c7d590f51d7c6703f62e982fe4
Signed-off-by: Aharon Malkin <[email protected]>
gshemesh2 pushed a commit to gshemesh2/sonic-mgmt that referenced this pull request Dec 21, 2025
@congh-nvidia @gshemesh2
Fix test issues in the dpu platform test (sonic-net#19181)
8aa9cfb 
1. Need a post check after restarting pmon, otherwise the pmon could not fully started and it will fail the next case.
2. Need to restore the DPU admin on status if the check after shutdown DPUs fails.

Change-Id: I80538d3a66b9c5c7d590f51d7c6703f62e982fe4
Signed-off-by: Guy Shemesh <[email protected]>
venu-nexthop pushed a commit to venu-nexthop/sonic-mgmt that referenced this pull request Jan 13, 2026
@congh-nvidia @venu-nexthop
Fix test issues in the dpu platform test (sonic-net#19181)
3b15ff4 
1. Need a post check after restarting pmon, otherwise the pmon could not fully started and it will fail the next case.
2. Need to restore the DPU admin on status if the check after shutdown DPUs fails.

Change-Id: I80538d3a66b9c5c7d590f51d7c6703f62e982fe4
gshemesh2 pushed a commit to gshemesh2/sonic-mgmt that referenced this pull request Jan 26, 2026
@congh-nvidia @gshemesh2
Fix test issues in the dpu platform test (sonic-net#19181)
9ed49d2 
1. Need a post check after restarting pmon, otherwise the pmon could not fully started and it will fail the next case.
2. Need to restore the DPU admin on status if the check after shutdown DPUs fails.

Change-Id: I80538d3a66b9c5c7d590f51d7c6703f62e982fe4
Signed-off-by: Guy Shemesh <[email protected]>
ytzur1 pushed a commit to ytzur1/sonic-mgmt that referenced this pull request Feb 2, 2026
@congh-nvidia @ytzur1
Fix test issues in the dpu platform test (sonic-net#19181)
38c31a4 
1. Need a post check after restarting pmon, otherwise the pmon could not fully started and it will fail the next case.
2. Need to restore the DPU admin on status if the check after shutdown DPUs fails.

Change-Id: I80538d3a66b9c5c7d590f51d7c6703f62e982fe4
Signed-off-by: Yael Tzur <[email protected]>
kazinator-arista pushed a commit to kazinator-arista/sonic-mgmt that referenced this pull request Mar 4, 2026
@saiarcot895 @mssonicbld
[baseimage]: Upgrade docker-py to 7.1.0 (sonic-net#19181)
2e99f3c 
This version of docker-py has the fix for the issue caused by requests
2.32, and has the added benefit of upgrading to the latest version of
docker-py.

Signed-off-by: Saikrishna Arcot <[email protected]>
kazinator-arista pushed a commit to kazinator-arista/sonic-mgmt that referenced this pull request Mar 4, 2026
@saiarcot895 @mssonicbld
[baseimage]: Upgrade docker-py to 7.1.0 (sonic-net#19181)
2254ada 
This version of docker-py has the fix for the issue caused by requests
2.32, and has the added benefit of upgrading to the latest version of
docker-py.

Signed-off-by: Saikrishna Arcot <[email protected]>
venu-nexthop pushed a commit to venu-nexthop/sonic-mgmt that referenced this pull request Mar 27, 2026
@congh-nvidia
Fix test issues in the dpu platform test (sonic-net#19181)
48a5313 
1. Need a post check after restarting pmon, otherwise the pmon could not fully started and it will fail the next case.
2. Need to restore the DPU admin on status if the check after shutdown DPUs fails.

Change-Id: I80538d3a66b9c5c7d590f51d7c6703f62e982fe4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@prsunny prsunny prsunny approved these changes

@nhe-NV nhe-NV nhe-NV approved these changes

@vvolam vvolam vvolam approved these changes

Assignees

No one assigned

Labels

Approved for 202505 branch Included in 202505 branch Request for 202505 branch

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@congh-nvidia @mssonicbld @KrisNey-MSFT @prsunny @nhe-NV @vvolam @yejianquan @bingwang-ms