Fix accessing instance attribute in AdvancedReboot#1918
Merged
vaibhavhd merged 1 commit intosonic-net:masterfrom Jul 17, 2020
Merged
Fix accessing instance attribute in AdvancedReboot#1918vaibhavhd merged 1 commit intosonic-net:masterfrom
vaibhavhd merged 1 commit intosonic-net:masterfrom
Conversation
daall
approved these changes
Jul 17, 2020
tahmed-dev
approved these changes
Jul 17, 2020
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
Commits on Oct 26, 2021 Remove exec from platform_reboot call to prevent reboot hang (sonic-net#1881) 066b5adf6d737a5bd174123d4d00dab4b6110cf6 Commits on Nov 17, 2021 [fdbshow]: Handle FDB cleanup gracefully. (sonic-net#1918) c80321c98d0741f340d2900108bad7fed76c80cd
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Fixes: Error in the tests using AdvancedReboot script
Type of change
Approach
What is the motivation for this PR?
Bug during accessing instance attribute in one of the methods of AdvancedReboot class.
How did you do it?
Use
selfto access the instance attributecredsto obtain the credentials.How did you verify/test it?
Tested
platform_tests/test_advanced_reboot.py::test_fast_rebooton T0 device and the test passed successfully.Documentation
Snippet of the error that is being fixed: