Clean up mgmtvrf test for ntp by reusing existing code#19140
Merged
yxieca merged 1 commit intosonic-net:masterfrom Aug 6, 2025
Merged
Clean up mgmtvrf test for ntp by reusing existing code#19140yxieca merged 1 commit intosonic-net:masterfrom
yxieca merged 1 commit intosonic-net:masterfrom
Conversation
Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
yxieca
approved these changes
Aug 6, 2025
nissampa
pushed a commit
to nissampa/sonic-mgmt_dpu_test
that referenced
this pull request
Aug 7, 2025
What is the motivation for this PR? Update the mgmtvrf test case for ntp by having it use Chrony How did you do it? Reuse existing code that is in the common ntp_helper module instead of copy-pasting code here. Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Aug 8, 2025
What is the motivation for this PR? Update the mgmtvrf test case for ntp by having it use Chrony How did you do it? Reuse existing code that is in the common ntp_helper module instead of copy-pasting code here. Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>
Collaborator
|
Cherry-pick PR to 202505: #20129 |
11 tasks
mssonicbld
pushed a commit
that referenced
this pull request
Aug 8, 2025
What is the motivation for this PR? Update the mgmtvrf test case for ntp by having it use Chrony How did you do it? Reuse existing code that is in the common ntp_helper module instead of copy-pasting code here. Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>
mssonicbld
added
Included in 202505 branch
and removed
Created PR to 202505 branch
labels
ashutosh-agrawal
pushed a commit
to ashutosh-agrawal/sonic-mgmt
that referenced
this pull request
Aug 14, 2025
What is the motivation for this PR? Update the mgmtvrf test case for ntp by having it use Chrony How did you do it? Reuse existing code that is in the common ntp_helper module instead of copy-pasting code here. Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>
vidyac86
pushed a commit
to vidyac86/sonic-mgmt
that referenced
this pull request
Oct 23, 2025
What is the motivation for this PR? Update the mgmtvrf test case for ntp by having it use Chrony How did you do it? Reuse existing code that is in the common ntp_helper module instead of copy-pasting code here. Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>
opcoder0
pushed a commit
to opcoder0/sonic-mgmt
that referenced
this pull request
Dec 8, 2025
What is the motivation for this PR? Update the mgmtvrf test case for ntp by having it use Chrony How did you do it? Reuse existing code that is in the common ntp_helper module instead of copy-pasting code here. Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>
gshemesh2
pushed a commit
to gshemesh2/sonic-mgmt
that referenced
this pull request
Dec 16, 2025
What is the motivation for this PR? Update the mgmtvrf test case for ntp by having it use Chrony How did you do it? Reuse existing code that is in the common ntp_helper module instead of copy-pasting code here. Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com> Signed-off-by: Guy Shemesh <gshemesh@nvidia.com>
AharonMalkin
pushed a commit
to AharonMalkin/sonic-mgmt
that referenced
this pull request
Dec 16, 2025
What is the motivation for this PR? Update the mgmtvrf test case for ntp by having it use Chrony How did you do it? Reuse existing code that is in the common ntp_helper module instead of copy-pasting code here. Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com> Signed-off-by: Aharon Malkin <amalkin@nvidia.com>
gshemesh2
pushed a commit
to gshemesh2/sonic-mgmt
that referenced
this pull request
Dec 21, 2025
What is the motivation for this PR? Update the mgmtvrf test case for ntp by having it use Chrony How did you do it? Reuse existing code that is in the common ntp_helper module instead of copy-pasting code here. Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com> Signed-off-by: Guy Shemesh <gshemesh@nvidia.com>
venu-nexthop
pushed a commit
to venu-nexthop/sonic-mgmt
that referenced
this pull request
Jan 13, 2026
What is the motivation for this PR? Update the mgmtvrf test case for ntp by having it use Chrony How did you do it? Reuse existing code that is in the common ntp_helper module instead of copy-pasting code here. Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>
gshemesh2
pushed a commit
to gshemesh2/sonic-mgmt
that referenced
this pull request
Jan 26, 2026
What is the motivation for this PR? Update the mgmtvrf test case for ntp by having it use Chrony How did you do it? Reuse existing code that is in the common ntp_helper module instead of copy-pasting code here. Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com> Signed-off-by: Guy Shemesh <gshemesh@nvidia.com>
ytzur1
pushed a commit
to ytzur1/sonic-mgmt
that referenced
this pull request
Feb 2, 2026
What is the motivation for this PR? Update the mgmtvrf test case for ntp by having it use Chrony How did you do it? Reuse existing code that is in the common ntp_helper module instead of copy-pasting code here. Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com> Signed-off-by: Yael Tzur <ytzur@nvidia.com>
venu-nexthop
pushed a commit
to venu-nexthop/sonic-mgmt
that referenced
this pull request
Mar 27, 2026
What is the motivation for this PR? Update the mgmtvrf test case for ntp by having it use Chrony How did you do it? Reuse existing code that is in the common ntp_helper module instead of copy-pasting code here. Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
Update the mgmtvrf test case for ntp by having it use Chrony
How did you do it?
Reuse existing code that is in the common ntp_helper module instead of copy-pasting code here.
How did you verify/test it?
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation