Add config change validation to prevent bad bgp config state#19139
Merged
StormLiangMS merged 1 commit intosonic-net:masterfrom Jul 2, 2025
Merged
Add config change validation to prevent bad bgp config state#19139StormLiangMS merged 1 commit intosonic-net:masterfrom
StormLiangMS merged 1 commit intosonic-net:masterfrom
Conversation
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
vvolam
pushed a commit
to vvolam/sonic-mgmt
that referenced
this pull request
Jul 3, 2025
…et#19139) What is the motivation for this PR? bgp/test_bgp_suppress_fib.py::test_suppress_fib_stress failing How did you do it? Wait for config to properly take effect bgp/test_bgp_suppress_fib.py::test_credit_loop so subsequent tests can run on a clean state. How did you verify/test it? bgp/test_bgp_suppress_fib.py::test_suppress_fib_stress no longer has packet count mismatch failures.
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Jul 3, 2025
…et#19139) What is the motivation for this PR? bgp/test_bgp_suppress_fib.py::test_suppress_fib_stress failing How did you do it? Wait for config to properly take effect bgp/test_bgp_suppress_fib.py::test_credit_loop so subsequent tests can run on a clean state. How did you verify/test it? bgp/test_bgp_suppress_fib.py::test_suppress_fib_stress no longer has packet count mismatch failures.
Collaborator
|
Cherry-pick PR to 202505: #19385 |
11 tasks
mssonicbld
pushed a commit
that referenced
this pull request
Jul 3, 2025
What is the motivation for this PR? bgp/test_bgp_suppress_fib.py::test_suppress_fib_stress failing How did you do it? Wait for config to properly take effect bgp/test_bgp_suppress_fib.py::test_credit_loop so subsequent tests can run on a clean state. How did you verify/test it? bgp/test_bgp_suppress_fib.py::test_suppress_fib_stress no longer has packet count mismatch failures.
mssonicbld
added
Included in 202505 branch
and removed
Created PR to 202505 branch
labels
nissampa
pushed a commit
to nissampa/sonic-mgmt_dpu_test
that referenced
this pull request
Aug 7, 2025
…et#19139) What is the motivation for this PR? bgp/test_bgp_suppress_fib.py::test_suppress_fib_stress failing How did you do it? Wait for config to properly take effect bgp/test_bgp_suppress_fib.py::test_credit_loop so subsequent tests can run on a clean state. How did you verify/test it? bgp/test_bgp_suppress_fib.py::test_suppress_fib_stress no longer has packet count mismatch failures.
ashutosh-agrawal
pushed a commit
to ashutosh-agrawal/sonic-mgmt
that referenced
this pull request
Aug 14, 2025
…et#19139) What is the motivation for this PR? bgp/test_bgp_suppress_fib.py::test_suppress_fib_stress failing How did you do it? Wait for config to properly take effect bgp/test_bgp_suppress_fib.py::test_credit_loop so subsequent tests can run on a clean state. How did you verify/test it? bgp/test_bgp_suppress_fib.py::test_suppress_fib_stress no longer has packet count mismatch failures.
vidyac86
pushed a commit
to vidyac86/sonic-mgmt
that referenced
this pull request
Oct 23, 2025
…et#19139) What is the motivation for this PR? bgp/test_bgp_suppress_fib.py::test_suppress_fib_stress failing How did you do it? Wait for config to properly take effect bgp/test_bgp_suppress_fib.py::test_credit_loop so subsequent tests can run on a clean state. How did you verify/test it? bgp/test_bgp_suppress_fib.py::test_suppress_fib_stress no longer has packet count mismatch failures.
opcoder0
pushed a commit
to opcoder0/sonic-mgmt
that referenced
this pull request
Dec 8, 2025
…et#19139) What is the motivation for this PR? bgp/test_bgp_suppress_fib.py::test_suppress_fib_stress failing How did you do it? Wait for config to properly take effect bgp/test_bgp_suppress_fib.py::test_credit_loop so subsequent tests can run on a clean state. How did you verify/test it? bgp/test_bgp_suppress_fib.py::test_suppress_fib_stress no longer has packet count mismatch failures. Signed-off-by: opcoder0 <110003254+opcoder0@users.noreply.github.com>
gshemesh2
pushed a commit
to gshemesh2/sonic-mgmt
that referenced
this pull request
Dec 16, 2025
…et#19139) What is the motivation for this PR? bgp/test_bgp_suppress_fib.py::test_suppress_fib_stress failing How did you do it? Wait for config to properly take effect bgp/test_bgp_suppress_fib.py::test_credit_loop so subsequent tests can run on a clean state. How did you verify/test it? bgp/test_bgp_suppress_fib.py::test_suppress_fib_stress no longer has packet count mismatch failures. Signed-off-by: Guy Shemesh <gshemesh@nvidia.com>
AharonMalkin
pushed a commit
to AharonMalkin/sonic-mgmt
that referenced
this pull request
Dec 16, 2025
…et#19139) What is the motivation for this PR? bgp/test_bgp_suppress_fib.py::test_suppress_fib_stress failing How did you do it? Wait for config to properly take effect bgp/test_bgp_suppress_fib.py::test_credit_loop so subsequent tests can run on a clean state. How did you verify/test it? bgp/test_bgp_suppress_fib.py::test_suppress_fib_stress no longer has packet count mismatch failures. Signed-off-by: Aharon Malkin <amalkin@nvidia.com>
gshemesh2
pushed a commit
to gshemesh2/sonic-mgmt
that referenced
this pull request
Dec 21, 2025
…et#19139) What is the motivation for this PR? bgp/test_bgp_suppress_fib.py::test_suppress_fib_stress failing How did you do it? Wait for config to properly take effect bgp/test_bgp_suppress_fib.py::test_credit_loop so subsequent tests can run on a clean state. How did you verify/test it? bgp/test_bgp_suppress_fib.py::test_suppress_fib_stress no longer has packet count mismatch failures. Signed-off-by: Guy Shemesh <gshemesh@nvidia.com>
venu-nexthop
pushed a commit
to venu-nexthop/sonic-mgmt
that referenced
this pull request
Jan 13, 2026
…et#19139) What is the motivation for this PR? bgp/test_bgp_suppress_fib.py::test_suppress_fib_stress failing How did you do it? Wait for config to properly take effect bgp/test_bgp_suppress_fib.py::test_credit_loop so subsequent tests can run on a clean state. How did you verify/test it? bgp/test_bgp_suppress_fib.py::test_suppress_fib_stress no longer has packet count mismatch failures.
gshemesh2
pushed a commit
to gshemesh2/sonic-mgmt
that referenced
this pull request
Jan 26, 2026
…et#19139) What is the motivation for this PR? bgp/test_bgp_suppress_fib.py::test_suppress_fib_stress failing How did you do it? Wait for config to properly take effect bgp/test_bgp_suppress_fib.py::test_credit_loop so subsequent tests can run on a clean state. How did you verify/test it? bgp/test_bgp_suppress_fib.py::test_suppress_fib_stress no longer has packet count mismatch failures. Signed-off-by: Guy Shemesh <gshemesh@nvidia.com>
ytzur1
pushed a commit
to ytzur1/sonic-mgmt
that referenced
this pull request
Feb 2, 2026
…et#19139) What is the motivation for this PR? bgp/test_bgp_suppress_fib.py::test_suppress_fib_stress failing How did you do it? Wait for config to properly take effect bgp/test_bgp_suppress_fib.py::test_credit_loop so subsequent tests can run on a clean state. How did you verify/test it? bgp/test_bgp_suppress_fib.py::test_suppress_fib_stress no longer has packet count mismatch failures. Signed-off-by: Yael Tzur <ytzur@nvidia.com>
venu-nexthop
pushed a commit
to venu-nexthop/sonic-mgmt
that referenced
this pull request
Mar 27, 2026
…et#19139) What is the motivation for this PR? bgp/test_bgp_suppress_fib.py::test_suppress_fib_stress failing How did you do it? Wait for config to properly take effect bgp/test_bgp_suppress_fib.py::test_credit_loop so subsequent tests can run on a clean state. How did you verify/test it? bgp/test_bgp_suppress_fib.py::test_suppress_fib_stress no longer has packet count mismatch failures.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
There is a failure with
bgp/test_bgp_suppress_fib.py::test_suppress_fib_stress, where there is a packet count mismatch within thetest_suppress_fib_stresstest case.This failure only occurs when the
test_suppress_fib_stresstest case is run right aftertest_credit_loop.One of the bgp config changes in
test_credit_loopis not validated, and it seems it is causing issues in bgp config state when the test runs before the config change is fully made. Although it does not impacttest_credit_loop, it impacts the subsequent test case (test_suppress_fib_stress).Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
bgp/test_bgp_suppress_fib.py::test_suppress_fib_stressfailingHow did you do it?
Wait for config to properly take effect
bgp/test_bgp_suppress_fib.py::test_credit_loopso subsequent tests can run on a clean state.How did you verify/test it?
bgp/test_bgp_suppress_fib.py::test_suppress_fib_stressno longer has packet count mismatch failures.Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation