Skip to content

Fix test_duplicate_route.py as per new orchagent crash handling changes#19104

Merged
yejianquan merged 1 commit intosonic-net:202505from
prabhataravind:paravind/duplicate_route_fix
Jun 20, 2025
Merged

Fix test_duplicate_route.py as per new orchagent crash handling changes#19104
yejianquan merged 1 commit intosonic-net:202505from
prabhataravind:paravind/duplicate_route_fix

Conversation

@prabhataravind
Copy link
Contributor

Description of PR

Summary:
Fixes # (issue)

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • New Test case
    • Skipped for non-supported platforms
  • Test case improvement

Back port request

  • 202205
  • 202305
  • 202311
  • 202405
  • 202411
  • 202505

Approach

What is the motivation for this PR?

How did you do it?

How did you verify/test it?

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

@mssonicbld
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

 * Following changes in sonic-net/sonic-swss#3587,
test_duplicate_route.py needs to be updated accordingly.

* Skip the test temporarily until swss submodule update is complete to avoid
  failures due to a circular dependency.

Signed-off-by: Prabhat Aravind <[email protected]>
@prabhataravind prabhataravind force-pushed the paravind/duplicate_route_fix branch from 9ece769 to 2d637f7 Compare June 20, 2025 01:27
@mssonicbld
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@prabhataravind prabhataravind marked this pull request as ready for review June 20, 2025 02:19
Copy link
Collaborator

@yejianquan yejianquan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yejianquan yejianquan merged commit 53bf39c into sonic-net:202505 Jun 20, 2025
17 checks passed
@xixuej
Copy link
Contributor

xixuej commented Oct 16, 2025

Hi @prabhataravind , do you have a task or issue to track the update of the test case?

@xixuej what issue are you referring to? I am not aware of any.

@prabhataravind prabhataravind deleted the paravind/duplicate_route_fix branch October 16, 2025 02:05
@xixuej
Copy link
Contributor

xixuej commented Oct 20, 2025

Hi @prabhataravind , you skipped test route/test_duplicate_route.py in this PR. When will the test case be fixed? Also, the master branch also has the same issue, probably you should also create a PR to skip in master branch until the test case can pass?

@prabhataravind
Copy link
Contributor Author

Hi @prabhataravind , you skipped test route/test_duplicate_route.py in this PR. When will the test case be fixed? Also, the master branch also has the same issue, probably you should also create a PR to skip in master branch until the test case can pass?

@xixuej we should be ok to remove the skip now. The failure in master is due to a different change. sonic-mgmt changes corresponding to orchagent crash handling changes were already merged to master via #19102. The failure you are likely seeing is potentially a different one - #20231

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants