Skip gnoi warm reboot test on t1-lag#18931
Merged
wangxin merged 1 commit intosonic-net:masterfrom Jun 13, 2025
Merged
Conversation
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
wangxin
approved these changes
Jun 13, 2025
nissampa
pushed a commit
to nissampa/sonic-mgmt_dpu_test
that referenced
this pull request
Aug 7, 2025
What is the motivation for this PR? tests/gnmi/test_gnoi_system_reboot.py will test warm reboot on t1-lag, but warm reboot should only be run on t0, running on t1-lag may have some error syslog and fail the test or following test 2025 May 18 23:03:55.351396 vlab-03 NOTICE sysmgr#sysmgr#rebootbackend: :- HandleRebootRequest: Forwarding request to RebootThread: method: WARM#012message: "gnoi test reboot" 2025 May 18 23:03:55.351396 vlab-03 NOTICE sysmgr#sysmgr#rebootbackend: :- do_warm_reboot: Sending warm reboot request to platform 2025 May 18 23:03:55.351396 vlab-03 NOTICE sysmgr#sysmgr#rebootbackend: :- send_dbus_reboot_request: Sending reboot request to platform 2025 May 18 23:03:55.369017 vlab-03 INFO python3[6688]: reboot: issue_reboot rpc called 2025 May 18 23:03:55.374217 vlab-03 INFO python3[6688]: reboot: Issuing WARM reboot 2025 May 18 23:03:55.383701 vlab-03 INFO python3[6688]: /usr/lib/python3.11/subprocess.py:1014: RuntimeWarning: line buffering (buffering=1) isn't supported in binary mode, the default buffer size will be used 2025 May 18 23:03:55.383760 vlab-03 INFO python3[6688]: self.stdout = io.open(c2pread, 'rb', bufsize) 2025 May 18 23:03:55.383789 vlab-03 INFO python3[6688]: /usr/lib/python3.11/subprocess.py:1019: RuntimeWarning: line buffering (buffering=1) isn't supported in binary mode, the default buffer size will be used 2025 May 18 23:03:55.383806 vlab-03 INFO python3[6688]: self.stderr = io.open(errread, 'rb', bufsize) 2025 May 18 23:03:55.449600 vlab-03 INFO python3[6688]: reboot: Reboot failed execution with stdout: [], stderr: ['logname: no login name'] 2025 May 18 23:08:15.378411 vlab-03 ERR sysmgr#sysmgr#rebootbackend: :- log_error_and_set_non_retry_failure: failed to warm reboot 2025 May 18 23:08:15.378411 vlab-03 WARNING sysmgr#sysmgr#rebootbackend: :- HandleRebootFinish: Receieved notification that reboot has finished. This probably means something is wrong How did you do it? Skip tests/gnmi/test_gnoi_system_reboot.py::test_gnoi_system_reboot_warm on other platforms except for t0
opcoder0
pushed a commit
to opcoder0/sonic-mgmt
that referenced
this pull request
Dec 8, 2025
What is the motivation for this PR? tests/gnmi/test_gnoi_system_reboot.py will test warm reboot on t1-lag, but warm reboot should only be run on t0, running on t1-lag may have some error syslog and fail the test or following test 2025 May 18 23:03:55.351396 vlab-03 NOTICE sysmgr#sysmgr#rebootbackend: :- HandleRebootRequest: Forwarding request to RebootThread: method: WARM#012message: "gnoi test reboot" 2025 May 18 23:03:55.351396 vlab-03 NOTICE sysmgr#sysmgr#rebootbackend: :- do_warm_reboot: Sending warm reboot request to platform 2025 May 18 23:03:55.351396 vlab-03 NOTICE sysmgr#sysmgr#rebootbackend: :- send_dbus_reboot_request: Sending reboot request to platform 2025 May 18 23:03:55.369017 vlab-03 INFO python3[6688]: reboot: issue_reboot rpc called 2025 May 18 23:03:55.374217 vlab-03 INFO python3[6688]: reboot: Issuing WARM reboot 2025 May 18 23:03:55.383701 vlab-03 INFO python3[6688]: /usr/lib/python3.11/subprocess.py:1014: RuntimeWarning: line buffering (buffering=1) isn't supported in binary mode, the default buffer size will be used 2025 May 18 23:03:55.383760 vlab-03 INFO python3[6688]: self.stdout = io.open(c2pread, 'rb', bufsize) 2025 May 18 23:03:55.383789 vlab-03 INFO python3[6688]: /usr/lib/python3.11/subprocess.py:1019: RuntimeWarning: line buffering (buffering=1) isn't supported in binary mode, the default buffer size will be used 2025 May 18 23:03:55.383806 vlab-03 INFO python3[6688]: self.stderr = io.open(errread, 'rb', bufsize) 2025 May 18 23:03:55.449600 vlab-03 INFO python3[6688]: reboot: Reboot failed execution with stdout: [], stderr: ['logname: no login name'] 2025 May 18 23:08:15.378411 vlab-03 ERR sysmgr#sysmgr#rebootbackend: :- log_error_and_set_non_retry_failure: failed to warm reboot 2025 May 18 23:08:15.378411 vlab-03 WARNING sysmgr#sysmgr#rebootbackend: :- HandleRebootFinish: Receieved notification that reboot has finished. This probably means something is wrong How did you do it? Skip tests/gnmi/test_gnoi_system_reboot.py::test_gnoi_system_reboot_warm on other platforms except for t0 Signed-off-by: opcoder0 <110003254+opcoder0@users.noreply.github.com>
gshemesh2
pushed a commit
to gshemesh2/sonic-mgmt
that referenced
this pull request
Dec 16, 2025
What is the motivation for this PR? tests/gnmi/test_gnoi_system_reboot.py will test warm reboot on t1-lag, but warm reboot should only be run on t0, running on t1-lag may have some error syslog and fail the test or following test 2025 May 18 23:03:55.351396 vlab-03 NOTICE sysmgr#sysmgr#rebootbackend: :- HandleRebootRequest: Forwarding request to RebootThread: method: WARM#012message: "gnoi test reboot" 2025 May 18 23:03:55.351396 vlab-03 NOTICE sysmgr#sysmgr#rebootbackend: :- do_warm_reboot: Sending warm reboot request to platform 2025 May 18 23:03:55.351396 vlab-03 NOTICE sysmgr#sysmgr#rebootbackend: :- send_dbus_reboot_request: Sending reboot request to platform 2025 May 18 23:03:55.369017 vlab-03 INFO python3[6688]: reboot: issue_reboot rpc called 2025 May 18 23:03:55.374217 vlab-03 INFO python3[6688]: reboot: Issuing WARM reboot 2025 May 18 23:03:55.383701 vlab-03 INFO python3[6688]: /usr/lib/python3.11/subprocess.py:1014: RuntimeWarning: line buffering (buffering=1) isn't supported in binary mode, the default buffer size will be used 2025 May 18 23:03:55.383760 vlab-03 INFO python3[6688]: self.stdout = io.open(c2pread, 'rb', bufsize) 2025 May 18 23:03:55.383789 vlab-03 INFO python3[6688]: /usr/lib/python3.11/subprocess.py:1019: RuntimeWarning: line buffering (buffering=1) isn't supported in binary mode, the default buffer size will be used 2025 May 18 23:03:55.383806 vlab-03 INFO python3[6688]: self.stderr = io.open(errread, 'rb', bufsize) 2025 May 18 23:03:55.449600 vlab-03 INFO python3[6688]: reboot: Reboot failed execution with stdout: [], stderr: ['logname: no login name'] 2025 May 18 23:08:15.378411 vlab-03 ERR sysmgr#sysmgr#rebootbackend: :- log_error_and_set_non_retry_failure: failed to warm reboot 2025 May 18 23:08:15.378411 vlab-03 WARNING sysmgr#sysmgr#rebootbackend: :- HandleRebootFinish: Receieved notification that reboot has finished. This probably means something is wrong How did you do it? Skip tests/gnmi/test_gnoi_system_reboot.py::test_gnoi_system_reboot_warm on other platforms except for t0 Signed-off-by: Guy Shemesh <gshemesh@nvidia.com>
AharonMalkin
pushed a commit
to AharonMalkin/sonic-mgmt
that referenced
this pull request
Dec 16, 2025
What is the motivation for this PR? tests/gnmi/test_gnoi_system_reboot.py will test warm reboot on t1-lag, but warm reboot should only be run on t0, running on t1-lag may have some error syslog and fail the test or following test 2025 May 18 23:03:55.351396 vlab-03 NOTICE sysmgr#sysmgr#rebootbackend: :- HandleRebootRequest: Forwarding request to RebootThread: method: WARM#012message: "gnoi test reboot" 2025 May 18 23:03:55.351396 vlab-03 NOTICE sysmgr#sysmgr#rebootbackend: :- do_warm_reboot: Sending warm reboot request to platform 2025 May 18 23:03:55.351396 vlab-03 NOTICE sysmgr#sysmgr#rebootbackend: :- send_dbus_reboot_request: Sending reboot request to platform 2025 May 18 23:03:55.369017 vlab-03 INFO python3[6688]: reboot: issue_reboot rpc called 2025 May 18 23:03:55.374217 vlab-03 INFO python3[6688]: reboot: Issuing WARM reboot 2025 May 18 23:03:55.383701 vlab-03 INFO python3[6688]: /usr/lib/python3.11/subprocess.py:1014: RuntimeWarning: line buffering (buffering=1) isn't supported in binary mode, the default buffer size will be used 2025 May 18 23:03:55.383760 vlab-03 INFO python3[6688]: self.stdout = io.open(c2pread, 'rb', bufsize) 2025 May 18 23:03:55.383789 vlab-03 INFO python3[6688]: /usr/lib/python3.11/subprocess.py:1019: RuntimeWarning: line buffering (buffering=1) isn't supported in binary mode, the default buffer size will be used 2025 May 18 23:03:55.383806 vlab-03 INFO python3[6688]: self.stderr = io.open(errread, 'rb', bufsize) 2025 May 18 23:03:55.449600 vlab-03 INFO python3[6688]: reboot: Reboot failed execution with stdout: [], stderr: ['logname: no login name'] 2025 May 18 23:08:15.378411 vlab-03 ERR sysmgr#sysmgr#rebootbackend: :- log_error_and_set_non_retry_failure: failed to warm reboot 2025 May 18 23:08:15.378411 vlab-03 WARNING sysmgr#sysmgr#rebootbackend: :- HandleRebootFinish: Receieved notification that reboot has finished. This probably means something is wrong How did you do it? Skip tests/gnmi/test_gnoi_system_reboot.py::test_gnoi_system_reboot_warm on other platforms except for t0 Signed-off-by: Aharon Malkin <amalkin@nvidia.com>
gshemesh2
pushed a commit
to gshemesh2/sonic-mgmt
that referenced
this pull request
Dec 21, 2025
What is the motivation for this PR? tests/gnmi/test_gnoi_system_reboot.py will test warm reboot on t1-lag, but warm reboot should only be run on t0, running on t1-lag may have some error syslog and fail the test or following test 2025 May 18 23:03:55.351396 vlab-03 NOTICE sysmgr#sysmgr#rebootbackend: :- HandleRebootRequest: Forwarding request to RebootThread: method: WARM#012message: "gnoi test reboot" 2025 May 18 23:03:55.351396 vlab-03 NOTICE sysmgr#sysmgr#rebootbackend: :- do_warm_reboot: Sending warm reboot request to platform 2025 May 18 23:03:55.351396 vlab-03 NOTICE sysmgr#sysmgr#rebootbackend: :- send_dbus_reboot_request: Sending reboot request to platform 2025 May 18 23:03:55.369017 vlab-03 INFO python3[6688]: reboot: issue_reboot rpc called 2025 May 18 23:03:55.374217 vlab-03 INFO python3[6688]: reboot: Issuing WARM reboot 2025 May 18 23:03:55.383701 vlab-03 INFO python3[6688]: /usr/lib/python3.11/subprocess.py:1014: RuntimeWarning: line buffering (buffering=1) isn't supported in binary mode, the default buffer size will be used 2025 May 18 23:03:55.383760 vlab-03 INFO python3[6688]: self.stdout = io.open(c2pread, 'rb', bufsize) 2025 May 18 23:03:55.383789 vlab-03 INFO python3[6688]: /usr/lib/python3.11/subprocess.py:1019: RuntimeWarning: line buffering (buffering=1) isn't supported in binary mode, the default buffer size will be used 2025 May 18 23:03:55.383806 vlab-03 INFO python3[6688]: self.stderr = io.open(errread, 'rb', bufsize) 2025 May 18 23:03:55.449600 vlab-03 INFO python3[6688]: reboot: Reboot failed execution with stdout: [], stderr: ['logname: no login name'] 2025 May 18 23:08:15.378411 vlab-03 ERR sysmgr#sysmgr#rebootbackend: :- log_error_and_set_non_retry_failure: failed to warm reboot 2025 May 18 23:08:15.378411 vlab-03 WARNING sysmgr#sysmgr#rebootbackend: :- HandleRebootFinish: Receieved notification that reboot has finished. This probably means something is wrong How did you do it? Skip tests/gnmi/test_gnoi_system_reboot.py::test_gnoi_system_reboot_warm on other platforms except for t0 Signed-off-by: Guy Shemesh <gshemesh@nvidia.com>
venu-nexthop
pushed a commit
to venu-nexthop/sonic-mgmt
that referenced
this pull request
Jan 13, 2026
What is the motivation for this PR? tests/gnmi/test_gnoi_system_reboot.py will test warm reboot on t1-lag, but warm reboot should only be run on t0, running on t1-lag may have some error syslog and fail the test or following test 2025 May 18 23:03:55.351396 vlab-03 NOTICE sysmgr#sysmgr#rebootbackend: :- HandleRebootRequest: Forwarding request to RebootThread: method: WARM#012message: "gnoi test reboot" 2025 May 18 23:03:55.351396 vlab-03 NOTICE sysmgr#sysmgr#rebootbackend: :- do_warm_reboot: Sending warm reboot request to platform 2025 May 18 23:03:55.351396 vlab-03 NOTICE sysmgr#sysmgr#rebootbackend: :- send_dbus_reboot_request: Sending reboot request to platform 2025 May 18 23:03:55.369017 vlab-03 INFO python3[6688]: reboot: issue_reboot rpc called 2025 May 18 23:03:55.374217 vlab-03 INFO python3[6688]: reboot: Issuing WARM reboot 2025 May 18 23:03:55.383701 vlab-03 INFO python3[6688]: /usr/lib/python3.11/subprocess.py:1014: RuntimeWarning: line buffering (buffering=1) isn't supported in binary mode, the default buffer size will be used 2025 May 18 23:03:55.383760 vlab-03 INFO python3[6688]: self.stdout = io.open(c2pread, 'rb', bufsize) 2025 May 18 23:03:55.383789 vlab-03 INFO python3[6688]: /usr/lib/python3.11/subprocess.py:1019: RuntimeWarning: line buffering (buffering=1) isn't supported in binary mode, the default buffer size will be used 2025 May 18 23:03:55.383806 vlab-03 INFO python3[6688]: self.stderr = io.open(errread, 'rb', bufsize) 2025 May 18 23:03:55.449600 vlab-03 INFO python3[6688]: reboot: Reboot failed execution with stdout: [], stderr: ['logname: no login name'] 2025 May 18 23:08:15.378411 vlab-03 ERR sysmgr#sysmgr#rebootbackend: :- log_error_and_set_non_retry_failure: failed to warm reboot 2025 May 18 23:08:15.378411 vlab-03 WARNING sysmgr#sysmgr#rebootbackend: :- HandleRebootFinish: Receieved notification that reboot has finished. This probably means something is wrong How did you do it? Skip tests/gnmi/test_gnoi_system_reboot.py::test_gnoi_system_reboot_warm on other platforms except for t0
gshemesh2
pushed a commit
to gshemesh2/sonic-mgmt
that referenced
this pull request
Jan 26, 2026
What is the motivation for this PR? tests/gnmi/test_gnoi_system_reboot.py will test warm reboot on t1-lag, but warm reboot should only be run on t0, running on t1-lag may have some error syslog and fail the test or following test 2025 May 18 23:03:55.351396 vlab-03 NOTICE sysmgr#sysmgr#rebootbackend: :- HandleRebootRequest: Forwarding request to RebootThread: method: WARM#012message: "gnoi test reboot" 2025 May 18 23:03:55.351396 vlab-03 NOTICE sysmgr#sysmgr#rebootbackend: :- do_warm_reboot: Sending warm reboot request to platform 2025 May 18 23:03:55.351396 vlab-03 NOTICE sysmgr#sysmgr#rebootbackend: :- send_dbus_reboot_request: Sending reboot request to platform 2025 May 18 23:03:55.369017 vlab-03 INFO python3[6688]: reboot: issue_reboot rpc called 2025 May 18 23:03:55.374217 vlab-03 INFO python3[6688]: reboot: Issuing WARM reboot 2025 May 18 23:03:55.383701 vlab-03 INFO python3[6688]: /usr/lib/python3.11/subprocess.py:1014: RuntimeWarning: line buffering (buffering=1) isn't supported in binary mode, the default buffer size will be used 2025 May 18 23:03:55.383760 vlab-03 INFO python3[6688]: self.stdout = io.open(c2pread, 'rb', bufsize) 2025 May 18 23:03:55.383789 vlab-03 INFO python3[6688]: /usr/lib/python3.11/subprocess.py:1019: RuntimeWarning: line buffering (buffering=1) isn't supported in binary mode, the default buffer size will be used 2025 May 18 23:03:55.383806 vlab-03 INFO python3[6688]: self.stderr = io.open(errread, 'rb', bufsize) 2025 May 18 23:03:55.449600 vlab-03 INFO python3[6688]: reboot: Reboot failed execution with stdout: [], stderr: ['logname: no login name'] 2025 May 18 23:08:15.378411 vlab-03 ERR sysmgr#sysmgr#rebootbackend: :- log_error_and_set_non_retry_failure: failed to warm reboot 2025 May 18 23:08:15.378411 vlab-03 WARNING sysmgr#sysmgr#rebootbackend: :- HandleRebootFinish: Receieved notification that reboot has finished. This probably means something is wrong How did you do it? Skip tests/gnmi/test_gnoi_system_reboot.py::test_gnoi_system_reboot_warm on other platforms except for t0 Signed-off-by: Guy Shemesh <gshemesh@nvidia.com>
ytzur1
pushed a commit
to ytzur1/sonic-mgmt
that referenced
this pull request
Feb 2, 2026
What is the motivation for this PR? tests/gnmi/test_gnoi_system_reboot.py will test warm reboot on t1-lag, but warm reboot should only be run on t0, running on t1-lag may have some error syslog and fail the test or following test 2025 May 18 23:03:55.351396 vlab-03 NOTICE sysmgr#sysmgr#rebootbackend: :- HandleRebootRequest: Forwarding request to RebootThread: method: WARM#012message: "gnoi test reboot" 2025 May 18 23:03:55.351396 vlab-03 NOTICE sysmgr#sysmgr#rebootbackend: :- do_warm_reboot: Sending warm reboot request to platform 2025 May 18 23:03:55.351396 vlab-03 NOTICE sysmgr#sysmgr#rebootbackend: :- send_dbus_reboot_request: Sending reboot request to platform 2025 May 18 23:03:55.369017 vlab-03 INFO python3[6688]: reboot: issue_reboot rpc called 2025 May 18 23:03:55.374217 vlab-03 INFO python3[6688]: reboot: Issuing WARM reboot 2025 May 18 23:03:55.383701 vlab-03 INFO python3[6688]: /usr/lib/python3.11/subprocess.py:1014: RuntimeWarning: line buffering (buffering=1) isn't supported in binary mode, the default buffer size will be used 2025 May 18 23:03:55.383760 vlab-03 INFO python3[6688]: self.stdout = io.open(c2pread, 'rb', bufsize) 2025 May 18 23:03:55.383789 vlab-03 INFO python3[6688]: /usr/lib/python3.11/subprocess.py:1019: RuntimeWarning: line buffering (buffering=1) isn't supported in binary mode, the default buffer size will be used 2025 May 18 23:03:55.383806 vlab-03 INFO python3[6688]: self.stderr = io.open(errread, 'rb', bufsize) 2025 May 18 23:03:55.449600 vlab-03 INFO python3[6688]: reboot: Reboot failed execution with stdout: [], stderr: ['logname: no login name'] 2025 May 18 23:08:15.378411 vlab-03 ERR sysmgr#sysmgr#rebootbackend: :- log_error_and_set_non_retry_failure: failed to warm reboot 2025 May 18 23:08:15.378411 vlab-03 WARNING sysmgr#sysmgr#rebootbackend: :- HandleRebootFinish: Receieved notification that reboot has finished. This probably means something is wrong How did you do it? Skip tests/gnmi/test_gnoi_system_reboot.py::test_gnoi_system_reboot_warm on other platforms except for t0 Signed-off-by: Yael Tzur <ytzur@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
tests/gnmi/test_gnoi_system_reboot.py will test warm reboot on t1-lag, but warm reboot should only be run on t0, running on t1-lag may have some error syslog and fail the test or following test
How did you do it?
Skip tests/gnmi/test_gnoi_system_reboot.py::test_gnoi_system_reboot_warm on other platforms except for t0
How did you verify/test it?
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation