Skip to content

[Snappi] - Test Changes to support dynamic port selection for PFC pau… #18886

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yejianquan merged 2 commits into from
Jun 13, 2025
+79 −73
Merged

[Snappi] - Test Changes to support dynamic port selection for PFC pau… #18886

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
062d49c
[Snappi] - Test Changes to support dynamic port selection for PFC pau…
selldinesh Jun 9, 2025
6e74ff0
pre-commit fixes
selldinesh Jun 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
152 changes: 79 additions & 73 deletions tests/snappi_tests/pfc/test_pfc_pause_lossy_with_snappi.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,13 +3,11 @@
from tests.common.fixtures.conn_graph_facts import conn_graph_facts, fanout_graph_facts, \
fanout_graph_facts_multidut # noqa: F401
from tests.common.snappi_tests.snappi_fixtures import snappi_api_serv_ip, snappi_api_serv_port, \
snappi_api, snappi_dut_base_config, get_snappi_ports_for_rdma, cleanup_config, \
get_snappi_ports_single_dut, snappi_testbed_config, \
get_snappi_ports_multi_dut, is_snappi_multidut, \
get_snappi_ports # noqa: F401
get_snappi_ports_multi_dut, is_snappi_multidut, snappi_port_selection, tgen_port_info, \
snappi_api, snappi_dut_base_config, get_snappi_ports, get_snappi_ports_for_rdma, cleanup_config # noqa: F401
from tests.common.snappi_tests.qos_fixtures import prio_dscp_map, all_prio_list, lossless_prio_list,\
lossy_prio_list # noqa F401
from tests.snappi_tests.variables import MULTIDUT_PORT_INFO, MULTIDUT_TESTBED # noqa: F401
from tests.snappi_tests.pfc.files.helper import run_pfc_test
import logging
from tests.common.snappi_tests.snappi_test_params import SnappiTestParams
Expand All @@ -20,7 +18,7 @@
pytestmark = [pytest.mark.topology('multidut-tgen', 'tgen')]


@pytest.fixture(autouse=True)
@pytest.fixture(autouse=True, scope='module')
def number_of_tx_rx_ports():
yield (1, 1)

Expand All @@ -36,7 +34,7 @@ def test_pfc_pause_single_lossy_prio(snappi_api, # noqa: F811
lossless_prio_list, # noqa: F811
get_snappi_ports, # noqa: F811
tbinfo, # noqa: F811
setup_ports_and_dut # noqa: F811
tgen_port_info # noqa: F811
):
"""
Test if PFC will impact a single lossy priority in multidut setup
Expand All @@ -56,37 +54,38 @@ def test_pfc_pause_single_lossy_prio(snappi_api, # noqa: F811
Returns:
N/A
"""
testbed_config, port_config_list, snappi_ports = setup_ports_and_dut
testbed_config, port_config_list, snappi_ports = tgen_port_info

_, lossy_prio = enum_one_dut_lossy_prio.split('|')
lossy_prio = int(lossy_prio)
pause_prio_list = [lossy_prio]
test_prio_list = [lossy_prio]
bg_prio_list = [p for p in all_prio_list]
bg_prio_list.remove(lossy_prio)

snappi_extra_params = SnappiTestParams()
snappi_extra_params.multi_dut_params.multi_dut_ports = snappi_ports

flow_factor = 1

if snappi_ports[0]['asic_type'] == 'cisco-8000' and int(snappi_ports[0]['speed']) > 200000:
flow_factor = int(snappi_ports[0]['speed']) / 200000

run_pfc_test(api=snappi_api,
testbed_config=testbed_config,
port_config_list=port_config_list,
conn_data=conn_graph_facts,
fanout_data=fanout_graph_facts_multidut,
global_pause=False,
pause_prio_list=pause_prio_list,
test_prio_list=test_prio_list,
bg_prio_list=bg_prio_list,
prio_dscp_map=prio_dscp_map,
test_traffic_pause=False,
test_flow_is_lossless=False,
snappi_extra_params=snappi_extra_params,
flow_factor=flow_factor)
try:
run_pfc_test(api=snappi_api,
testbed_config=testbed_config,
port_config_list=port_config_list,
conn_data=conn_graph_facts,
fanout_data=fanout_graph_facts_multidut,
global_pause=False,
pause_prio_list=pause_prio_list,
test_prio_list=test_prio_list,
bg_prio_list=bg_prio_list,
prio_dscp_map=prio_dscp_map,
test_traffic_pause=False,
test_flow_is_lossless=False,
snappi_extra_params=snappi_extra_params,
flow_factor=flow_factor)
finally:
cleanup_config(duthosts, snappi_ports)


def test_pfc_pause_multi_lossy_prio(snappi_api, # noqa: F811
Expand All @@ -98,7 +97,7 @@ def test_pfc_pause_multi_lossy_prio(snappi_api, # noqa: F811
lossless_prio_list, # noqa: F811
get_snappi_ports, # noqa: F811
tbinfo, # noqa: F811
setup_ports_and_dut): # noqa: F811
tgen_port_info): # noqa: F811
"""
Test if PFC will impact multiple lossy priorities in multidut setup

Expand All @@ -115,7 +114,7 @@ def test_pfc_pause_multi_lossy_prio(snappi_api, # noqa: F811
Returns:
N/A
"""
testbed_config, port_config_list, snappi_ports = setup_ports_and_dut
testbed_config, port_config_list, snappi_ports = tgen_port_info

pause_prio_list = lossy_prio_list
test_prio_list = lossy_prio_list
Expand All @@ -128,21 +127,23 @@ def test_pfc_pause_multi_lossy_prio(snappi_api, # noqa: F811

if snappi_ports[0]['asic_type'] == 'cisco-8000' and int(snappi_ports[0]['speed']) > 200000:
flow_factor = int(snappi_ports[0]['speed']) / 200000

run_pfc_test(api=snappi_api,
testbed_config=testbed_config,
port_config_list=port_config_list,
conn_data=conn_graph_facts,
fanout_data=fanout_graph_facts_multidut,
global_pause=False,
pause_prio_list=pause_prio_list,
test_prio_list=test_prio_list,
bg_prio_list=bg_prio_list,
prio_dscp_map=prio_dscp_map,
test_traffic_pause=False,
test_flow_is_lossless=False,
snappi_extra_params=snappi_extra_params,
flow_factor=flow_factor)
try:
run_pfc_test(api=snappi_api,
testbed_config=testbed_config,
port_config_list=port_config_list,
conn_data=conn_graph_facts,
fanout_data=fanout_graph_facts_multidut,
global_pause=False,
pause_prio_list=pause_prio_list,
test_prio_list=test_prio_list,
bg_prio_list=bg_prio_list,
prio_dscp_map=prio_dscp_map,
test_traffic_pause=False,
test_flow_is_lossless=False,
snappi_extra_params=snappi_extra_params,
flow_factor=flow_factor)
finally:
cleanup_config(duthosts, snappi_ports)


@pytest.mark.disable_loganalyzer
Expand All @@ -158,7 +159,7 @@ def test_pfc_pause_single_lossy_prio_reboot(snappi_api, # noqa: F811
lossless_prio_list, # noqa: F811
get_snappi_ports, # noqa: F811
tbinfo, # noqa: F811
setup_ports_and_dut, # noqa: F811
tgen_port_info, # noqa: F811
reboot_duts): # noqa: F811
"""
Test if PFC will impact a single lossy priority after various kinds of reboots in multidut setup
Expand All @@ -179,7 +180,7 @@ def test_pfc_pause_single_lossy_prio_reboot(snappi_api, # noqa: F811
Returns:
N/A
"""
testbed_config, port_config_list, snappi_ports = setup_ports_and_dut
testbed_config, port_config_list, snappi_ports = tgen_port_info

_, lossy_prio = enum_one_dut_lossy_prio_with_completeness_level.split('|')
lossy_prio = int(lossy_prio)
Expand All @@ -196,20 +197,23 @@ def test_pfc_pause_single_lossy_prio_reboot(snappi_api, # noqa: F811
if snappi_ports[0]['asic_type'] == 'cisco-8000' and int(snappi_ports[0]['speed']) > 200000:
flow_factor = int(snappi_ports[0]['speed']) / 200000

run_pfc_test(api=snappi_api,
testbed_config=testbed_config,
port_config_list=port_config_list,
conn_data=conn_graph_facts,
fanout_data=fanout_graph_facts_multidut,
global_pause=False,
pause_prio_list=pause_prio_list,
test_prio_list=test_prio_list,
bg_prio_list=bg_prio_list,
prio_dscp_map=prio_dscp_map,
test_traffic_pause=False,
test_flow_is_lossless=False,
snappi_extra_params=snappi_extra_params,
flow_factor=flow_factor)
try:
run_pfc_test(api=snappi_api,
testbed_config=testbed_config,
port_config_list=port_config_list,
conn_data=conn_graph_facts,
fanout_data=fanout_graph_facts_multidut,
global_pause=False,
pause_prio_list=pause_prio_list,
test_prio_list=test_prio_list,
bg_prio_list=bg_prio_list,
prio_dscp_map=prio_dscp_map,
test_traffic_pause=False,
test_flow_is_lossless=False,
snappi_extra_params=snappi_extra_params,
flow_factor=flow_factor)
finally:
cleanup_config(duthosts, snappi_ports)


@pytest.mark.disable_loganalyzer
Expand All @@ -223,7 +227,7 @@ def test_pfc_pause_multi_lossy_prio_reboot(snappi_api, # noqa: F811
lossless_prio_list, # noqa: F811
get_snappi_ports, # noqa: F811
tbinfo, # noqa: F811
setup_ports_and_dut, # noqa: F811
tgen_port_info, # noqa: F811
reboot_duts): # noqa: F811
"""
Test if PFC will impact multiple lossy priorities after various kinds of reboots
Expand All @@ -244,7 +248,7 @@ def test_pfc_pause_multi_lossy_prio_reboot(snappi_api, # noqa: F811
Returns:
N/A
"""
testbed_config, port_config_list, snappi_ports = setup_ports_and_dut
testbed_config, port_config_list, snappi_ports = tgen_port_info

pause_prio_list = lossy_prio_list
test_prio_list = lossy_prio_list
Expand All @@ -257,18 +261,20 @@ def test_pfc_pause_multi_lossy_prio_reboot(snappi_api, # noqa: F811

if snappi_ports[0]['asic_type'] == 'cisco-8000' and int(snappi_ports[0]['speed']) > 200000:
flow_factor = int(snappi_ports[0]['speed']) / 200000

run_pfc_test(api=snappi_api,
testbed_config=testbed_config,
port_config_list=port_config_list,
conn_data=conn_graph_facts,
fanout_data=fanout_graph_facts_multidut,
global_pause=False,
pause_prio_list=pause_prio_list,
test_prio_list=test_prio_list,
bg_prio_list=bg_prio_list,
prio_dscp_map=prio_dscp_map,
test_traffic_pause=False,
test_flow_is_lossless=False,
snappi_extra_params=snappi_extra_params,
flow_factor=flow_factor)
try:
run_pfc_test(api=snappi_api,
testbed_config=testbed_config,
port_config_list=port_config_list,
conn_data=conn_graph_facts,
fanout_data=fanout_graph_facts_multidut,
global_pause=False,
pause_prio_list=pause_prio_list,
test_prio_list=test_prio_list,
bg_prio_list=bg_prio_list,
prio_dscp_map=prio_dscp_map,
test_traffic_pause=False,
test_flow_is_lossless=False,
snappi_extra_params=snappi_extra_params,
flow_factor=flow_factor)
finally:
cleanup_config(duthosts, snappi_ports)
Loading