[action] [PR:18828] [dualtor-io] Fix duplication merge condition#18840
Merged
mssonicbld merged 1 commit intosonic-net:202411from Jun 6, 2025
Merged
[action] [PR:18828] [dualtor-io] Fix duplication merge condition#18840mssonicbld merged 1 commit intosonic-net:202411from
mssonicbld merged 1 commit intosonic-net:202411from
Conversation
What is the motivation for this PR? Work Item: 33161844 Actually, there is only one disruption, but due to the vlan flooding behavior, packet with id 70 is flooded in the vlan and received; so two disruptions are detected. So for this case, the following two disruptions should be merged into one. How did you do it? Change the merge condition to allow merge in this case. How did you verify/test it? Run on Cisco dualtor testbed and pass. Signed-off-by: Longxiang Lyu <[email protected]>
11 tasks
Collaborator
Author
|
Original PR: #18828 |
Collaborator
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
Work Item: 33161844
Fix the
dualtor_io.test_link_failure.test_active_link_down_downstream_active_soc[active-active]failure:The server 192.168.0.15 I/O result shows that there are two disruptions:
Actually, there is only one disruption, but due to the vlan flooding behavior, packet with id 70 is flooded in the vlan and received; so two disruptions are detected.
So for this case, the following two disruptions should be merged into one.
Signed-off-by: Longxiang Lyu [email protected]
How did you do it?
Change the merge condition to allow merge in this case.
How did you verify/test it?
Run on Cisco dualtor testbed and pass.
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation