[dhcp_relay] Verify per-interface counter in test_dhcp_relay.py by zypgithub · Pull Request #18796 · sonic-net/sonic-mgmt

zypgithub · 2025-06-04T09:15:19Z

Description of PR

Summary:
Fixes # (issue)

Type of change

Bug fix
[] Testbed and Framework(new/improvement)
New Test case
- Skipped for non-supported platforms
Test case improvement

Back port request

Approach

What is the motivation for this PR?

Currently, we only have syslog based test case for DHCP relay counter.
This improvement adds the DHCPv4 relay per-interface counter test.

How did you do it?

Check the DHCP relay counters in uplinks and downlinks

How did you verify/test it?

Run test case

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

Test plan: #19138

linux-foundation-easycla · 2025-06-04T09:15:24Z

The committers listed above are authorized under a signed CLA.

✅ login: zypgithub / name: Yanpeng Zhang (1db66a7, 529ec8c, e47c98e, 2f5c8ef, b855521, 65ada8a, 982a4af)

mssonicbld · 2025-06-05T02:36:12Z

/azp run

azure-pipelines · 2025-06-05T02:36:24Z

Azure Pipelines successfully started running 1 pipeline(s).

mssonicbld · 2025-06-05T02:42:37Z

/azp run

azure-pipelines · 2025-06-05T02:42:49Z

Azure Pipelines successfully started running 1 pipeline(s).

mssonicbld · 2025-06-05T02:51:01Z

/azp run

azure-pipelines · 2025-06-05T02:51:13Z

Azure Pipelines successfully started running 1 pipeline(s).

zypgithub · 2025-06-05T03:00:46Z

/EasyCLA

mssonicbld · 2025-06-05T05:08:17Z

/azp run

azure-pipelines · 2025-06-05T05:08:29Z

Azure Pipelines successfully started running 1 pipeline(s).

mssonicbld · 2025-06-05T10:07:26Z

/azp run

azure-pipelines · 2025-06-05T10:07:38Z

Azure Pipelines successfully started running 1 pipeline(s).

tests/dhcp_relay/test_dhcp_relay.py

yaqiangz · 2025-06-06T05:18:36Z

tests/dhcp_relay/test_dhcp_relay.py

                loganalyzer = LogAnalyzer(ansible_host=duthost, marker_prefix="dhcpmon counter")
                marker = loganalyzer.init()
                loganalyzer.expect_regex = [expected_agg_counter_message]
+                init_and_verify_dhcp_relay_counters(duthost)


In t0 topo, we only have one tor, then it's okay to init and verify duthost. But in dualtor, we have 2 tors (1 active and 1 standby), we need to verify both tor if testing_mode == DUAL_TOR_MODE
You can refer to above syslog verification for dhcpmon

tests/dhcp_relay/test_dhcp_relay.py

mssonicbld · 2025-06-06T07:39:39Z

/azp run

azure-pipelines · 2025-06-06T07:39:52Z

Azure Pipelines successfully started running 1 pipeline(s).

mssonicbld · 2025-06-06T09:55:19Z

/azp run

azure-pipelines · 2025-06-06T09:55:32Z

Azure Pipelines successfully started running 1 pipeline(s).

mssonicbld · 2025-06-09T09:43:40Z

/azp run

azure-pipelines · 2025-06-09T09:43:53Z

Azure Pipelines successfully started running 1 pipeline(s).

mssonicbld · 2025-06-10T10:38:58Z

/azp run

azure-pipelines · 2025-06-10T10:39:11Z

Azure Pipelines successfully started running 1 pipeline(s).

yaqiangz

LGTM

mssonicbld · 2025-06-13T06:38:18Z

/azp run

azure-pipelines · 2025-06-13T06:38:30Z

Azure Pipelines successfully started running 1 pipeline(s).

…c-net#18796) What is the motivation for this PR? Currently, we only have syslog based test case for DHCP relay counter. This improvement adds the DHCPv4 relay per-interface counter test. How did you do it? Check the DHCP relay counters in uplinks and downlinks How did you verify/test it? Run test case

mssonicbld · 2025-06-25T07:04:09Z

Cherry-pick PR to 202505: #19182

What is the motivation for this PR? Currently, we only have syslog based test case for DHCP relay counter. This improvement adds the DHCPv4 relay per-interface counter test. How did you do it? Check the DHCP relay counters in uplinks and downlinks How did you verify/test it? Run test case

…c-net#18796) What is the motivation for this PR? Currently, we only have syslog based test case for DHCP relay counter. This improvement adds the DHCPv4 relay per-interface counter test. How did you do it? Check the DHCP relay counters in uplinks and downlinks How did you verify/test it? Run test case

…c-net#18796) What is the motivation for this PR? Currently, we only have syslog based test case for DHCP relay counter. This improvement adds the DHCPv4 relay per-interface counter test. How did you do it? Check the DHCP relay counters in uplinks and downlinks How did you verify/test it? Run test case Signed-off-by: opcoder0 <[email protected]>

…c-net#18796) What is the motivation for this PR? Currently, we only have syslog based test case for DHCP relay counter. This improvement adds the DHCPv4 relay per-interface counter test. How did you do it? Check the DHCP relay counters in uplinks and downlinks How did you verify/test it? Run test case Signed-off-by: Guy Shemesh <[email protected]>

…c-net#18796) What is the motivation for this PR? Currently, we only have syslog based test case for DHCP relay counter. This improvement adds the DHCPv4 relay per-interface counter test. How did you do it? Check the DHCP relay counters in uplinks and downlinks How did you verify/test it? Run test case Signed-off-by: Aharon Malkin <[email protected]>

…c-net#18796) What is the motivation for this PR? Currently, we only have syslog based test case for DHCP relay counter. This improvement adds the DHCPv4 relay per-interface counter test. How did you do it? Check the DHCP relay counters in uplinks and downlinks How did you verify/test it? Run test case Signed-off-by: Guy Shemesh <[email protected]>

…c-net#18796) What is the motivation for this PR? Currently, we only have syslog based test case for DHCP relay counter. This improvement adds the DHCPv4 relay per-interface counter test. How did you do it? Check the DHCP relay counters in uplinks and downlinks How did you verify/test it? Run test case

…c-net#18796) What is the motivation for this PR? Currently, we only have syslog based test case for DHCP relay counter. This improvement adds the DHCPv4 relay per-interface counter test. How did you do it? Check the DHCP relay counters in uplinks and downlinks How did you verify/test it? Run test case Signed-off-by: Guy Shemesh <[email protected]>

…c-net#18796) What is the motivation for this PR? Currently, we only have syslog based test case for DHCP relay counter. This improvement adds the DHCPv4 relay per-interface counter test. How did you do it? Check the DHCP relay counters in uplinks and downlinks How did you verify/test it? Run test case Signed-off-by: Yael Tzur <[email protected]>

…c-net#18796) What is the motivation for this PR? Currently, we only have syslog based test case for DHCP relay counter. This improvement adds the DHCPv4 relay per-interface counter test. How did you do it? Check the DHCP relay counters in uplinks and downlinks How did you verify/test it? Run test case

zypgithub force-pushed the yanpeng/test branch from 0e33215 to 5bd6226 Compare June 5, 2025 02:36

zypgithub force-pushed the yanpeng/test branch from 5bd6226 to ab4c338 Compare June 5, 2025 02:42

zypgithub force-pushed the yanpeng/test branch from ab4c338 to d714c04 Compare June 5, 2025 02:50

update

2f5c8ef

zypgithub force-pushed the yanpeng/test branch from d714c04 to 2f5c8ef Compare June 5, 2025 05:08

fix

1db66a7

yaqiangz reviewed Jun 6, 2025

View reviewed changes

tests/dhcp_relay/test_dhcp_relay.py Outdated Show resolved Hide resolved

yaqiangz added the Request for 202505 branch label Jun 6, 2025

update

65ada8a

zypgithub changed the title ~~Modify existing dhcp_relay test case to compare dhcp counts~~ [dhcp_relay] Verify per-interface counter in test_dhcp_relay.py Jun 6, 2025

update

b855521

update

e47c98e

update

982a4af

yaqiangz approved these changes Jun 11, 2025

View reviewed changes

update

529ec8c

yaqiangz approved these changes Jun 24, 2025

View reviewed changes

Blueve approved these changes Jun 24, 2025

View reviewed changes

Blueve merged commit e98cd0e into sonic-net:master Jun 24, 2025
14 checks passed

yejianquan added the Approved for 202505 branch label Jun 25, 2025

mssonicbld added the Created PR to 202505 branch label Jun 25, 2025

mssonicbld mentioned this pull request Jun 25, 2025

[action] [PR:18796] [dhcp_relay] Verify per-interface counter in test_dhcp_relay.py #19182

Merged

10 tasks

mssonicbld added Included in 202505 branch and removed Created PR to 202505 branch labels Jun 25, 2025

Conversation

zypgithub commented Jun 4, 2025 • edited by Blueve Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description of PR

Type of change

Back port request

Approach

What is the motivation for this PR?

How did you do it?

How did you verify/test it?

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

Uh oh!

linux-foundation-easycla bot commented Jun 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mssonicbld commented Jun 5, 2025

Uh oh!

azure-pipelines bot commented Jun 5, 2025

Uh oh!

mssonicbld commented Jun 5, 2025

Uh oh!

azure-pipelines bot commented Jun 5, 2025

Uh oh!

mssonicbld commented Jun 5, 2025

Uh oh!

azure-pipelines bot commented Jun 5, 2025

Uh oh!

zypgithub commented Jun 5, 2025

Uh oh!

mssonicbld commented Jun 5, 2025

Uh oh!

azure-pipelines bot commented Jun 5, 2025

Uh oh!

mssonicbld commented Jun 5, 2025

Uh oh!

azure-pipelines bot commented Jun 5, 2025

Uh oh!

Uh oh!

yaqiangz Jun 6, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mssonicbld commented Jun 6, 2025

Uh oh!

azure-pipelines bot commented Jun 6, 2025

Uh oh!

mssonicbld commented Jun 6, 2025

Uh oh!

azure-pipelines bot commented Jun 6, 2025

Uh oh!

mssonicbld commented Jun 9, 2025

Uh oh!

azure-pipelines bot commented Jun 9, 2025

Uh oh!

mssonicbld commented Jun 10, 2025

Uh oh!

azure-pipelines bot commented Jun 10, 2025

Uh oh!

yaqiangz left a comment

Choose a reason for hiding this comment

Uh oh!

mssonicbld commented Jun 13, 2025

Uh oh!

azure-pipelines bot commented Jun 13, 2025

Uh oh!

Uh oh!

mssonicbld commented Jun 25, 2025

Uh oh!

Reviewers

Assignees

zypgithub commented Jun 4, 2025 •

edited by Blueve

Loading

linux-foundation-easycla bot commented Jun 4, 2025 •

edited

Loading