Skip to content

[action] [PR:18733] [CRM AVAILABLE] To enhance the crm tests for TD3 and Cisco devices#18761

Merged
mssonicbld merged 1 commit intosonic-net:202505from
mssonicbld:cherry/202505/18733
Jun 4, 2025
Merged

[action] [PR:18733] [CRM AVAILABLE] To enhance the crm tests for TD3 and Cisco devices#18761
mssonicbld merged 1 commit intosonic-net:202505from
mssonicbld:cherry/202505/18733

Conversation

@mssonicbld
Copy link
Copy Markdown
Collaborator

Description of PR

Summary:
Fixes # (issue)
For TD3, the maximum number of nexthop groups is 255, which is below the minimum requirement of 256, resulting in test failures. To address this, TD3 should be added to SKU_NEXTHOP_THRESHOLDS.

Additionally, some HWSKUs require more time for the crm command to become operational. To accommodate this, the wait time has been increased from 90 seconds to 360 seconds in worst case.

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • New Test case
  • Skipped for non-supported platforms
  • Test case improvement

Back port request

  • 202205
  • 202305
  • 202311
  • 202405
  • 202411
  • 202505

Approach

What is the motivation for this PR?

To fix the flaky failure on Cisco devices and the consistent failure on TD3

How did you do it?

  1. For TD3, add 255 as a threshold.
  2. Extend maximum wait time from 90 seconds to 360 seconds.

How did you verify/test it?

  1. Run test on TD3 and Cisco devices.

Any platform specific information?

N/A

Supported testbed topology if it's a new test case?

N/A

Documentation

…onic-net#18733)

For TD3, the maximum number of nexthop groups is 255, which is below the minimum requirement of 256, resulting in test failures. To address this, TD3 should be added to SKU_NEXTHOP_THRESHOLDS.

Additionally, some HWSKUs require more time for the crm command to become operational. To accommodate this, the wait time has been increased from 90 seconds to 360 seconds in worst case.

What is the motivation for this PR?
To fix the flaky failure on Cisco devices and the consistent failure on TD3

How did you do it?
For TD3, add 255 as a threshold.
Extend maximum wait time from 90 seconds to 360 seconds.

How did you verify/test it?
Run test on TD3 and Cisco devices.
@mssonicbld
Copy link
Copy Markdown
Collaborator Author

Original PR: #18733

@yejianquan
Copy link
Copy Markdown
Collaborator

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld mssonicbld merged commit 68ad5fc into sonic-net:202505 Jun 4, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants