[topo file] Fix pt0 announce routes in bgp scale topologies#18686
Merged
Blueve merged 3 commits intosonic-net:masterfrom May 30, 2025
Merged
[topo file] Fix pt0 announce routes in bgp scale topologies#18686Blueve merged 3 commits intosonic-net:masterfrom
Blueve merged 3 commits intosonic-net:masterfrom
Conversation
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Blueve
approved these changes
May 30, 2025
Collaborator
|
Cherry-pick PR to msft-202412: Azure/sonic-mgmt.msft#345 |
bachalla
pushed a commit
to bachalla/sonic-mgmt
that referenced
this pull request
Jun 2, 2025
…t#18686) What is the motivation for this PR? In bgp scale test, pt0 should announce vlan routes How did you do it? this PR mark pt0 as role tor, and it won't generate routes How did you verify/test it? Run ansible script to announce routes on testbed
congh-nvidia
reviewed
Jun 6, 2025
| @@ -10759,6 +11272,7 @@ configuration: | |||
| ARISTA01PT0: | |||
| properties: | |||
| - common | |||
| - tor | |||
Contributor
There was a problem hiding this comment.
Hi @w1nda , you added the role "tor" for the 2 service port VMs, but we don't yet have the t0-isolated-d2u510s2-tor.j2 template. Looks like we need to add one? Now these 2 VMs are not created in add_topo.
Collaborator
|
@w1nda PR conflicts with 202405 branch |
11 tasks
r12f
added
Included in msft-202412 Branch
and removed
Created PR to msft-202412 Branch
labels
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Jun 16, 2025
…logy (sonic-net#18976) What is the motivation for this PR? In PR sonic-net#18686, we set pt0 as role tor, however, there is no ceos template for it How did you do it? create the ceos templates for PT0
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Jun 23, 2025
…t#18686) What is the motivation for this PR? In bgp scale test, pt0 should announce vlan routes How did you do it? this PR mark pt0 as role tor, and it won't generate routes How did you verify/test it? Run ansible script to announce routes on testbed
Collaborator
|
Cherry-pick PR to 202505: #19132 |
11 tasks
mssonicbld
pushed a commit
that referenced
this pull request
Jun 23, 2025
What is the motivation for this PR? In bgp scale test, pt0 should announce vlan routes How did you do it? this PR mark pt0 as role tor, and it won't generate routes How did you verify/test it? Run ansible script to announce routes on testbed
mssonicbld
added
Included in 202505 branch
and removed
Created PR to 202505 branch
labels
sdszhang
pushed a commit
to sdszhang/sonic-mgmt
that referenced
this pull request
Jun 30, 2025
…PT0 in isolated topology (sonic-net#409) <!-- Please make sure you've read and understood our contributing guidelines; https://github.com/sonic-net/SONiC/blob/gh-pages/CONTRIBUTING.md Please provide following information to help code review process a bit easier: --> ### Description of PR <!-- - Please include a summary of the change and which issue is fixed. - Please also include relevant motivation and context. Where should reviewer start? background context? - List any dependencies that are required for this change. --> Summary: Fixes # (issue) In PR sonic-net#18686, we set pt0 as role tor, however, there is no ceos template for it, we need to create the ceos template for tor. ### Type of change <!-- - Fill x for your type of change. - e.g. - [x] Bug fix --> - [x] Bug fix - [ ] Testbed and Framework(new/improvement) - [ ] New Test case - [ ] Skipped for non-supported platforms - [ ] Test case improvement ### Back port request - [ ] 202205 - [ ] 202305 - [ ] 202311 - [ ] 202405 - [ ] 202411 - [x] 202505 ### Approach #### What is the motivation for this PR? In PR sonic-net#18686, we set pt0 as role tor, however, there is no ceos template for it #### How did you do it? create the ceos templates for PT0 #### How did you verify/test it? #### Any platform specific information? #### Supported testbed topology if it's a new test case? ### Documentation <!-- (If it's a new feature, new test case) Did you update documentation/Wiki relevant to your implementation? Link to the wiki page? -->
nissampa
pushed a commit
to nissampa/sonic-mgmt_dpu_test
that referenced
this pull request
Aug 7, 2025
…logy (sonic-net#18976) What is the motivation for this PR? In PR sonic-net#18686, we set pt0 as role tor, however, there is no ceos template for it How did you do it? create the ceos templates for PT0
opcoder0
pushed a commit
to opcoder0/sonic-mgmt
that referenced
this pull request
Dec 8, 2025
…t#18686) What is the motivation for this PR? In bgp scale test, pt0 should announce vlan routes How did you do it? this PR mark pt0 as role tor, and it won't generate routes How did you verify/test it? Run ansible script to announce routes on testbed Signed-off-by: opcoder0 <[email protected]>
opcoder0
pushed a commit
to opcoder0/sonic-mgmt
that referenced
this pull request
Dec 8, 2025
…logy (sonic-net#18976) What is the motivation for this PR? In PR sonic-net#18686, we set pt0 as role tor, however, there is no ceos template for it How did you do it? create the ceos templates for PT0 Signed-off-by: opcoder0 <[email protected]>
gshemesh2
pushed a commit
to gshemesh2/sonic-mgmt
that referenced
this pull request
Dec 16, 2025
…logy (sonic-net#18976) What is the motivation for this PR? In PR sonic-net#18686, we set pt0 as role tor, however, there is no ceos template for it How did you do it? create the ceos templates for PT0 Signed-off-by: Guy Shemesh <[email protected]>
AharonMalkin
pushed a commit
to AharonMalkin/sonic-mgmt
that referenced
this pull request
Dec 16, 2025
…t#18686) What is the motivation for this PR? In bgp scale test, pt0 should announce vlan routes How did you do it? this PR mark pt0 as role tor, and it won't generate routes How did you verify/test it? Run ansible script to announce routes on testbed Signed-off-by: Aharon Malkin <[email protected]>
AharonMalkin
pushed a commit
to AharonMalkin/sonic-mgmt
that referenced
this pull request
Dec 16, 2025
…logy (sonic-net#18976) What is the motivation for this PR? In PR sonic-net#18686, we set pt0 as role tor, however, there is no ceos template for it How did you do it? create the ceos templates for PT0 Signed-off-by: Aharon Malkin <[email protected]>
gshemesh2
pushed a commit
to gshemesh2/sonic-mgmt
that referenced
this pull request
Dec 21, 2025
…t#18686) What is the motivation for this PR? In bgp scale test, pt0 should announce vlan routes How did you do it? this PR mark pt0 as role tor, and it won't generate routes How did you verify/test it? Run ansible script to announce routes on testbed Signed-off-by: Guy Shemesh <[email protected]>
gshemesh2
pushed a commit
to gshemesh2/sonic-mgmt
that referenced
this pull request
Dec 21, 2025
…logy (sonic-net#18976) What is the motivation for this PR? In PR sonic-net#18686, we set pt0 as role tor, however, there is no ceos template for it How did you do it? create the ceos templates for PT0 Signed-off-by: Guy Shemesh <[email protected]>
venu-nexthop
pushed a commit
to venu-nexthop/sonic-mgmt
that referenced
this pull request
Jan 13, 2026
…t#18686) What is the motivation for this PR? In bgp scale test, pt0 should announce vlan routes How did you do it? this PR mark pt0 as role tor, and it won't generate routes How did you verify/test it? Run ansible script to announce routes on testbed
venu-nexthop
pushed a commit
to venu-nexthop/sonic-mgmt
that referenced
this pull request
Jan 13, 2026
…logy (sonic-net#18976) What is the motivation for this PR? In PR sonic-net#18686, we set pt0 as role tor, however, there is no ceos template for it How did you do it? create the ceos templates for PT0
gshemesh2
pushed a commit
to gshemesh2/sonic-mgmt
that referenced
this pull request
Jan 26, 2026
…t#18686) What is the motivation for this PR? In bgp scale test, pt0 should announce vlan routes How did you do it? this PR mark pt0 as role tor, and it won't generate routes How did you verify/test it? Run ansible script to announce routes on testbed Signed-off-by: Guy Shemesh <[email protected]>
gshemesh2
pushed a commit
to gshemesh2/sonic-mgmt
that referenced
this pull request
Jan 26, 2026
…logy (sonic-net#18976) What is the motivation for this PR? In PR sonic-net#18686, we set pt0 as role tor, however, there is no ceos template for it How did you do it? create the ceos templates for PT0 Signed-off-by: Guy Shemesh <[email protected]>
ytzur1
pushed a commit
to ytzur1/sonic-mgmt
that referenced
this pull request
Feb 2, 2026
…logy (sonic-net#18976) What is the motivation for this PR? In PR sonic-net#18686, we set pt0 as role tor, however, there is no ceos template for it How did you do it? create the ceos templates for PT0 Signed-off-by: Yael Tzur <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes # (issue)
In bgp scale test, pt0 should announce vlan routes, so this PR mark pt0 as role tor, and it won't generate routes.
Type of change
Back port request
Approach
What is the motivation for this PR?
In bgp scale test, pt0 should announce vlan routes
How did you do it?
this PR mark pt0 as role tor, and it won't generate routes
How did you verify/test it?
Run ansible script to announce routes on testbed
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation