update test_pfc_pause_lossless_with_snappi.py to use dynamic port selection by sdszhang · Pull Request #18673 · sonic-net/sonic-mgmt

sdszhang · 2025-05-28T10:13:42Z

Description of PR

Summary:
Fixes # (issue)

Type of change

After #16729 and #15069, existing test cases need to be updated to support dynamic port selection.

Back port request

Approach

What is the motivation for this PR?

Update test case to adopt the new feature

How did you do it?

How did you verify/test it?

snappi_tests/pfc/test_pfc_pause_lossless_with_snappi.py::test_pfc_pause_single_lossless_prio[str3-8800-lc4-1|3-tgen_port_info0]
snappi_tests/pfc/test_pfc_pause_lossless_with_snappi.py::test_pfc_pause_single_lossless_prio[str3-8800-lc4-1|3-tgen_port_info1] PASSED [ 50%]
snappi_tests/pfc/test_pfc_pause_lossless_with_snappi.py::test_pfc_pause_single_lossless_prio[str3-8800-lc4-1|4-tgen_port_info0] PASSED [ 75%]
snappi_tests/pfc/test_pfc_pause_lossless_with_snappi.py::test_pfc_pause_single_lossless_prio[str3-8800-lc4-1|4-tgen_port_info1] PASSED [100%]
------------------------------ live log teardown -------------------------------

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

mssonicbld · 2025-05-28T10:13:50Z

/azp run

azure-pipelines · 2025-05-28T10:14:04Z

Azure Pipelines successfully started running 1 pipeline(s).

mssonicbld · 2025-05-28T11:23:23Z

/azp run

azure-pipelines · 2025-05-28T11:23:35Z

Azure Pipelines successfully started running 1 pipeline(s).

sdszhang · 2025-05-28T11:25:00Z

@auspham @amitpawar12 can you review?

amitpawar12 · 2025-06-01T21:58:16Z

@sdszhang - It will be good if we can have logs for following:

Single DUT, dynamic and static ports.
Multi DUT, dynamic and static ports.

That way, it is ensured that it is not breaking any combination.

Thanks,
-A

sdszhang · 2025-06-04T07:47:35Z

@sdszhang - It will be good if we can have logs for following:

Single DUT, dynamic and static ports.

Multi DUT, dynamic and static ports.

That way, it is ensured that it is not breaking any combination.

Thanks, -A

Right now, current test case having issue support T1-tgen testbed. There is a PR #18793 to disable it first, then working on it separately to avoid blocking T1-tgen testing.

yejianquan

LGTM

Description of PR Summary: Fixes # (issue) Type of change After sonic-net#16729 and sonic-net#15069, existing test cases need to be updated to support dynamic port selection. Bug fix Testbed and Framework(new/improvement) New Test case Skipped for non-supported platforms Test case improvement Back port request 202205 202305 202311 202405 202411 202505 Approach What is the motivation for this PR? Update test case to adopt the new feature How did you do it? How did you verify/test it? snappi_tests/pfc/test_pfc_pause_lossless_with_snappi.py::test_pfc_pause_single_lossless_prio[str3-8800-lc4-1|3-tgen_port_info0] snappi_tests/pfc/test_pfc_pause_lossless_with_snappi.py::test_pfc_pause_single_lossless_prio[str3-8800-lc4-1|3-tgen_port_info1] PASSED [ 50%] snappi_tests/pfc/test_pfc_pause_lossless_with_snappi.py::test_pfc_pause_single_lossless_prio[str3-8800-lc4-1|4-tgen_port_info0] PASSED [ 75%] snappi_tests/pfc/test_pfc_pause_lossless_with_snappi.py::test_pfc_pause_single_lossless_prio[str3-8800-lc4-1|4-tgen_port_info1] PASSED [100%] ------------------------------ live log teardown -------------------------------

mssonicbld · 2025-06-05T04:44:50Z

Cherry-pick PR to 202505: #18814

Description of PR Summary: Fixes # (issue) Type of change After #16729 and #15069, existing test cases need to be updated to support dynamic port selection. Bug fix Testbed and Framework(new/improvement) New Test case Skipped for non-supported platforms Test case improvement Back port request 202205 202305 202311 202405 202411 202505 Approach What is the motivation for this PR? Update test case to adopt the new feature How did you do it? How did you verify/test it? snappi_tests/pfc/test_pfc_pause_lossless_with_snappi.py::test_pfc_pause_single_lossless_prio[str3-8800-lc4-1|3-tgen_port_info0] snappi_tests/pfc/test_pfc_pause_lossless_with_snappi.py::test_pfc_pause_single_lossless_prio[str3-8800-lc4-1|3-tgen_port_info1] PASSED [ 50%] snappi_tests/pfc/test_pfc_pause_lossless_with_snappi.py::test_pfc_pause_single_lossless_prio[str3-8800-lc4-1|4-tgen_port_info0] PASSED [ 75%] snappi_tests/pfc/test_pfc_pause_lossless_with_snappi.py::test_pfc_pause_single_lossless_prio[str3-8800-lc4-1|4-tgen_port_info1] PASSED [100%] ------------------------------ live log teardown -------------------------------

Description of PR Summary: Fixes # (issue) Type of change After sonic-net#16729 and sonic-net#15069, existing test cases need to be updated to support dynamic port selection. Bug fix Testbed and Framework(new/improvement) New Test case Skipped for non-supported platforms Test case improvement Back port request 202205 202305 202311 202405 202411 202505 Approach What is the motivation for this PR? Update test case to adopt the new feature How did you do it? How did you verify/test it? snappi_tests/pfc/test_pfc_pause_lossless_with_snappi.py::test_pfc_pause_single_lossless_prio[str3-8800-lc4-1|3-tgen_port_info0] snappi_tests/pfc/test_pfc_pause_lossless_with_snappi.py::test_pfc_pause_single_lossless_prio[str3-8800-lc4-1|3-tgen_port_info1] PASSED [ 50%] snappi_tests/pfc/test_pfc_pause_lossless_with_snappi.py::test_pfc_pause_single_lossless_prio[str3-8800-lc4-1|4-tgen_port_info0] PASSED [ 75%] snappi_tests/pfc/test_pfc_pause_lossless_with_snappi.py::test_pfc_pause_single_lossless_prio[str3-8800-lc4-1|4-tgen_port_info1] PASSED [100%] ------------------------------ live log teardown ------------------------------- Signed-off-by: opcoder0 <[email protected]>

Description of PR Summary: Fixes # (issue) Type of change After sonic-net#16729 and sonic-net#15069, existing test cases need to be updated to support dynamic port selection. Bug fix Testbed and Framework(new/improvement) New Test case Skipped for non-supported platforms Test case improvement Back port request 202205 202305 202311 202405 202411 202505 Approach What is the motivation for this PR? Update test case to adopt the new feature How did you do it? How did you verify/test it? snappi_tests/pfc/test_pfc_pause_lossless_with_snappi.py::test_pfc_pause_single_lossless_prio[str3-8800-lc4-1|3-tgen_port_info0] snappi_tests/pfc/test_pfc_pause_lossless_with_snappi.py::test_pfc_pause_single_lossless_prio[str3-8800-lc4-1|3-tgen_port_info1] PASSED [ 50%] snappi_tests/pfc/test_pfc_pause_lossless_with_snappi.py::test_pfc_pause_single_lossless_prio[str3-8800-lc4-1|4-tgen_port_info0] PASSED [ 75%] snappi_tests/pfc/test_pfc_pause_lossless_with_snappi.py::test_pfc_pause_single_lossless_prio[str3-8800-lc4-1|4-tgen_port_info1] PASSED [100%] ------------------------------ live log teardown ------------------------------- Signed-off-by: Aharon Malkin <[email protected]>

Description of PR Summary: Fixes # (issue) Type of change After sonic-net#16729 and sonic-net#15069, existing test cases need to be updated to support dynamic port selection. Bug fix Testbed and Framework(new/improvement) New Test case Skipped for non-supported platforms Test case improvement Back port request 202205 202305 202311 202405 202411 202505 Approach What is the motivation for this PR? Update test case to adopt the new feature How did you do it? How did you verify/test it? snappi_tests/pfc/test_pfc_pause_lossless_with_snappi.py::test_pfc_pause_single_lossless_prio[str3-8800-lc4-1|3-tgen_port_info0] snappi_tests/pfc/test_pfc_pause_lossless_with_snappi.py::test_pfc_pause_single_lossless_prio[str3-8800-lc4-1|3-tgen_port_info1] PASSED [ 50%] snappi_tests/pfc/test_pfc_pause_lossless_with_snappi.py::test_pfc_pause_single_lossless_prio[str3-8800-lc4-1|4-tgen_port_info0] PASSED [ 75%] snappi_tests/pfc/test_pfc_pause_lossless_with_snappi.py::test_pfc_pause_single_lossless_prio[str3-8800-lc4-1|4-tgen_port_info1] PASSED [100%] ------------------------------ live log teardown ------------------------------- Signed-off-by: Guy Shemesh <[email protected]>

Description of PR Summary: Fixes # (issue) Type of change After sonic-net#16729 and sonic-net#15069, existing test cases need to be updated to support dynamic port selection. Bug fix Testbed and Framework(new/improvement) New Test case Skipped for non-supported platforms Test case improvement Back port request 202205 202305 202311 202405 202411 202505 Approach What is the motivation for this PR? Update test case to adopt the new feature How did you do it? How did you verify/test it? snappi_tests/pfc/test_pfc_pause_lossless_with_snappi.py::test_pfc_pause_single_lossless_prio[str3-8800-lc4-1|3-tgen_port_info0] snappi_tests/pfc/test_pfc_pause_lossless_with_snappi.py::test_pfc_pause_single_lossless_prio[str3-8800-lc4-1|3-tgen_port_info1] PASSED [ 50%] snappi_tests/pfc/test_pfc_pause_lossless_with_snappi.py::test_pfc_pause_single_lossless_prio[str3-8800-lc4-1|4-tgen_port_info0] PASSED [ 75%] snappi_tests/pfc/test_pfc_pause_lossless_with_snappi.py::test_pfc_pause_single_lossless_prio[str3-8800-lc4-1|4-tgen_port_info1] PASSED [100%] ------------------------------ live log teardown -------------------------------

Description of PR Summary: Fixes # (issue) Type of change After sonic-net#16729 and sonic-net#15069, existing test cases need to be updated to support dynamic port selection. Bug fix Testbed and Framework(new/improvement) New Test case Skipped for non-supported platforms Test case improvement Back port request 202205 202305 202311 202405 202411 202505 Approach What is the motivation for this PR? Update test case to adopt the new feature How did you do it? How did you verify/test it? snappi_tests/pfc/test_pfc_pause_lossless_with_snappi.py::test_pfc_pause_single_lossless_prio[str3-8800-lc4-1|3-tgen_port_info0] snappi_tests/pfc/test_pfc_pause_lossless_with_snappi.py::test_pfc_pause_single_lossless_prio[str3-8800-lc4-1|3-tgen_port_info1] PASSED [ 50%] snappi_tests/pfc/test_pfc_pause_lossless_with_snappi.py::test_pfc_pause_single_lossless_prio[str3-8800-lc4-1|4-tgen_port_info0] PASSED [ 75%] snappi_tests/pfc/test_pfc_pause_lossless_with_snappi.py::test_pfc_pause_single_lossless_prio[str3-8800-lc4-1|4-tgen_port_info1] PASSED [100%] ------------------------------ live log teardown ------------------------------- Signed-off-by: Guy Shemesh <[email protected]>

Description of PR Summary: Fixes # (issue) Type of change After sonic-net#16729 and sonic-net#15069, existing test cases need to be updated to support dynamic port selection. Bug fix Testbed and Framework(new/improvement) New Test case Skipped for non-supported platforms Test case improvement Back port request 202205 202305 202311 202405 202411 202505 Approach What is the motivation for this PR? Update test case to adopt the new feature How did you do it? How did you verify/test it? snappi_tests/pfc/test_pfc_pause_lossless_with_snappi.py::test_pfc_pause_single_lossless_prio[str3-8800-lc4-1|3-tgen_port_info0] snappi_tests/pfc/test_pfc_pause_lossless_with_snappi.py::test_pfc_pause_single_lossless_prio[str3-8800-lc4-1|3-tgen_port_info1] PASSED [ 50%] snappi_tests/pfc/test_pfc_pause_lossless_with_snappi.py::test_pfc_pause_single_lossless_prio[str3-8800-lc4-1|4-tgen_port_info0] PASSED [ 75%] snappi_tests/pfc/test_pfc_pause_lossless_with_snappi.py::test_pfc_pause_single_lossless_prio[str3-8800-lc4-1|4-tgen_port_info1] PASSED [100%] ------------------------------ live log teardown ------------------------------- Signed-off-by: Yael Tzur <[email protected]>

Description of PR Summary: Fixes # (issue) Type of change After sonic-net#16729 and sonic-net#15069, existing test cases need to be updated to support dynamic port selection. Bug fix Testbed and Framework(new/improvement) New Test case Skipped for non-supported platforms Test case improvement Back port request 202205 202305 202311 202405 202411 202505 Approach What is the motivation for this PR? Update test case to adopt the new feature How did you do it? How did you verify/test it? snappi_tests/pfc/test_pfc_pause_lossless_with_snappi.py::test_pfc_pause_single_lossless_prio[str3-8800-lc4-1|3-tgen_port_info0] snappi_tests/pfc/test_pfc_pause_lossless_with_snappi.py::test_pfc_pause_single_lossless_prio[str3-8800-lc4-1|3-tgen_port_info1] PASSED [ 50%] snappi_tests/pfc/test_pfc_pause_lossless_with_snappi.py::test_pfc_pause_single_lossless_prio[str3-8800-lc4-1|4-tgen_port_info0] PASSED [ 75%] snappi_tests/pfc/test_pfc_pause_lossless_with_snappi.py::test_pfc_pause_single_lossless_prio[str3-8800-lc4-1|4-tgen_port_info1] PASSED [100%] ------------------------------ live log teardown -------------------------------

change to dynamic port info.

66646bf

sdszhang force-pushed the ixia_dynamic_port branch from 2d79b9e to 66646bf Compare May 28, 2025 11:23

sdszhang added this to SONiC Snappi May 28, 2025

sdszhang moved this to In Progress in SONiC Snappi May 28, 2025

auspham approved these changes May 28, 2025

View reviewed changes

sdszhang moved this from In Progress to To be Merged in SONiC Snappi May 29, 2025

Janetxxx approved these changes Jun 3, 2025

View reviewed changes

sdszhang added the Request for 202505 branch label Jun 4, 2025

yejianquan approved these changes Jun 5, 2025

View reviewed changes

yejianquan merged commit 014cfc9 into sonic-net:master Jun 5, 2025
11 checks passed

github-project-automation bot moved this from To be Merged to Done in SONiC Snappi Jun 5, 2025

yejianquan added the Approved for 202505 branch label Jun 5, 2025

mssonicbld added the Created PR to 202505 branch label Jun 5, 2025

mssonicbld mentioned this pull request Jun 5, 2025

[action] [PR:18673] update test_pfc_pause_lossless_with_snappi.py to use dynamic port selection #18814

Merged

11 tasks

mssonicbld added Included in 202505 branch and removed Created PR to 202505 branch labels Jun 5, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

update test_pfc_pause_lossless_with_snappi.py to use dynamic port selection#18673

update test_pfc_pause_lossless_with_snappi.py to use dynamic port selection#18673
yejianquan merged 1 commit intosonic-net:masterfrom
sdszhang:ixia_dynamic_port

sdszhang commented May 28, 2025 •

edited

Loading

Uh oh!

mssonicbld commented May 28, 2025

Uh oh!

azure-pipelines bot commented May 28, 2025

Uh oh!

mssonicbld commented May 28, 2025

Uh oh!

azure-pipelines bot commented May 28, 2025

Uh oh!

sdszhang commented May 28, 2025

Uh oh!

amitpawar12 commented Jun 1, 2025

Uh oh!

sdszhang commented Jun 4, 2025 •

edited

Loading

Uh oh!

yejianquan left a comment

Uh oh!

Uh oh!

mssonicbld commented Jun 5, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Conversation

sdszhang commented May 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description of PR

Type of change

Back port request

Approach

What is the motivation for this PR?

How did you do it?

How did you verify/test it?

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

Uh oh!

mssonicbld commented May 28, 2025

Uh oh!

azure-pipelines bot commented May 28, 2025

Uh oh!

mssonicbld commented May 28, 2025

Uh oh!

azure-pipelines bot commented May 28, 2025

Uh oh!

sdszhang commented May 28, 2025

Uh oh!

amitpawar12 commented Jun 1, 2025

Uh oh!

sdszhang commented Jun 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

yejianquan left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

mssonicbld commented Jun 5, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

sdszhang commented May 28, 2025 •

edited

Loading

sdszhang commented Jun 4, 2025 •

edited

Loading