Update cEOS configuration to use next-hop-self#18659
Merged
wangxin merged 1 commit intosonic-net:masterfrom Jun 1, 2025
Merged
Update cEOS configuration to use next-hop-self#18659wangxin merged 1 commit intosonic-net:masterfrom
wangxin merged 1 commit intosonic-net:masterfrom
Conversation
The upgraded cEOS instance also changes from single-agent to multi-agent mode. This includes a behaviour change around the next-hop-self feature. Fixes: BUG872880
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
yxieca
reviewed
May 28, 2025
| {% for remote_ip in remote_ips %} | ||
| neighbor {{ remote_ip }} remote-as {{ asn }} | ||
| neighbor {{ remote_ip }} description {{ asn }} | ||
| neighbor {{ remote_ip }} next-hop-self |
Collaborator
There was a problem hiding this comment.
Is this configuration safe for older cEOS containers?
Contributor
Author
There was a problem hiding this comment.
Correct. This configuration has been accepted in EOS in versions older than what's available to download. In those older versions, that configuration is basically explicitly stating to use the default behaviour.
wangxin
approved these changes
Jun 1, 2025
bachalla
pushed a commit
to bachalla/sonic-mgmt
that referenced
this pull request
Jun 2, 2025
The upgraded cEOS instance also changes from single-agent to multi-agent mode. This includes a behaviour change around the next-hop-self feature. Fixes: BUG872880 What is the motivation for this PR? Fixing a bug introduced by using a newer version of cEOS for testing. While the current documentation doesn't specify a newer version of cEOS, it would be good to have this fix in place before people start using a newer version of cEOS. How did you do it? Adjust the cEOS configuration templates to force cEOS to rewrite the next-hop as itself How did you verify/test it? Normal sonic-mgmt test run Any platform specific information? Not platform-dependent. Supported testbed topology if it's a new test case? All
Collaborator
|
hi @AKosturArista , do you mind to help manual pick this change to 202412? |
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Jun 19, 2025
The upgraded cEOS instance also changes from single-agent to multi-agent mode. This includes a behaviour change around the next-hop-self feature. Fixes: BUG872880 What is the motivation for this PR? Fixing a bug introduced by using a newer version of cEOS for testing. While the current documentation doesn't specify a newer version of cEOS, it would be good to have this fix in place before people start using a newer version of cEOS. How did you do it? Adjust the cEOS configuration templates to force cEOS to rewrite the next-hop as itself How did you verify/test it? Normal sonic-mgmt test run Any platform specific information? Not platform-dependent. Supported testbed topology if it's a new test case? All
Collaborator
|
Cherry-pick PR to 202505: #19086 |
11 tasks
mssonicbld
pushed a commit
that referenced
this pull request
Jun 19, 2025
The upgraded cEOS instance also changes from single-agent to multi-agent mode. This includes a behaviour change around the next-hop-self feature. Fixes: BUG872880 What is the motivation for this PR? Fixing a bug introduced by using a newer version of cEOS for testing. While the current documentation doesn't specify a newer version of cEOS, it would be good to have this fix in place before people start using a newer version of cEOS. How did you do it? Adjust the cEOS configuration templates to force cEOS to rewrite the next-hop as itself How did you verify/test it? Normal sonic-mgmt test run Any platform specific information? Not platform-dependent. Supported testbed topology if it's a new test case? All
mssonicbld
added
Included in 202505 branch
and removed
Created PR to 202505 branch
labels
Collaborator
|
hi @AKosturArista , do you mind to help manual pick this change to 202412? |
Contributor
Author
|
Is this Azure/sonic-mgmt.msft#432 sufficient? |
matthew-soulsby
pushed a commit
to matthew-soulsby/sonic-mgmt
that referenced
this pull request
Jul 1, 2025
The upgraded cEOS instance also changes from single-agent to multi-agent mode. This includes a behaviour change around the next-hop-self feature. Fixes: BUG872880 What is the motivation for this PR? Fixing a bug introduced by using a newer version of cEOS for testing. While the current documentation doesn't specify a newer version of cEOS, it would be good to have this fix in place before people start using a newer version of cEOS. How did you do it? Adjust the cEOS configuration templates to force cEOS to rewrite the next-hop as itself How did you verify/test it? Normal sonic-mgmt test run Any platform specific information? Not platform-dependent. Supported testbed topology if it's a new test case? All
matthew-soulsby
pushed a commit
to matthew-soulsby/sonic-mgmt
that referenced
this pull request
Jul 1, 2025
…et#18659) (sonic-net#465) The upgraded cEOS instance also changes from single-agent to multi-agent mode. This includes a behaviour change around the next-hop-self feature. Fixes: BUG872880 What is the motivation for this PR? Fixing a bug introduced by using a newer version of cEOS for testing. While the current documentation doesn't specify a newer version of cEOS, it would be good to have this fix in place before people start using a newer version of cEOS. How did you do it? Adjust the cEOS configuration templates to force cEOS to rewrite the next-hop as itself How did you verify/test it? Normal sonic-mgmt test run Any platform specific information? Not platform-dependent. Supported testbed topology if it's a new test case? All
r12f
added
Approved for msft-202412 Branch
Included in msft-202412 Branch
and removed
Cherry Pick Conflict_msft-202412
labels
sdszhang
pushed a commit
to sdszhang/sonic-mgmt
that referenced
this pull request
Aug 2, 2025
The upgraded cEOS instance also changes from single-agent to multi-agent mode. This includes a behaviour change around the next-hop-self feature. This is a port of the corresponding patch from PR sonic-net#18659 from the main sonic-mgmt repo.
opcoder0
pushed a commit
to opcoder0/sonic-mgmt
that referenced
this pull request
Dec 8, 2025
The upgraded cEOS instance also changes from single-agent to multi-agent mode. This includes a behaviour change around the next-hop-self feature. Fixes: BUG872880 What is the motivation for this PR? Fixing a bug introduced by using a newer version of cEOS for testing. While the current documentation doesn't specify a newer version of cEOS, it would be good to have this fix in place before people start using a newer version of cEOS. How did you do it? Adjust the cEOS configuration templates to force cEOS to rewrite the next-hop as itself How did you verify/test it? Normal sonic-mgmt test run Any platform specific information? Not platform-dependent. Supported testbed topology if it's a new test case? All Signed-off-by: opcoder0 <110003254+opcoder0@users.noreply.github.com>
AharonMalkin
pushed a commit
to AharonMalkin/sonic-mgmt
that referenced
this pull request
Dec 16, 2025
The upgraded cEOS instance also changes from single-agent to multi-agent mode. This includes a behaviour change around the next-hop-self feature. Fixes: BUG872880 What is the motivation for this PR? Fixing a bug introduced by using a newer version of cEOS for testing. While the current documentation doesn't specify a newer version of cEOS, it would be good to have this fix in place before people start using a newer version of cEOS. How did you do it? Adjust the cEOS configuration templates to force cEOS to rewrite the next-hop as itself How did you verify/test it? Normal sonic-mgmt test run Any platform specific information? Not platform-dependent. Supported testbed topology if it's a new test case? All Signed-off-by: Aharon Malkin <amalkin@nvidia.com>
gshemesh2
pushed a commit
to gshemesh2/sonic-mgmt
that referenced
this pull request
Dec 21, 2025
The upgraded cEOS instance also changes from single-agent to multi-agent mode. This includes a behaviour change around the next-hop-self feature. Fixes: BUG872880 What is the motivation for this PR? Fixing a bug introduced by using a newer version of cEOS for testing. While the current documentation doesn't specify a newer version of cEOS, it would be good to have this fix in place before people start using a newer version of cEOS. How did you do it? Adjust the cEOS configuration templates to force cEOS to rewrite the next-hop as itself How did you verify/test it? Normal sonic-mgmt test run Any platform specific information? Not platform-dependent. Supported testbed topology if it's a new test case? All Signed-off-by: Guy Shemesh <gshemesh@nvidia.com>
venu-nexthop
pushed a commit
to venu-nexthop/sonic-mgmt
that referenced
this pull request
Jan 13, 2026
The upgraded cEOS instance also changes from single-agent to multi-agent mode. This includes a behaviour change around the next-hop-self feature. Fixes: BUG872880 What is the motivation for this PR? Fixing a bug introduced by using a newer version of cEOS for testing. While the current documentation doesn't specify a newer version of cEOS, it would be good to have this fix in place before people start using a newer version of cEOS. How did you do it? Adjust the cEOS configuration templates to force cEOS to rewrite the next-hop as itself How did you verify/test it? Normal sonic-mgmt test run Any platform specific information? Not platform-dependent. Supported testbed topology if it's a new test case? All
gshemesh2
pushed a commit
to gshemesh2/sonic-mgmt
that referenced
this pull request
Jan 26, 2026
The upgraded cEOS instance also changes from single-agent to multi-agent mode. This includes a behaviour change around the next-hop-self feature. Fixes: BUG872880 What is the motivation for this PR? Fixing a bug introduced by using a newer version of cEOS for testing. While the current documentation doesn't specify a newer version of cEOS, it would be good to have this fix in place before people start using a newer version of cEOS. How did you do it? Adjust the cEOS configuration templates to force cEOS to rewrite the next-hop as itself How did you verify/test it? Normal sonic-mgmt test run Any platform specific information? Not platform-dependent. Supported testbed topology if it's a new test case? All Signed-off-by: Guy Shemesh <gshemesh@nvidia.com>
12 tasks
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary: Force the cEOS instances to use their own IP for next-hop
Fixes #18658
Type of change
Back port request
Approach
What is the motivation for this PR?
Fixing a bug introduced by using a newer version of cEOS for testing. While the current documentation doesn't specify a newer version of cEOS, it would be good to have this fix in place before people start using a newer version of cEOS.
How did you do it?
Adjust the cEOS configuration templates to force cEOS to rewrite the next-hop as itself
How did you verify/test it?
Normal sonic-mgmt test run
Any platform specific information?
Not platform-dependent.
Supported testbed topology if it's a new test case?
All
Documentation
Just a bugfix.