[mgmt vrf] Fix LGTM and PEP8 errors in mgmt vrf tests#1865
Merged
daall merged 1 commit intosonic-net:masterfrom Jul 9, 2020
Merged
[mgmt vrf] Fix LGTM and PEP8 errors in mgmt vrf tests#1865daall merged 1 commit intosonic-net:masterfrom
daall merged 1 commit intosonic-net:masterfrom
Conversation
Signed-off-by: Danny Allen <daall@microsoft.com>
|
This pull request fixes 10 alerts when merging 71164c6 into e85eb58 - view on LGTM.com fixed alerts:
|
neethajohn
approved these changes
Jul 8, 2020
Contributor
Author
|
retest vsimage please |
tahmed-dev
approved these changes
Jul 8, 2020
Contributor
Author
|
retest vsimage please |
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
0dcb2b6 Open record file in append mode (sonic-net#1845) 03ce2ee [vnet/vxlan] Add support of multiple mappers for the VxLAN tunnel (sonic-net#1843) c5e90ab VOQ: Nexthop for remote VOQ LC should be created on inband OIF. (sonic-net#1823) 834c5c8 Td2: Reclaim buffer from unused ports (sonic-net#1830) a5ad55c [Dynamic Buffer Calc] Bug fix: Don't create lossless buffer profile for active ports without speed configured (sonic-net#1822) f50368f [cfgmgr] Update Makefile.am to consume lib zmq (sonic-net#1865)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Danny Allen daall@microsoft.com
Description of PR
Summary: Cleans up LGTM and PEP8 warnings in the mgmt vrf tests.
Fixes # (issue)
Type of change
Approach
What is the motivation for this PR?
Get rid of LGTM and PEP8 warnings on this file and made the style more consistent.
How did you do it?
Referred to this: https://lgtm.com/projects/g/Azure/sonic-mgmt/latest/files/tests/test_mgmtvrf.py?sort=name&dir=ASC&mode=heatmap and http://pep8online.com/ and cleaned up all the error messages.
How did you verify/test it?
Tested locally, behavior is same before and after the tests.
Any platform specific information?
N/A
Supported testbed topology if it's a new test case?
N/A
Documentation
N/A