Fix for port channel names mismatch in global and asic minigraph template files#18529
Merged
arlakshm merged 1 commit intosonic-net:masterfrom May 25, 2025
Merged
Conversation
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
@tjchadaga @arlakshm Can you please help merge this PR to master as well as on 202503 MSFT branch? |
arlakshm
approved these changes
May 22, 2025
YatishSVC
approved these changes
May 22, 2025
Collaborator
|
Cherry-pick PR to msft-202503: Azure/sonic-mgmt.msft#327 |
bachalla
pushed a commit
to bachalla/sonic-mgmt
that referenced
this pull request
Jun 2, 2025
…late files sonic-net#18529 Description of PR Summary: Fixes # (issue) This PR fixes the issue Bug: Minigraph generation is broken for multi asic sonic-net#18507 caused by chore: change portchannel naming sonic-net#18161 Portchannel name changes are done in file ansible/templates/minigraph_dpg.j2 but we need corresponding change in ansible/templates/minigraph_dpg_asic.j2 file as well so the names are same in both global and asic configs. Type of change Bug fix Testbed and Framework(new/improvement) New Test case Skipped for non-supported platforms Test case improvement Back port request 202012 202205 202305 202311 202405 202411 Approach What is the motivation for this PR? To fix the minigraph template issues w.r.t Portchannel names for global and asic. How did you do it? Add corresponding changes on ansible/templates/minigraph_dpg_asic.j2 similar to ansible/templates/minigraph_dpg.j2 How did you verify/test it? Run gen-mg with the new template modifications. With the new minigraph, made sure tests are passing for multi-asics Co-authored-by: ansrajpu <[email protected]>
opcoder0
pushed a commit
to opcoder0/sonic-mgmt
that referenced
this pull request
Dec 8, 2025
…late files sonic-net#18529 Description of PR Summary: Fixes # (issue) This PR fixes the issue Bug: Minigraph generation is broken for multi asic sonic-net#18507 caused by chore: change portchannel naming sonic-net#18161 Portchannel name changes are done in file ansible/templates/minigraph_dpg.j2 but we need corresponding change in ansible/templates/minigraph_dpg_asic.j2 file as well so the names are same in both global and asic configs. Type of change Bug fix Testbed and Framework(new/improvement) New Test case Skipped for non-supported platforms Test case improvement Back port request 202012 202205 202305 202311 202405 202411 Approach What is the motivation for this PR? To fix the minigraph template issues w.r.t Portchannel names for global and asic. How did you do it? Add corresponding changes on ansible/templates/minigraph_dpg_asic.j2 similar to ansible/templates/minigraph_dpg.j2 How did you verify/test it? Run gen-mg with the new template modifications. With the new minigraph, made sure tests are passing for multi-asics Co-authored-by: ansrajpu <[email protected]> Signed-off-by: opcoder0 <[email protected]>
AharonMalkin
pushed a commit
to AharonMalkin/sonic-mgmt
that referenced
this pull request
Dec 16, 2025
…late files sonic-net#18529 Description of PR Summary: Fixes # (issue) This PR fixes the issue Bug: Minigraph generation is broken for multi asic sonic-net#18507 caused by chore: change portchannel naming sonic-net#18161 Portchannel name changes are done in file ansible/templates/minigraph_dpg.j2 but we need corresponding change in ansible/templates/minigraph_dpg_asic.j2 file as well so the names are same in both global and asic configs. Type of change Bug fix Testbed and Framework(new/improvement) New Test case Skipped for non-supported platforms Test case improvement Back port request 202012 202205 202305 202311 202405 202411 Approach What is the motivation for this PR? To fix the minigraph template issues w.r.t Portchannel names for global and asic. How did you do it? Add corresponding changes on ansible/templates/minigraph_dpg_asic.j2 similar to ansible/templates/minigraph_dpg.j2 How did you verify/test it? Run gen-mg with the new template modifications. With the new minigraph, made sure tests are passing for multi-asics Co-authored-by: ansrajpu <[email protected]> Signed-off-by: Aharon Malkin <[email protected]>
gshemesh2
pushed a commit
to gshemesh2/sonic-mgmt
that referenced
this pull request
Dec 21, 2025
…late files sonic-net#18529 Description of PR Summary: Fixes # (issue) This PR fixes the issue Bug: Minigraph generation is broken for multi asic sonic-net#18507 caused by chore: change portchannel naming sonic-net#18161 Portchannel name changes are done in file ansible/templates/minigraph_dpg.j2 but we need corresponding change in ansible/templates/minigraph_dpg_asic.j2 file as well so the names are same in both global and asic configs. Type of change Bug fix Testbed and Framework(new/improvement) New Test case Skipped for non-supported platforms Test case improvement Back port request 202012 202205 202305 202311 202405 202411 Approach What is the motivation for this PR? To fix the minigraph template issues w.r.t Portchannel names for global and asic. How did you do it? Add corresponding changes on ansible/templates/minigraph_dpg_asic.j2 similar to ansible/templates/minigraph_dpg.j2 How did you verify/test it? Run gen-mg with the new template modifications. With the new minigraph, made sure tests are passing for multi-asics Co-authored-by: ansrajpu <[email protected]> Signed-off-by: Guy Shemesh <[email protected]>
gshemesh2
pushed a commit
to gshemesh2/sonic-mgmt
that referenced
this pull request
Jan 26, 2026
…late files sonic-net#18529 Description of PR Summary: Fixes # (issue) This PR fixes the issue Bug: Minigraph generation is broken for multi asic sonic-net#18507 caused by chore: change portchannel naming sonic-net#18161 Portchannel name changes are done in file ansible/templates/minigraph_dpg.j2 but we need corresponding change in ansible/templates/minigraph_dpg_asic.j2 file as well so the names are same in both global and asic configs. Type of change Bug fix Testbed and Framework(new/improvement) New Test case Skipped for non-supported platforms Test case improvement Back port request 202012 202205 202305 202311 202405 202411 Approach What is the motivation for this PR? To fix the minigraph template issues w.r.t Portchannel names for global and asic. How did you do it? Add corresponding changes on ansible/templates/minigraph_dpg_asic.j2 similar to ansible/templates/minigraph_dpg.j2 How did you verify/test it? Run gen-mg with the new template modifications. With the new minigraph, made sure tests are passing for multi-asics Co-authored-by: ansrajpu <[email protected]> Signed-off-by: Guy Shemesh <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
How did you do it?
How did you verify/test it?
Any platform specific information?
Mutliasic
Supported testbed topology if it's a new test case?
Documentation