[Mellanox] Change drop_counters infrastructure#1847
Merged
wangxin merged 3 commits intosonic-net:masterfrom Jul 14, 2020
Merged
[Mellanox] Change drop_counters infrastructure#1847wangxin merged 3 commits intosonic-net:masterfrom
wangxin merged 3 commits intosonic-net:masterfrom
Conversation
- Change folder name to drop_packets - Add drop_packets file to contain common drops - Change test_drop_counters.py to fit the new infra - Add feature_facts.py module Signed-off-by: Noa Or <noaor@mellanox.com>
|
This pull request introduces 1 alert when merging 4d758b9 into 403ab96 - view on LGTM.com new alerts:
|
wangxin
requested changes
Jul 13, 2020
Collaborator
|
@noaOrMlnx Could you please also resolve the merge conflicts? Thanks! |
Contributor
Author
|
retest this please |
|
This pull request introduces 1 alert when merging bb66228 into 01f4a98 - view on LGTM.com new alerts:
|
Contributor
Author
|
retest vsimage please |
wangxin
approved these changes
Jul 14, 2020
3 tasks
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
* 647f01f 2021-09-30 | [fstrim] limit smartctl execution time to 30 seconds (sonic-net#1850) (HEAD -> 202012, github/202012) [Ying Xie] * 371970e 2021-09-30 | [202012][show techsupport] address show techsupport return none zero code issue (sonic-net#1847) [Ying Xie] * 81a8386 2021-09-30 | Disable pfcwd forward action config for cisco-8000. (sonic-net#1848) [Alpesh Patel] Signed-off-by: Ying Xie <ying.xie@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Noa Or noaor@mellanox.com
Description of PR
Summary:
Fixes # (issue)
Type of change
Approach
What is the motivation for this PR?
How did you do it?
N/A
How did you verify/test it?
Execute drop_packets/test_drop_counters.py
Any platform specific information?
N/A
Supported testbed topology if it's a new test case?
N/A
Documentation