Fix verify_orchagent_running_or_assert() for multi-ASIC

[ysmanman]

Description of PR

Current implementation of verify_orchagent_running_or_assert does not verify orchagent state on all ASIC's. This is the code in question:

        if duthost.is_multi_asic:
            num_asic = duthost.facts.get('num_asic')
            for asic_index in range(num_asic):
                cmd = 'docker exec swss{} supervisorctl status orchagent'.format(asic_index)
                output = duthost.shell(cmd, module_ignore_errors=True)
                pytest_assert(not output['rc'], "Unable to check orchagent status output for asic_id {}"
                              .format(asic_index))
        else:
            cmds = 'docker exec swss supervisorctl status orchagent'
            output = duthost.shell(cmds, module_ignore_errors=True)
            pytest_assert(not output['rc'], "Unable to check orchagent status output")
        return 'RUNNING' in output['stdout']

On multi-ASIC, the validation of orchagent running state return 'RUNNING' in output['stdout'] is outside of the for loop. This means only the orchagent state of the ASIC with largest Id is checked.

Fix this by checking the orchagent state in for loop for every ASIC.

Summary:
Fixes # (issue)

Type of change

• Bug fix
• Testbed and Framework(new/improvement)
• New Test case
  • Skipped for non-supported platforms
• Test case improvement

Back port request

• 202012
• 202205
• 202305
• 202311
• 202405
• 202411

Approach

What is the motivation for this PR?

How did you do it?

How did you verify/test it?

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

[mssonicbld]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[ysmanman]

@arlakshm @tjchadaga @kenneth-arista

[arlakshm]

/Azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).