Skip to content

Skip BGP check in teardown if --skip-sanity is used#18408

Merged
yejianquan merged 1 commit intosonic-net:masterfrom
vivekverma-arista:skip-bgp-check
Jul 3, 2025
Merged

Skip BGP check in teardown if --skip-sanity is used#18408
yejianquan merged 1 commit intosonic-net:masterfrom
vivekverma-arista:skip-bgp-check

Conversation

@vivekverma-arista
Copy link
Copy Markdown
Contributor

Description of PR

Summary: Skip BGP check in teardown if --skip-sanity is used
Fixes #18407

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • New Test case
    • Skipped for non-supported platforms
  • Test case improvement

Back port request

  • 202012
  • 202205
  • 202305
  • 202311
  • 202405
  • 202411
  • msft-202405
  • msft-202412

Approach

What is the motivation for this PR?

The issue is described here: #18407

How did you do it?

Skip bgp check in teradown if --skip-sanity was passed while running the test.

How did you verify/test it?

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

@mssonicbld
Copy link
Copy Markdown
Collaborator

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@sdszhang sdszhang moved this to In Progress in SONiC Snappi May 22, 2025
@sdszhang sdszhang closed this Jun 28, 2025
@github-project-automation github-project-automation bot moved this from In Progress to Done in SONiC Snappi Jun 28, 2025
@sdszhang sdszhang reopened this Jun 28, 2025
@mssonicbld
Copy link
Copy Markdown
Collaborator

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@sdszhang sdszhang moved this from Done to In Progress in SONiC Snappi Jun 28, 2025
Copy link
Copy Markdown
Contributor

@sdszhang sdszhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sdszhang sdszhang moved this from In Progress to To be Merged in SONiC Snappi Jul 3, 2025
@yejianquan yejianquan merged commit bf76a62 into sonic-net:master Jul 3, 2025
22 checks passed
@github-project-automation github-project-automation bot moved this from To be Merged to Done in SONiC Snappi Jul 3, 2025
mssonicbld pushed a commit to mssonicbld/sonic-mgmt that referenced this pull request Jul 3, 2025
Description of PR
Summary: Skip BGP check in teardown if --skip-sanity is used
Fixes sonic-net#18407

Type of change
 Bug fix
 Testbed and Framework(new/improvement)
 New Test case
 Skipped for non-supported platforms
 Test case improvement
Back port request
 202012
 202205
 202305
 202311
 202405
 202411
 msft-202405
 msft-202412
Approach
What is the motivation for this PR?
The issue is described here: sonic-net#18407

How did you do it?
Skip bgp check in teradown if --skip-sanity was passed while running the test.

co-authorized by: jianquanye@microsoft.com
@mssonicbld
Copy link
Copy Markdown
Collaborator

Cherry-pick PR to 202505: #19355

mssonicbld pushed a commit that referenced this pull request Jul 3, 2025
Description of PR
Summary: Skip BGP check in teardown if --skip-sanity is used
Fixes #18407

Type of change
 Bug fix
 Testbed and Framework(new/improvement)
 New Test case
 Skipped for non-supported platforms
 Test case improvement
Back port request
 202012
 202205
 202305
 202311
 202405
 202411
 msft-202405
 msft-202412
Approach
What is the motivation for this PR?
The issue is described here: #18407

How did you do it?
Skip bgp check in teradown if --skip-sanity was passed while running the test.

co-authorized by: jianquanye@microsoft.com
@mssonicbld
Copy link
Copy Markdown
Collaborator

Cherry-pick PR to msft-202412: Azure/sonic-mgmt.msft#510

nissampa pushed a commit to nissampa/sonic-mgmt_dpu_test that referenced this pull request Aug 7, 2025
Description of PR
Summary: Skip BGP check in teardown if --skip-sanity is used
Fixes sonic-net#18407

Type of change
 Bug fix
 Testbed and Framework(new/improvement)
 New Test case
 Skipped for non-supported platforms
 Test case improvement
Back port request
 202012
 202205
 202305
 202311
 202405
 202411
 msft-202405
 msft-202412
Approach
What is the motivation for this PR?
The issue is described here: sonic-net#18407

How did you do it?
Skip bgp check in teradown if --skip-sanity was passed while running the test.

co-authorized by: jianquanye@microsoft.com
ashutosh-agrawal pushed a commit to ashutosh-agrawal/sonic-mgmt that referenced this pull request Aug 14, 2025
Description of PR
Summary: Skip BGP check in teardown if --skip-sanity is used
Fixes sonic-net#18407

Type of change
 Bug fix
 Testbed and Framework(new/improvement)
 New Test case
 Skipped for non-supported platforms
 Test case improvement
Back port request
 202012
 202205
 202305
 202311
 202405
 202411
 msft-202405
 msft-202412
Approach
What is the motivation for this PR?
The issue is described here: sonic-net#18407

How did you do it?
Skip bgp check in teradown if --skip-sanity was passed while running the test.

co-authorized by: jianquanye@microsoft.com
vidyac86 pushed a commit to vidyac86/sonic-mgmt that referenced this pull request Oct 23, 2025
Description of PR
Summary: Skip BGP check in teardown if --skip-sanity is used
Fixes sonic-net#18407

Type of change
 Bug fix
 Testbed and Framework(new/improvement)
 New Test case
 Skipped for non-supported platforms
 Test case improvement
Back port request
 202012
 202205
 202305
 202311
 202405
 202411
 msft-202405
 msft-202412
Approach
What is the motivation for this PR?
The issue is described here: sonic-net#18407

How did you do it?
Skip bgp check in teradown if --skip-sanity was passed while running the test.

co-authorized by: jianquanye@microsoft.com
opcoder0 pushed a commit to opcoder0/sonic-mgmt that referenced this pull request Dec 8, 2025
Description of PR
Summary: Skip BGP check in teardown if --skip-sanity is used
Fixes sonic-net#18407

Type of change
 Bug fix
 Testbed and Framework(new/improvement)
 New Test case
 Skipped for non-supported platforms
 Test case improvement
Back port request
 202012
 202205
 202305
 202311
 202405
 202411
 msft-202405
 msft-202412
Approach
What is the motivation for this PR?
The issue is described here: sonic-net#18407

How did you do it?
Skip bgp check in teradown if --skip-sanity was passed while running the test.

co-authorized by: jianquanye@microsoft.com

Signed-off-by: opcoder0 <110003254+opcoder0@users.noreply.github.com>
gshemesh2 pushed a commit to gshemesh2/sonic-mgmt that referenced this pull request Dec 16, 2025
Description of PR
Summary: Skip BGP check in teardown if --skip-sanity is used
Fixes sonic-net#18407

Type of change
 Bug fix
 Testbed and Framework(new/improvement)
 New Test case
 Skipped for non-supported platforms
 Test case improvement
Back port request
 202012
 202205
 202305
 202311
 202405
 202411
 msft-202405
 msft-202412
Approach
What is the motivation for this PR?
The issue is described here: sonic-net#18407

How did you do it?
Skip bgp check in teradown if --skip-sanity was passed while running the test.

co-authorized by: jianquanye@microsoft.com

Signed-off-by: Guy Shemesh <gshemesh@nvidia.com>
AharonMalkin pushed a commit to AharonMalkin/sonic-mgmt that referenced this pull request Dec 16, 2025
Description of PR
Summary: Skip BGP check in teardown if --skip-sanity is used
Fixes sonic-net#18407

Type of change
 Bug fix
 Testbed and Framework(new/improvement)
 New Test case
 Skipped for non-supported platforms
 Test case improvement
Back port request
 202012
 202205
 202305
 202311
 202405
 202411
 msft-202405
 msft-202412
Approach
What is the motivation for this PR?
The issue is described here: sonic-net#18407

How did you do it?
Skip bgp check in teradown if --skip-sanity was passed while running the test.

co-authorized by: jianquanye@microsoft.com

Signed-off-by: Aharon Malkin <amalkin@nvidia.com>
gshemesh2 pushed a commit to gshemesh2/sonic-mgmt that referenced this pull request Dec 21, 2025
Description of PR
Summary: Skip BGP check in teardown if --skip-sanity is used
Fixes sonic-net#18407

Type of change
 Bug fix
 Testbed and Framework(new/improvement)
 New Test case
 Skipped for non-supported platforms
 Test case improvement
Back port request
 202012
 202205
 202305
 202311
 202405
 202411
 msft-202405
 msft-202412
Approach
What is the motivation for this PR?
The issue is described here: sonic-net#18407

How did you do it?
Skip bgp check in teradown if --skip-sanity was passed while running the test.

co-authorized by: jianquanye@microsoft.com

Signed-off-by: Guy Shemesh <gshemesh@nvidia.com>
venu-nexthop pushed a commit to venu-nexthop/sonic-mgmt that referenced this pull request Jan 13, 2026
Description of PR
Summary: Skip BGP check in teardown if --skip-sanity is used
Fixes sonic-net#18407

Type of change
 Bug fix
 Testbed and Framework(new/improvement)
 New Test case
 Skipped for non-supported platforms
 Test case improvement
Back port request
 202012
 202205
 202305
 202311
 202405
 202411
 msft-202405
 msft-202412
Approach
What is the motivation for this PR?
The issue is described here: sonic-net#18407

How did you do it?
Skip bgp check in teradown if --skip-sanity was passed while running the test.

co-authorized by: jianquanye@microsoft.com
gshemesh2 pushed a commit to gshemesh2/sonic-mgmt that referenced this pull request Jan 26, 2026
Description of PR
Summary: Skip BGP check in teardown if --skip-sanity is used
Fixes sonic-net#18407

Type of change
 Bug fix
 Testbed and Framework(new/improvement)
 New Test case
 Skipped for non-supported platforms
 Test case improvement
Back port request
 202012
 202205
 202305
 202311
 202405
 202411
 msft-202405
 msft-202412
Approach
What is the motivation for this PR?
The issue is described here: sonic-net#18407

How did you do it?
Skip bgp check in teradown if --skip-sanity was passed while running the test.

co-authorized by: jianquanye@microsoft.com

Signed-off-by: Guy Shemesh <gshemesh@nvidia.com>
ytzur1 pushed a commit to ytzur1/sonic-mgmt that referenced this pull request Feb 2, 2026
Description of PR
Summary: Skip BGP check in teardown if --skip-sanity is used
Fixes sonic-net#18407

Type of change
 Bug fix
 Testbed and Framework(new/improvement)
 New Test case
 Skipped for non-supported platforms
 Test case improvement
Back port request
 202012
 202205
 202305
 202311
 202405
 202411
 msft-202405
 msft-202412
Approach
What is the motivation for this PR?
The issue is described here: sonic-net#18407

How did you do it?
Skip bgp check in teradown if --skip-sanity was passed while running the test.

co-authorized by: jianquanye@microsoft.com

Signed-off-by: Yael Tzur <ytzur@nvidia.com>
venu-nexthop pushed a commit to venu-nexthop/sonic-mgmt that referenced this pull request Mar 27, 2026
Description of PR
Summary: Skip BGP check in teardown if --skip-sanity is used
Fixes sonic-net#18407

Type of change
 Bug fix
 Testbed and Framework(new/improvement)
 New Test case
 Skipped for non-supported platforms
 Test case improvement
Back port request
 202012
 202205
 202305
 202311
 202405
 202411
 msft-202405
 msft-202412
Approach
What is the motivation for this PR?
The issue is described here: sonic-net#18407

How did you do it?
Skip bgp check in teradown if --skip-sanity was passed while running the test.

co-authorized by: jianquanye@microsoft.com
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Bug: SnappiTests when run with --skip-sanity still end up expecting BGP sessions during teardown.

5 participants