Enable pfcwd at global level for snappi tests involving pfcwd#18406
Open
vivekverma-arista wants to merge 1 commit intosonic-net:masterfrom
Open
Enable pfcwd at global level for snappi tests involving pfcwd#18406vivekverma-arista wants to merge 1 commit intosonic-net:masterfrom
vivekverma-arista wants to merge 1 commit intosonic-net:masterfrom
Conversation
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
sdszhang
reviewed
May 14, 2025
| return pfcwd_stats | ||
|
|
||
|
|
||
| def enable_default_pfcwd_status(duthost, asic_value=None): |
Contributor
There was a problem hiding this comment.
have we explored the option of enabling it at image level?
| meta_data = json.loads(res["stdout"]) | ||
| pfc_status = meta_data["DEVICE_METADATA|localhost"]["value"].get("default_pfcwd_status", "") | ||
| if pfc_status == 'disable': | ||
| cmd = cmd_prefix + 'sonic-db-cli CONFIG_DB hset \"DEVICE_METADATA|localhost\" default_pfcwd_status enable' |
Contributor
There was a problem hiding this comment.
need to revert back the change once test is finished.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary: Enable pfcwd at global level for snappi tests involving pfcwd
Fixes #18405
Type of change
Back port request
Approach
What is the motivation for this PR?
The issue is described in detail here: #18405
How did you do it?
Introduced a helper to emable pfcwd globally for pfcwd snappi tests.
How did you verify/test it?
Ran snappi pfcwd tests on Arista platform and didn't notice the symptom.
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation
Signed-off-by: [email protected] and [email protected]