Skip to content

[action] [PR:18176] skip 6 TCs for test_generic_hash.py for cisco-8000 (IP_PROTOCOL entropy)#18367

Merged
mssonicbld merged 1 commit intosonic-net:202411from
mssonicbld:cherry/202411/18176
May 19, 2025
Merged

[action] [PR:18176] skip 6 TCs for test_generic_hash.py for cisco-8000 (IP_PROTOCOL entropy)#18367
mssonicbld merged 1 commit intosonic-net:202411from
mssonicbld:cherry/202411/18176

Conversation

@mssonicbld
Copy link
Collaborator

Description of PR

Summary:
adding these 6 TCs in hash/test_generic_hash.py as skip in test_condition_mark.yaml
hash/test_generic_hash.py::test_lag_member_flap[CRC-IP_PROTOCOL-ipv4-None-None]
hash/test_generic_hash.py::test_lag_member_flap[CRC_CCITT-IP_PROTOCOL-ipv4-None-None]
hash/test_generic_hash.py::test_lag_member_remove_add[CRC-IP_PROTOCOL-ipv4-None-None]
hash/test_generic_hash.py::test_lag_member_remove_add[CRC_CCITT-IP_PROTOCOL-ipv4-None-None]
hash/test_generic_hash.py::test_reboot[CRC-IP_PROTOCOL-ipv4-None-None-cold]
hash/test_generic_hash.py::test_reboot[CRC_CCITT-IP_PROTOCOL-ipv4-None-None-cold]

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • New Test case
  • Skipped for non-supported platforms
  • Test case improvement

Back port request

  • 202012
  • 202205
  • 202305
  • 202311
  • 202405
  • 202411

Approach

What is the motivation for this PR?

to skip mentioned testcases in hash/test_generic_hash.py, reason being : With IP Protocol alone, we don't have enough entropy to distribute the packets evenly

How did you do it?

adding skip reasons and conditions for six TCs in test_conditional_mark.yaml file

How did you verify/test it?

via UT

Any platform specific information?

Cisco-8000

Supported testbed topology if it's a new test case?

Documentation

…py) (sonic-net#18176)

* Change xfail to skip in test_generic_hash.py conditions

* Update tests_mark_conditions.yaml

* Updated tests_mark_conditions.yaml as per Shiyan Wang comment

* fixed precommit yaml check issues

* Fix indentation

* Fix indentation
@mssonicbld
Copy link
Collaborator Author

Original PR: #18176

@mssonicbld
Copy link
Collaborator Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wsycqyz
Copy link
Contributor

wsycqyz commented May 15, 2025

Blocked by #18391

@wsycqyz
Copy link
Contributor

wsycqyz commented May 16, 2025

Close pr and re-open to restart pr test.

@wsycqyz wsycqyz closed this May 16, 2025
@wsycqyz wsycqyz reopened this May 16, 2025
@mssonicbld
Copy link
Collaborator Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld mssonicbld merged commit af16c9f into sonic-net:202411 May 19, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants