Fixe issue #18352: Stop skipping test/test_pktgen.py#18353
Merged
wangxin merged 1 commit intosonic-net:masterfrom May 15, 2025
Merged
Fixe issue #18352: Stop skipping test/test_pktgen.py#18353wangxin merged 1 commit intosonic-net:masterfrom
wangxin merged 1 commit intosonic-net:masterfrom
Conversation
This test was being skipped due to a known issue. The issue as resolved, but the test was never re-enabled.
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
wangxin
approved these changes
May 14, 2025
wangxin
reviewed
May 14, 2025
| reason: "Have known issue, only running for 'cisco-8000', skipping for all other ASIC types" | ||
| conditions: | ||
| - "asic_type not in ['cisco-8000']" | ||
| - "https://github.com/sonic-net/sonic-mgmt/issues/13804" |
Collaborator
There was a problem hiding this comment.
Please check on different asic types too. The issue is not the only condition for skipping.
wangxin
requested changes
May 14, 2025
Collaborator
wangxin
left a comment
wangxin
left a comment
There was a problem hiding this comment.
The issue is not the only condition for skipping.
wangxin
approved these changes
May 15, 2025
Collaborator
wangxin
left a comment
wangxin
left a comment
There was a problem hiding this comment.
My mistake interpreting the logic here. The existing condition is to only run on cisco-8000 because other platforms have the issue. Now the issue is resolved, all platforms can run this test. This entry can be removed. This change looks good to me.
wangxin
changed the title
11 tasks
12 tasks
yejianquan
added a commit
to Azure/sonic-mgmt.msft
that referenced
this pull request
Oct 14, 2025
This is a cherry-pick PR to include PR: sonic-net/sonic-mgmt#19399 This PR has a dependency PRs, which are included in this PR as well: sonic-net/sonic-mgmt#14460 sonic-net/sonic-mgmt#18353 signed-0ff-by: [email protected]
opcoder0
pushed a commit
to opcoder0/sonic-mgmt
that referenced
this pull request
Dec 8, 2025
…) (sonic-net#18353) This test was being skipped due to a known issue. The issue as resolved, but the test was never re-enabled. Signed-off-by: opcoder0 <[email protected]>
AharonMalkin
pushed a commit
to AharonMalkin/sonic-mgmt
that referenced
this pull request
Dec 16, 2025
…) (sonic-net#18353) This test was being skipped due to a known issue. The issue as resolved, but the test was never re-enabled. Signed-off-by: Aharon Malkin <[email protected]>
gshemesh2
pushed a commit
to gshemesh2/sonic-mgmt
that referenced
this pull request
Dec 21, 2025
…) (sonic-net#18353) This test was being skipped due to a known issue. The issue as resolved, but the test was never re-enabled. Signed-off-by: Guy Shemesh <[email protected]>
gshemesh2
pushed a commit
to gshemesh2/sonic-mgmt
that referenced
this pull request
Jan 26, 2026
…) (sonic-net#18353) This test was being skipped due to a known issue. The issue as resolved, but the test was never re-enabled. Signed-off-by: Guy Shemesh <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
This test was being skipped due to a #13804 The issue as #11441, but the test was never re-enabled.
Fixes #18352
Type of change
Back port request
Approach
What is the motivation for this PR?
Increase test coverage by re-enabling test.
How did you do it?
Removed conditional skip clause.
How did you verify/test it?
Ran the test with the clause removed and it passed.
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation