Skip to content

disable pfcwd for lossy platforms in deploy-mg#18350

Merged
StormLiangMS merged 5 commits intosonic-net:masterfrom
sdszhang:disable_pfcwd_th5
May 15, 2025
Merged

disable pfcwd for lossy platforms in deploy-mg#18350
StormLiangMS merged 5 commits intosonic-net:masterfrom
sdszhang:disable_pfcwd_th5

Conversation

@sdszhang
Copy link
Contributor

Description of PR

Summary:
Update default_pfcwd_status to disable for some platform which only have lossy traffic.

Note: This PR needs the image fix sonic-net/sonic-utilities#3880 for it to work.

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • New Test case
    • Skipped for non-supported platforms
  • Test case improvement

Back port request

  • 202012
  • 202205
  • 202305
  • 202311
  • 202405
  • 202412

Approach

What is the motivation for this PR?

Update the default pfcwd status in golden_config for lossy platform

How did you do it?

Update the default pfcwd status in golden_config for lossy platform

How did you verify/test it?

Verified on physical platform.

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

@mssonicbld
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@sdszhang
Copy link
Contributor Author

@yaqiangz @r12f can you help to review this one?

@sdszhang sdszhang changed the title disable pfcwd for TH5 in deploy-mg disable pfcwd for lossy platforms in deploy-mg May 12, 2025
@mssonicbld
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Contributor

@developfast developfast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as comments

Co-authored-by: Dev Ojha <[email protected]>
@mssonicbld
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Collaborator

@StormLiangMS StormLiangMS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi @sdszhang just small question, should we use HWSKU + topo to define lossy HW? I would think same HWSKU could use for lossless scenario also, so this assumption maybe not true in that case?

@sdszhang
Copy link
Contributor Author

sdszhang commented May 14, 2025

, should we use HWSKU + topo to define lossy HW? I would think same HWSKU could use for lossless scenario also, so this assumption maybe not true in that case?

these hwsku don't have lossless buffer defined in the /usr/share/sonic/device/<platform>/<hwsku> directory. so they cannot be used for lossless scenario. Currently, we don't have the scenario of using both lossless and lossy topo on same HWSKU, so should be fine. We can leave it for the future when the requirement comes in.

@sdszhang
Copy link
Contributor Author

manual cherry-pick PR to msft-202412: Azure/sonic-mgmt.msft#271

@StormLiangMS StormLiangMS merged commit fce7cef into sonic-net:master May 15, 2025
22 checks passed
@mssonicbld
Copy link
Collaborator

Cherry-pick PR to msft-202412:

opcoder0 pushed a commit to opcoder0/sonic-mgmt that referenced this pull request Dec 8, 2025
What is the motivation for this PR?
Update the default pfcwd status in golden_config for lossy platform

How did you do it?
Update the default pfcwd status in golden_config for lossy platform

How did you verify/test it?
Verified on physical platform.

Signed-off-by: opcoder0 <[email protected]>
AharonMalkin pushed a commit to AharonMalkin/sonic-mgmt that referenced this pull request Dec 16, 2025
What is the motivation for this PR?
Update the default pfcwd status in golden_config for lossy platform

How did you do it?
Update the default pfcwd status in golden_config for lossy platform

How did you verify/test it?
Verified on physical platform.

Signed-off-by: Aharon Malkin <[email protected]>
gshemesh2 pushed a commit to gshemesh2/sonic-mgmt that referenced this pull request Dec 21, 2025
What is the motivation for this PR?
Update the default pfcwd status in golden_config for lossy platform

How did you do it?
Update the default pfcwd status in golden_config for lossy platform

How did you verify/test it?
Verified on physical platform.

Signed-off-by: Guy Shemesh <[email protected]>
gshemesh2 pushed a commit to gshemesh2/sonic-mgmt that referenced this pull request Jan 26, 2026
What is the motivation for this PR?
Update the default pfcwd status in golden_config for lossy platform

How did you do it?
Update the default pfcwd status in golden_config for lossy platform

How did you verify/test it?
Verified on physical platform.

Signed-off-by: Guy Shemesh <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants