Update impact area testing algorithm#18302
Closed
opcoder0 wants to merge 1797 commits intosonic-net:masterfrom
Closed
Update impact area testing algorithm#18302opcoder0 wants to merge 1797 commits intosonic-net:masterfrom
opcoder0 wants to merge 1797 commits intosonic-net:masterfrom
Conversation
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines failed to run 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
| """ | ||
| python_files = [] | ||
| for root, _, files in os.walk(directory): | ||
| for file in files: |
Contributor
There was a problem hiding this comment.
There is also a object in python called file, to avoid misunderstanding, we can rename this to script
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
| """ | ||
| calls = {} | ||
| tree = None | ||
| with open(filepath, 'r') as file: |
Contributor
There was a problem hiding this comment.
Also, here, python has a same named object called file.
|
|
||
| affected_files = set() | ||
| for item in dependent_items: | ||
| for file, items in function_calls_per_file.items(): |
Contributor
There was a problem hiding this comment.
Also, we can rename here.
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
github-actions
bot
requested review from
FengPan-Frank,
GaladrielZhao,
Javier-Tan,
Praveen-Brcm,
Ryangwaite,
XuChen-MSFT,
arlakshm,
augusdn,
auspham,
developfast,
hdwhdw,
liamkearney-msft,
lipxu,
maipbui,
matthew-soulsby,
mihirpat1,
nhe-NV,
prabhataravind,
rajendrat,
rawal01,
sanjair-git,
theasianpianist,
vaibhavhd,
vamsipunati,
vivekrnv,
xincunli-sonic,
yyynini,
zbud-msft,
zhixzhu and
zjswhhh
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
The PR contains
Summary:
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
To evaluate a more fine-grained impact based on the exact changes.
How did you do it?
See description above
How did you verify/test it?
Locally through unit testing.
Any platform specific information?
NA
Supported testbed topology if it's a new test case?
NA
Documentation
TBD