[dualtor][sniffer] Explicitly set listen ports#18299
Merged
wangxin merged 1 commit intosonic-net:masterfrom May 12, 2025
Merged
[dualtor][sniffer] Explicitly set listen ports#18299wangxin merged 1 commit intosonic-net:masterfrom
wangxin merged 1 commit intosonic-net:masterfrom
Conversation
Signed-off-by: Longxiang Lyu <[email protected]>
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
yxieca
approved these changes
May 9, 2025
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
May 13, 2025
What is the motivation for this PR? On scapy with version v2.40 and under, the sniffer will capture packets on every interface if no interface is given. On scapy with version v.2.50 and higher, the sniffer will capture packets on conf.iface if no interface is given; on the ptf, conf.iface is mgmt, so dual_tor_sniffer is not able to capture any meaningful dataplane packets. secdev/scapy#1420 Signed-off-by: Longxiang Lyu [email protected] How did you do it? Let dual_tor_sniffer explicitly sniff on dataplane ports (any ptf ports starting with eth) How did you verify/test it? Run dualtor I/O testcase. Signed-off-by: Longxiang Lyu <[email protected]>
Collaborator
|
Cherry-pick PR to 202411: #18362 |
11 tasks
wangxin
pushed a commit
that referenced
this pull request
May 19, 2025
What is the motivation for this PR? On scapy with version v2.40 and under, the sniffer will capture packets on every interface if no interface is given. On scapy with version v.2.50 and higher, the sniffer will capture packets on conf.iface if no interface is given; on the ptf, conf.iface is mgmt, so dual_tor_sniffer is not able to capture any meaningful dataplane packets. secdev/scapy#1420 Signed-off-by: Longxiang Lyu [email protected] How did you do it? Let dual_tor_sniffer explicitly sniff on dataplane ports (any ptf ports starting with eth) How did you verify/test it? Run dualtor I/O testcase. Signed-off-by: Longxiang Lyu <[email protected]> Co-authored-by: Longxiang Lyu <[email protected]>
mssonicbld
added
Included in 202411 branch
and removed
Created PR to 202411 branch
labels
11 tasks
This was referenced Jun 3, 2025
opcoder0
pushed a commit
to opcoder0/sonic-mgmt
that referenced
this pull request
Dec 8, 2025
What is the motivation for this PR? On scapy with version v2.40 and under, the sniffer will capture packets on every interface if no interface is given. On scapy with version v.2.50 and higher, the sniffer will capture packets on conf.iface if no interface is given; on the ptf, conf.iface is mgmt, so dual_tor_sniffer is not able to capture any meaningful dataplane packets. secdev/scapy#1420 Signed-off-by: Longxiang Lyu [email protected] How did you do it? Let dual_tor_sniffer explicitly sniff on dataplane ports (any ptf ports starting with eth) How did you verify/test it? Run dualtor I/O testcase. Signed-off-by: Longxiang Lyu <[email protected]>
AharonMalkin
pushed a commit
to AharonMalkin/sonic-mgmt
that referenced
this pull request
Dec 16, 2025
What is the motivation for this PR? On scapy with version v2.40 and under, the sniffer will capture packets on every interface if no interface is given. On scapy with version v.2.50 and higher, the sniffer will capture packets on conf.iface if no interface is given; on the ptf, conf.iface is mgmt, so dual_tor_sniffer is not able to capture any meaningful dataplane packets. secdev/scapy#1420 Signed-off-by: Longxiang Lyu [email protected] How did you do it? Let dual_tor_sniffer explicitly sniff on dataplane ports (any ptf ports starting with eth) How did you verify/test it? Run dualtor I/O testcase. Signed-off-by: Longxiang Lyu <[email protected]> Signed-off-by: Aharon Malkin <[email protected]>
gshemesh2
pushed a commit
to gshemesh2/sonic-mgmt
that referenced
this pull request
Dec 21, 2025
What is the motivation for this PR? On scapy with version v2.40 and under, the sniffer will capture packets on every interface if no interface is given. On scapy with version v.2.50 and higher, the sniffer will capture packets on conf.iface if no interface is given; on the ptf, conf.iface is mgmt, so dual_tor_sniffer is not able to capture any meaningful dataplane packets. secdev/scapy#1420 Signed-off-by: Longxiang Lyu [email protected] How did you do it? Let dual_tor_sniffer explicitly sniff on dataplane ports (any ptf ports starting with eth) How did you verify/test it? Run dualtor I/O testcase. Signed-off-by: Longxiang Lyu <[email protected]> Signed-off-by: Guy Shemesh <[email protected]>
gshemesh2
pushed a commit
to gshemesh2/sonic-mgmt
that referenced
this pull request
Jan 26, 2026
What is the motivation for this PR? On scapy with version v2.40 and under, the sniffer will capture packets on every interface if no interface is given. On scapy with version v.2.50 and higher, the sniffer will capture packets on conf.iface if no interface is given; on the ptf, conf.iface is mgmt, so dual_tor_sniffer is not able to capture any meaningful dataplane packets. secdev/scapy#1420 Signed-off-by: Longxiang Lyu [email protected] How did you do it? Let dual_tor_sniffer explicitly sniff on dataplane ports (any ptf ports starting with eth) How did you verify/test it? Run dualtor I/O testcase. Signed-off-by: Longxiang Lyu <[email protected]> Signed-off-by: Guy Shemesh <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
On scapy with version v2.40 and under, the sniffer will capture packets on every interface if no interface is given.
On scapy with version v.2.50 and higher, the sniffer will capture packets on
conf.ifaceif no interface is given; on the ptf,conf.ifaceismgmt, sodual_tor_snifferis not able to capture any meaningful dataplane packets.secdev/scapy#1420
Signed-off-by: Longxiang Lyu [email protected]
How did you do it?
Let
dual_tor_snifferexplicitly sniff on dataplane ports (any ptf ports starting witheth)How did you verify/test it?
Run dualtor I/O testcase.
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation