Improve syslog pattern matching in test_caclmgrd_syslog#18257
Merged
StormLiangMS merged 1 commit intosonic-net:masterfrom May 16, 2025
Merged
Improve syslog pattern matching in test_caclmgrd_syslog#18257StormLiangMS merged 1 commit intosonic-net:masterfrom
StormLiangMS merged 1 commit intosonic-net:masterfrom
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Improve syslog pattern matching in test_caclmgrd_syslog
Summary:
This change addresses the wrong iptables syslog in the output of systemctl caclmgrd status.
** What is the motivation for this PR?**
The motivation is to make the test_caclmgrd_syslog test case pass in a dualtor testbed setup, where it was previously failing due to strict or outdated syslog match conditions.
How did you do it?
Adjusted the regex pattern used in the test case to match updated or slightly varied syslog formats related to caclmgrd, such as those involving iptables or mux updates.
How did you verify/test it?
Ran the test case on a dualtor setup locally and confirmed that the syslog pattern was successfully matched and the test passed.