Skip to content

Add xfail to test_ro_disk due to issue #18238 #18240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
AharonMalkin wants to merge 2 commits into from
Closed

Add xfail to test_ro_disk due to issue #18238 #18240

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
839ad47
Add skip to test_ro_disk due to issue #18238
AharonMalkin May 6, 2025
70416fe
Update tests_mark_conditions.yaml
AharonMalkin Jul 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions tests/common/plugins/conditional_mark/tests_mark_conditions.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2464,6 +2464,12 @@ tacacs/test_authorization.py::test_authorization_tacacs_and_local:
conditions:
- https://github.com/sonic-net/sonic-mgmt/issues/11349

tacacs/test_ro_disk.py:
Copy link
Copy Markdown
Collaborator

@r12f r12f Jul 15, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we actually never hit this issue, but hitting another once with PTF not properly setup. since this issue looks to be a rare race condition, so we are hesitant to take this change.

is this issue still repro'ing on your side? I am not seeing any hits in the latest run anymore.

Copy link
Copy Markdown
Contributor Author

@AharonMalkin AharonMalkin Jul 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we actually never hit this issue, but hitting another once with PTF not properly setup. since this issue looks to be a rare race condition, so we are hesitant to take this change.

is this issue still repro'ing on your side? I am not seeing any hits in the latest run anymore.

Will check and update

Copy link
Copy Markdown
Collaborator

@r12f r12f Aug 5, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

from the latest update, the issue cannot be reproduced anymore from your side. we will keep this change as it is for now.

xfail:
reason: "Testcase ignored due to Github issue: https://github.com/sonic-net/sonic-mgmt/issues/18238"
conditions:
- https://github.com/sonic-net/sonic-mgmt/issues/18238

#######################################
##### telemetry #####
#######################################
Expand Down
Loading