New snappi model changes missing in couple fixtures. by kamalsahu0001 · Pull Request #18227 · sonic-net/sonic-mgmt

kamalsahu0001 · 2025-05-05T19:35:54Z

PR is raised to incorporate the new snappi model changes to the fixtures which are missing the changes.

Summary:
Fixes # (issue)

Type of change

Bug fix
[x ] Testbed and Framework(new/improvement)
New Test case
- Skipped for non-supported platforms
Test case improvement

Back port request

Approach

What is the motivation for this PR?

How did you do it?

How did you verify/test it?

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

…t_state fixture

…t_cisco8000 fixture

… and stop traffic

…unter fixture.

mssonicbld · 2025-05-05T19:36:03Z

/azp run

azure-pipelines · 2025-05-05T19:36:15Z

Azure Pipelines successfully started running 1 pipeline(s).

sdszhang

lgtm

sdszhang · 2025-05-09T11:57:56Z

@kamalsahu0001 can you fix the static analysis failure?

fixed static analysis

mssonicbld · 2025-05-14T22:51:25Z

/azp run

azure-pipelines · 2025-05-14T22:51:36Z

Azure Pipelines successfully started running 1 pipeline(s).

fixed static analysis

mssonicbld · 2025-05-14T22:52:20Z

/azp run

azure-pipelines · 2025-05-14T22:52:25Z

Azure Pipelines will not run the associated pipelines, because the pull request was updated after the run command was issued. Review the pull request again and issue a new run command.

fixed static analysis

mssonicbld · 2025-05-14T22:52:58Z

/azp run

azure-pipelines · 2025-05-14T22:53:04Z

Azure Pipelines will not run the associated pipelines, because the pull request was updated after the run command was issued. Review the pull request again and issue a new run command.

fixed static analysis

mssonicbld · 2025-05-14T22:53:34Z

/azp run

azure-pipelines · 2025-05-14T22:53:40Z

Azure Pipelines will not run the associated pipelines, because the pull request was updated after the run command was issued. Review the pull request again and issue a new run command.

mssonicbld · 2025-05-14T23:01:37Z

/azp run

azure-pipelines · 2025-05-14T23:01:59Z

Azure Pipelines successfully started running 1 pipeline(s).

updated

mssonicbld · 2025-05-14T23:09:29Z

/azp run

azure-pipelines · 2025-05-14T23:09:41Z

Azure Pipelines successfully started running 1 pipeline(s).

updated the port_name field.

mssonicbld · 2025-05-21T07:45:05Z

/azp run

azure-pipelines · 2025-05-21T07:45:17Z

Azure Pipelines successfully started running 1 pipeline(s).

fixed port_name field.

mssonicbld · 2025-05-21T07:46:35Z

/azp run

azure-pipelines · 2025-05-21T07:46:47Z

Azure Pipelines successfully started running 1 pipeline(s).

fixed port_name field.

mssonicbld · 2025-05-21T07:47:46Z

/azp run

azure-pipelines · 2025-05-21T07:47:59Z

Azure Pipelines successfully started running 1 pipeline(s).

yejianquan

LGTM

PR is raised to incorporate the new snappi model changes to the fixtures which are missing the changes. * Updated helper.py to incorporate new snappi changes in toggle_dut_port_state fixture * Updated ecnhelper.py to incorporate new snappi changes to run_ecn_test_cisco8000 fixture * Updated bpfabric_helper.py to incorporate new snappi changes in start and stop traffic * Updated helper.py to incorporate new snappi changes to run_tx_drop_counter fixture. * Update bpfabric_helper.py fixed static analysis * Update ecnhelper.py fixed static analysis * Update helper.py fixed static analysis * Update helper.py fixed static analysis * Update ecnhelper.py updated * Update ecnhelper.py formatted ecnhelpler file. * Update bpfabric_helper.py formatted bpfabric_helper file. * Update ecnhelper.py removed additional line * Update helper.py formatted helper file * Update helper.py formatted helper file * Update helper.py updated the port_name field. * Update helper.py fixed port_name field. * Update ecnhelper.py fixed port_name field. co-authorized by: jianquanye@microsoft.com

mssonicbld · 2025-05-21T11:24:59Z

Cherry-pick PR to 202505: #18520

mssonicbld · 2025-05-21T11:25:04Z

Cherry-pick PR to msft-202405: Azure/sonic-mgmt.msft#309

PR is raised to incorporate the new snappi model changes to the fixtures which are missing the changes. * Updated helper.py to incorporate new snappi changes in toggle_dut_port_state fixture * Updated ecnhelper.py to incorporate new snappi changes to run_ecn_test_cisco8000 fixture * Updated bpfabric_helper.py to incorporate new snappi changes in start and stop traffic * Updated helper.py to incorporate new snappi changes to run_tx_drop_counter fixture. * Update bpfabric_helper.py fixed static analysis * Update ecnhelper.py fixed static analysis * Update helper.py fixed static analysis * Update helper.py fixed static analysis * Update ecnhelper.py updated * Update ecnhelper.py formatted ecnhelpler file. * Update bpfabric_helper.py formatted bpfabric_helper file. * Update ecnhelper.py removed additional line * Update helper.py formatted helper file * Update helper.py formatted helper file * Update helper.py updated the port_name field. * Update helper.py fixed port_name field. * Update ecnhelper.py fixed port_name field. co-authorized by: jianquanye@microsoft.com

PR is raised to incorporate the new snappi model changes to the fixtures which are missing the changes. * Updated helper.py to incorporate new snappi changes in toggle_dut_port_state fixture * Updated ecnhelper.py to incorporate new snappi changes to run_ecn_test_cisco8000 fixture * Updated bpfabric_helper.py to incorporate new snappi changes in start and stop traffic * Updated helper.py to incorporate new snappi changes to run_tx_drop_counter fixture. * Update bpfabric_helper.py fixed static analysis * Update ecnhelper.py fixed static analysis * Update helper.py fixed static analysis * Update helper.py fixed static analysis * Update ecnhelper.py updated * Update ecnhelper.py formatted ecnhelpler file. * Update bpfabric_helper.py formatted bpfabric_helper file. * Update ecnhelper.py removed additional line * Update helper.py formatted helper file * Update helper.py formatted helper file * Update helper.py updated the port_name field. * Update helper.py fixed port_name field. * Update ecnhelper.py fixed port_name field. co-authorized by: jianquanye@microsoft.com Signed-off-by: opcoder0 <110003254+opcoder0@users.noreply.github.com>

PR is raised to incorporate the new snappi model changes to the fixtures which are missing the changes. * Updated helper.py to incorporate new snappi changes in toggle_dut_port_state fixture * Updated ecnhelper.py to incorporate new snappi changes to run_ecn_test_cisco8000 fixture * Updated bpfabric_helper.py to incorporate new snappi changes in start and stop traffic * Updated helper.py to incorporate new snappi changes to run_tx_drop_counter fixture. * Update bpfabric_helper.py fixed static analysis * Update ecnhelper.py fixed static analysis * Update helper.py fixed static analysis * Update helper.py fixed static analysis * Update ecnhelper.py updated * Update ecnhelper.py formatted ecnhelpler file. * Update bpfabric_helper.py formatted bpfabric_helper file. * Update ecnhelper.py removed additional line * Update helper.py formatted helper file * Update helper.py formatted helper file * Update helper.py updated the port_name field. * Update helper.py fixed port_name field. * Update ecnhelper.py fixed port_name field. co-authorized by: jianquanye@microsoft.com Signed-off-by: Aharon Malkin <amalkin@nvidia.com>

PR is raised to incorporate the new snappi model changes to the fixtures which are missing the changes. * Updated helper.py to incorporate new snappi changes in toggle_dut_port_state fixture * Updated ecnhelper.py to incorporate new snappi changes to run_ecn_test_cisco8000 fixture * Updated bpfabric_helper.py to incorporate new snappi changes in start and stop traffic * Updated helper.py to incorporate new snappi changes to run_tx_drop_counter fixture. * Update bpfabric_helper.py fixed static analysis * Update ecnhelper.py fixed static analysis * Update helper.py fixed static analysis * Update helper.py fixed static analysis * Update ecnhelper.py updated * Update ecnhelper.py formatted ecnhelpler file. * Update bpfabric_helper.py formatted bpfabric_helper file. * Update ecnhelper.py removed additional line * Update helper.py formatted helper file * Update helper.py formatted helper file * Update helper.py updated the port_name field. * Update helper.py fixed port_name field. * Update ecnhelper.py fixed port_name field. co-authorized by: jianquanye@microsoft.com Signed-off-by: Guy Shemesh <gshemesh@nvidia.com>

kamalsahu0001 added 4 commits May 5, 2025 12:28

Updated helper.py to incorporate new snappi changes in toggle_dut_por…

62c8aa7

…t_state fixture

Updated ecnhelper.py to incorporate new snappi changes to run_ecn_tes…

f797490

…t_cisco8000 fixture

Updated bpfabric_helper.py to incorporate new snappi changes in start…

f6cb96b

… and stop traffic

Updated helper.py to incorporate new snappi changes to run_tx_drop_co…

d36aabf

…unter fixture.

sdszhang added this to SONiC Snappi May 7, 2025

sdszhang moved this to In Progress in SONiC Snappi May 7, 2025

sdszhang moved this from In Progress to To be Merged in SONiC Snappi May 7, 2025

sdszhang approved these changes May 8, 2025

View reviewed changes

Update bpfabric_helper.py

4bd7bbe

fixed static analysis

Update ecnhelper.py

e13dbc5

fixed static analysis

Update helper.py

2a79a2f

fixed static analysis

Update helper.py

0db563f

fixed static analysis

Merge branch 'master' into snappi-changes-missing

e336f94

Update ecnhelper.py

d6683f0

updated

sdszhang self-requested a review May 15, 2025 11:06

sdszhang added the Request for 202411 branch label May 17, 2025

Update helper.py

9ffdd15

updated the port_name field.

Update helper.py

90972d9

fixed port_name field.

Update ecnhelper.py

e2015db

fixed port_name field.

yejianquan approved these changes May 21, 2025

View reviewed changes

yejianquan merged commit 9c8e3a9 into sonic-net:master May 21, 2025
9 checks passed

github-project-automation bot moved this from To be Merged to Done in SONiC Snappi May 21, 2025

yejianquan added Approved for msft-202405 Branch Request for 202505 branch Approved for 202505 branch labels May 21, 2025

mssonicbld mentioned this pull request May 21, 2025

[action] [PR:18227] New snappi model changes missing in couple fixtures. Azure/sonic-mgmt.msft#309

Merged

10 tasks

mssonicbld added the Created PR to 202505 branch label May 21, 2025

mssonicbld added the Created PR to msft-202405 Branch label May 21, 2025

mssonicbld mentioned this pull request May 21, 2025

[action] [PR:18227] New snappi model changes missing in couple fixtures. #18520

Merged

10 tasks

mssonicbld added Included in 202505 branch and removed Created PR to 202505 branch labels May 23, 2025

Conversation

kamalsahu0001 commented May 5, 2025

Type of change

Back port request

Approach

What is the motivation for this PR?

How did you do it?

How did you verify/test it?

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

Uh oh!

mssonicbld commented May 5, 2025

Uh oh!

azure-pipelines bot commented May 5, 2025

Uh oh!

sdszhang left a comment

Choose a reason for hiding this comment

Uh oh!

sdszhang commented May 9, 2025

Uh oh!

mssonicbld commented May 14, 2025

Uh oh!

azure-pipelines bot commented May 14, 2025

Uh oh!

mssonicbld commented May 14, 2025

Uh oh!

azure-pipelines bot commented May 14, 2025

Uh oh!

mssonicbld commented May 14, 2025

Uh oh!

azure-pipelines bot commented May 14, 2025

Uh oh!

mssonicbld commented May 14, 2025

Uh oh!

azure-pipelines bot commented May 14, 2025

Uh oh!

mssonicbld commented May 14, 2025

Uh oh!

azure-pipelines bot commented May 14, 2025

Uh oh!

mssonicbld commented May 14, 2025

Uh oh!

azure-pipelines bot commented May 14, 2025

Uh oh!

mssonicbld commented May 21, 2025

Uh oh!

azure-pipelines bot commented May 21, 2025

Uh oh!

mssonicbld commented May 21, 2025

Uh oh!

azure-pipelines bot commented May 21, 2025

Uh oh!

mssonicbld commented May 21, 2025

Uh oh!

azure-pipelines bot commented May 21, 2025

Uh oh!

yejianquan left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

mssonicbld commented May 21, 2025

Uh oh!

mssonicbld commented May 21, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants