[Platform API][pytest] Add basic tests for PSU class#1817
Merged
sujinmkang merged 11 commits intosonic-net:masterfrom Jul 7, 2020
sujinmkang:test_psu
Merged
[Platform API][pytest] Add basic tests for PSU class#1817sujinmkang merged 11 commits intosonic-net:masterfrom sujinmkang:test_psu
sujinmkang merged 11 commits intosonic-net:masterfrom
sujinmkang:test_psu
Conversation
jleveque
suggested changes
Jun 26, 2020
Contributor
jleveque
left a comment
jleveque
left a comment
There was a problem hiding this comment.
@sujinmkang: Can you please add more details to the description along with an example test results summary? See #1759 for an example.
jleveque
suggested changes
Jun 27, 2020
Contributor
jleveque
left a comment
jleveque
left a comment
There was a problem hiding this comment.
As comments. Also, please ensure that all pytest_assert() error messages include details such as PSU ID and any seemingly incorrect values where applicable.
jleveque
suggested changes
Jun 28, 2020
Contributor
Author
|
retest vsimage please |
jleveque
changed the title
jleveque
suggested changes
Jun 30, 2020
jleveque
suggested changes
Jul 2, 2020
jleveque
suggested changes
Jul 2, 2020
jleveque
suggested changes
Jul 2, 2020
jleveque
suggested changes
Jul 2, 2020
tests/platform_tests/api/test_psu.py
Outdated
| self.expect(result is True, "Failed to set status_led of PSU {}".format(psu_id)) | ||
|
|
||
| color_status = psu.get_status_led(platform_api_conn, psu_id) | ||
| if self.expect(color_status is not None, "Failed to retrieve status_led of PSU {}".format(psu_id)): |
Contributor
There was a problem hiding this comment.
Suggest to reword message: Failed to retrieve status LED color of PSU {}
Contributor
There was a problem hiding this comment.
Please update this message as suggested.
Contributor
Author
|
retest this please |
jleveque
approved these changes
Jul 6, 2020
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
* 2a8957d 2021-09-14 | [202012][sonic-utilities] CLI support for port auto negotiation (sonic-net#1817) (HEAD, origin/202012) [vdahiya12] Signed-off-by: Guohan Lu <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a basic test suite for the Psu class of the new platform API, utilizing the platform API HTTP server, including the following functions:
Example test results summary:
This result could be returned when these apis are not implemented yet in the platform api on DUT.