[action] [PR:18096] [dualtor_io] Fix the start marker not found issue#18162
Merged
mssonicbld merged 1 commit intosonic-net:202411from Apr 29, 2025
Merged
[action] [PR:18096] [dualtor_io] Fix the start marker not found issue#18162mssonicbld merged 1 commit intosonic-net:202411from
mssonicbld merged 1 commit intosonic-net:202411from
Conversation
Fix the following issue: E Exception: start-LogAnalyzer-test_active_tor_reboot_downstream_standby[active-standby].2025-04-22-10:20:35 was not found in /var/log The issue is introduce by PR: sonic-net#17722. The root cause is, if the dualtor io reboot failure testcases are running over Arista devices, the syslogs doesn't persist through reboot due to /var/log is a tmpfs directory. So loganalyzer fails to find the start marker in this case. Signed-off-by: Longxiang Lyu [email protected] How did you do it? As the primary goal is to collect syslog after reboot, let's change the start marker as the kernel first boot log, so the dualtor io testcase with reboot will be able to collect logs after kernel boot up. How did you verify/test it? dualtor_io/test_tor_failure.py::test_active_tor_reboot_upstream[active-standby] PASSED [100%] ====================================================================== 1 passed, 1 deselected, 2 warnings in 527.94s (0:08:47) ======================================================================= Signed-off-by: Longxiang Lyu <[email protected]>
11 tasks
Collaborator
Author
|
Original PR: #18096 |
Collaborator
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
Fix the following issue:
The issue is introduce by PR: #17722.
The root cause is, if the dualtor io reboot failure testcases are running over Arista devices, the syslogs doesn't persist through reboot due to
/var/logis a tmpfs directory. Sologanalyzerfails to find the start marker in this case.Signed-off-by: Longxiang Lyu [email protected]
How did you do it?
As the primary goal is to collect syslog after reboot, let's change the start marker as the kernel first boot log, so the dualtor io testcase with reboot will be able to collect logs after kernel boot up.
How did you verify/test it?
Syslogs from kernel bootup are collected:
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation