Skip to content

Add lt2 topology#18159

Merged
bingwang-ms merged 1 commit intosonic-net:masterfrom
auspham:austinpham/32099755-LT2-definition
May 12, 2025
Merged

Add lt2 topology#18159
bingwang-ms merged 1 commit intosonic-net:masterfrom
auspham:austinpham/32099755-LT2-definition

Conversation

@auspham
Copy link
Contributor

@auspham auspham commented Apr 28, 2025

Description of PR

Summary: Adding LT2 topology and support for generate_topo. We needed to modify the PortChannel name to only use PortChannel10 for multi-asic only to avoid the interface name more than 15 characters which will violate linux interface name.

Fixes # (issue) 32099755

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • New Test case
    • Skipped for non-supported platforms
  • Test case improvement

Back port request

  • 202012
  • 202205
  • 202305
  • 202311
  • 202405
  • 202411

Approach

What is the motivation for this PR?

Add LT2 minigraph changes and topology

How did you do it?

How did you verify/test it?

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

@mssonicbld
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@auspham auspham requested a review from bingwang-ms April 28, 2025 22:34
@bingwang-ms
Copy link
Collaborator

Thanks for the PR. I would suggest separating the change into 2 different PRs

  • 1 for adding topology and update in generate_topo.py
  • 1 for updating the naming convention of PortChannels

@auspham auspham force-pushed the austinpham/32099755-LT2-definition branch from 948a2e9 to ab64798 Compare April 28, 2025 22:48
@mssonicbld
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@auspham auspham force-pushed the austinpham/32099755-LT2-definition branch from ab64798 to 4f947cb Compare April 28, 2025 23:10
@mssonicbld
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@bingwang-ms
Copy link
Collaborator

Retriggered PR test

@mssonicbld
Copy link
Collaborator

/azp run

bingwang-ms
bingwang-ms previously approved these changes May 1, 2025
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Signed-off-by: Austin Pham <austinpham@microsoft.com>
@auspham auspham force-pushed the austinpham/32099755-LT2-definition branch from a530047 to 30787fb Compare May 6, 2025 04:38
@mssonicbld
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@auspham
Copy link
Contributor Author

auspham commented May 8, 2025

/azpw run

@mssonicbld
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@auspham
Copy link
Contributor Author

auspham commented May 9, 2025

@bingwang-ms can we merge this?

@auspham auspham requested a review from bingwang-ms May 9, 2025 06:21
@bingwang-ms bingwang-ms merged commit 5ad68bb into sonic-net:master May 12, 2025
18 checks passed
r12f pushed a commit to Azure/sonic-mgmt.msft that referenced this pull request May 25, 2025
…#18159 (#326)

Cherry-pick generate_topo.py changes in
sonic-net/sonic-mgmt#18159 only into 202412 to
avoid conflict.

Removed LT2 part of change as it's not needed in 202412.

> ### Description of PR
> Summary: Adding LT2 topology and support for generate_topo. We needed
to modify the PortChannel name to only use `PortChannel10` for
multi-asic only to avoid the interface name more than 15 characters
which will violate linux interface name.
> 
> Fixes # (issue) 32099755
> 
> ### Type of change
> * [ ]  Bug fix
> * [ ]  Testbed and Framework(new/improvement)
> * [ ]  New Test case
>   
>   * [ ]  Skipped for non-supported platforms
> * [ ]  Test case improvement
> 
> ### Back port request
> * [ ]  202012
> * [ ]  202205
> * [ ]  202305
> * [ ]  202311
> * [ ]  202405
> * [ ]  202411
> 
> ### Approach
> #### What is the motivation for this PR?
> Add LT2 minigraph changes and topology
> 
> #### How did you do it?
> #### How did you verify/test it?
> #### Any platform specific information?
> #### Supported testbed topology if it's a new test case?
> ### Documentation
opcoder0 pushed a commit to opcoder0/sonic-mgmt that referenced this pull request Dec 8, 2025
Signed-off-by: Austin Pham <austinpham@microsoft.com>
AharonMalkin pushed a commit to AharonMalkin/sonic-mgmt that referenced this pull request Dec 16, 2025
Signed-off-by: Austin Pham <austinpham@microsoft.com>
Signed-off-by: Aharon Malkin <amalkin@nvidia.com>
gshemesh2 pushed a commit to gshemesh2/sonic-mgmt that referenced this pull request Dec 21, 2025
Signed-off-by: Austin Pham <austinpham@microsoft.com>
Signed-off-by: Guy Shemesh <gshemesh@nvidia.com>
gshemesh2 pushed a commit to gshemesh2/sonic-mgmt that referenced this pull request Jan 26, 2026
Signed-off-by: Austin Pham <austinpham@microsoft.com>
Signed-off-by: Guy Shemesh <gshemesh@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants