Skip to content

[action] [PR:18006] Fix for Everflow ACL Table Configuration Error#18127

Merged
mssonicbld merged 1 commit intosonic-net:202411from
mssonicbld:cherry/202411/18006
Apr 25, 2025
Merged

[action] [PR:18006] Fix for Everflow ACL Table Configuration Error#18127
mssonicbld merged 1 commit intosonic-net:202411from
mssonicbld:cherry/202411/18006

Conversation

@mssonicbld
Copy link
Copy Markdown
Collaborator

Description of PR

Summary:
Fix error when running everflow/test_everflow_testbed.py::TestEverflowV4EgressAclEgressMirror::test_everflow_dscp_with_policer:

E cmd = ['config', 'acl', 'add', 'table', 'EVERFLOW_DSCP', 'MIRROR_DSCP', '--stage', 'egress', '-p', 'Not', 'Applicable']
E Error: Got unexpected extra argument (Applicable)

The shell interpreter treats "Not Applicable" as two separate arguments instead of one value.

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • New Test case
  • Skipped for non-supported platforms
  • Test case improvement

Back port request

  • 202012
  • 202205
  • 202305
  • 202311
  • 202405
  • 202411

Approach

What is the motivation for this PR?

The shell interpreter treats "Not Applicable" as two separate arguments instead of one value, and causes error: RunAnsibleModuleFail: run module command failed

How did you do it?

By filtering out "Not Applicable" entries from the port list

How did you verify/test it?

Verified it in nightly test run:

-------------------------------- live log call ---------------------------------
everflow/test_everflow_testbed.py::TestEverflowV4IngressAclIngressMirror::test_everflow_dscp_with_policer[erspan_ipv4-cli-downstream-default] 
PASSED [ 5%]
everflow/test_everflow_testbed.py::TestEverflowV4IngressAclIngressMirror::test_everflow_dscp_with_policer[erspan_ipv4-cli-upstream-default] 
PASSED [ 30%]

Any platform specific information?

str4-sn5600-1

Supported testbed topology if it's a new test case?

t0-isolated-u16d16s1

Documentation

What is the motivation for this PR?
The shell interpreter treats "Not Applicable" as two separate arguments instead of one value, and causes error: RunAnsibleModuleFail: run module command failed

How did you do it?
By filtering out "Not Applicable" entries from the port list

How did you verify/test it?
Verified it in nightly test run:

-------------------------------- live log call ---------------------------------
everflow/test_everflow_testbed.py::TestEverflowV4IngressAclIngressMirror::test_everflow_dscp_with_policer[erspan_ipv4-cli-downstream-default] 
PASSED                                                                   [  5%]
everflow/test_everflow_testbed.py::TestEverflowV4IngressAclIngressMirror::test_everflow_dscp_with_policer[erspan_ipv4-cli-upstream-default] 
PASSED                                                                   [ 30%]
Any platform specific information?
str4-sn5600-1

Supported testbed topology if it's a new test case?
t0-isolated-u16d16s1
@mssonicbld
Copy link
Copy Markdown
Collaborator Author

Original PR: #18006

@mssonicbld
Copy link
Copy Markdown
Collaborator Author

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld mssonicbld merged commit 8f6d1a3 into sonic-net:202411 Apr 25, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants