Skip to content

[Voq]Voq tests changes to support single-dut-multi-asic#18062

Open
ansrajpu-git wants to merge 3 commits intosonic-net:masterfrom
ansrajpu-git:sdma_x_voq_change
Open

[Voq]Voq tests changes to support single-dut-multi-asic#18062
ansrajpu-git wants to merge 3 commits intosonic-net:masterfrom
ansrajpu-git:sdma_x_voq_change

Conversation

@ansrajpu-git
Copy link
Contributor

Description of PR

Enhancement to support VOQ tests for Single-Dut-Multi-Asic, T2 topo
Summary:
Fixes # (issue)

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • New Test case
    • Skipped for non-supported platforms
  • Test case improvement

Back port request

  • 202012
  • 202205
  • 202305
  • 202311
  • 202405
  • 202411

Approach

What is the motivation for this PR?

Test failures found during single-dut_multi_asic non modular chassis

How did you do it?

How did you verify/test it?

Any platform specific information?

Supported testbed topology if it's a new test case?

T2 VOQ Single Dut Multi ASIC

Documentation

@mssonicbld
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ansrajpu-git ansrajpu-git marked this pull request as ready for review April 21, 2025 19:53
@mssonicbld
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ansrajpu-git
Copy link
Contributor Author

@arlakshm , please review.

@ansrajpu-git
Copy link
Contributor Author

build failure -
"Error type: SANITY_CHECK_FAILED
Error message: Sanity check failed for vms-kvm-t1-lag on running test_pretest.py|||vms-kvm-t1-lag_371483
Operation failed with exception: Exception('Test plan id: 6809046e47778045ff82960d, status: FAILED, result: FAILED, Elapsed 783 seconds. Check https://elastictest.org/scheduler/testplan/6809046e47778045ff82960d for test plan status')"

Not in scope of the PR changes. Please help

@tjchadaga
Copy link
Contributor

@ysmanman - FYI

@tjchadaga
Copy link
Contributor

@ansrajpu-git - there is a cherry-pick conflict for 202503. could you please create a PR?

@ansrajpu-git
Copy link
Contributor Author

@ansrajpu-git - there is a cherry-pick conflict for 202503. could you please create a PR?

@tjchadaga , Dependent PR-##15994. Please cherry-pick this to msft-202503

@tjchadaga
Copy link
Contributor

@ansrajpu-git - there is a cherry-pick conflict for 202503. could you please create a PR?

@tjchadaga , Dependent PR-##15994. Please cherry-pick this to msft-202503

@ansrajpu-git - could you please create a separate PR for the multi-asic issue in test_voq_fabric_capacity, to avoid dependency and make this PR easier to cherry-pick?

@azure-pipelines
Copy link

Commenter does not have sufficient privileges for PR 18062 in repo sonic-net/sonic-mgmt

@jfeng-arista
Copy link
Contributor

I think we can just limit all the fabric related tests to run on modular systems, and no need run them on fixed systems without FE on it.

arlakshm pushed a commit to Azure/sonic-mgmt.msft that referenced this pull request May 16, 2025
…e-dut-multi-asic (#253)

Cherry pick of sonic-net/sonic-mgmt#18062
Depends on #252

We should first merge #252, this will cause a conflict which I can resolve with a rebase and then we should merge this in.
if 'T1' in value['name']:
dutA = a_dut
break
asic = value['namespace'][-1]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we change this (and the other line that does this) to
asic = value['namespace'][-1] if value['namespace'] else "0"
in order to also work with single-asic single-dut?

Copy link
Contributor

@arlakshm arlakshm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ansrajpu-git is this change still needed

@mssonicbld
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Azure Pipelines failed to run 1 pipeline(s).

@ansrajpu-git
Copy link
Contributor Author

@ansrajpu-git is this change still needed

Yes , these changes are still needed for voq tests to support single_dut_multi_asic.

@veronica-arista , updated the PR with your suggestion.

@arlakshm
Copy link
Contributor

@ansrajpu-git, can you please sign your commits

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

7 participants