[Voq]Voq tests changes to support single-dut-multi-asic#18062
[Voq]Voq tests changes to support single-dut-multi-asic#18062ansrajpu-git wants to merge 3 commits intosonic-net:masterfrom
Conversation
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@arlakshm , please review. |
|
build failure - Not in scope of the PR changes. Please help |
|
@ysmanman - FYI |
|
@ansrajpu-git - there is a cherry-pick conflict for 202503. could you please create a PR? |
@tjchadaga , Dependent PR-##15994. Please cherry-pick this to msft-202503 |
@ansrajpu-git - could you please create a separate PR for the multi-asic issue in test_voq_fabric_capacity, to avoid dependency and make this PR easier to cherry-pick? |
|
Commenter does not have sufficient privileges for PR 18062 in repo sonic-net/sonic-mgmt |
|
I think we can just limit all the fabric related tests to run on modular systems, and no need run them on fixed systems without FE on it. |
…e-dut-multi-asic (#253) Cherry pick of sonic-net/sonic-mgmt#18062 Depends on #252 We should first merge #252, this will cause a conflict which I can resolve with a rebase and then we should merge this in.
tests/voq/test_voq_ipfwd.py
Outdated
| if 'T1' in value['name']: | ||
| dutA = a_dut | ||
| break | ||
| asic = value['namespace'][-1] |
There was a problem hiding this comment.
Can we change this (and the other line that does this) to
asic = value['namespace'][-1] if value['namespace'] else "0"
in order to also work with single-asic single-dut?
arlakshm
left a comment
There was a problem hiding this comment.
@ansrajpu-git is this change still needed
a19ed7a to
d6791e6
Compare
|
/azp run |
|
Azure Pipelines failed to run 1 pipeline(s). |
Yes , these changes are still needed for voq tests to support single_dut_multi_asic. @veronica-arista , updated the PR with your suggestion. |
|
@ansrajpu-git, can you please sign your commits |
Description of PR
Enhancement to support VOQ tests for Single-Dut-Multi-Asic, T2 topo
Summary:
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
Test failures found during single-dut_multi_asic non modular chassis
How did you do it?
How did you verify/test it?
Any platform specific information?
Supported testbed topology if it's a new test case?
T2 VOQ Single Dut Multi ASIC
Documentation