Skip to content

Disable BMP feature for chassis supervisors #18037

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
abdosi merged 3 commits into from
Apr 21, 2025
Merged

Disable BMP feature for chassis supervisors #18037

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5215295
check whether the device is a supervisor before we enable bmp feature
BYGX-wcr Apr 17, 2025
bb71a8e
add comment
BYGX-wcr Apr 18, 2025
e51651a
one more note in comment
BYGX-wcr Apr 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ansible/library/generate_golden_config_db.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -363,7 +363,7 @@ def generate(self):
config = self.update_dns_config(config)

# To enable bmp feature
if self.check_version_for_bmp() is True:
if self.check_version_for_bmp() is True and device_info.is_supervisor() is False:
Copy link
Copy Markdown
Contributor

@FengPan-Frank FengPan-Frank Apr 18, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @BYGX-wcr for the change, could you also help to add some annotation in above line for why this check is needed?

Copy link
Copy Markdown
Contributor Author

@BYGX-wcr BYGX-wcr Apr 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added

if multi_asic.is_multi_asic():
config = self.overwrite_feature_golden_config_db_multiasic(config, "bmp")
else:
Expand Down
Loading