Skip to content

Fix t0-isolated-v6 topo errors#18029

Merged
StormLiangMS merged 5 commits intosonic-net:masterfrom
sdszhang:v6_topo_fix
Apr 21, 2025
Merged

Fix t0-isolated-v6 topo errors#18029
StormLiangMS merged 5 commits intosonic-net:masterfrom
sdszhang:v6_topo_fix

Conversation

@sdszhang
Copy link
Copy Markdown
Contributor

@sdszhang sdszhang commented Apr 17, 2025

Description of PR

Summary:
Fixes issues in isolated v6 topo.

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • New Test case
    • Skipped for non-supported platforms
  • Test case improvement

Back port request

  • 202012
  • 202205
  • 202305
  • 202311
  • 202405
  • 202411

Approach

What is the motivation for this PR?

Fix the following error

  • ipv6 address pattern
  • 'route-id' typo
  • remove template dependencies for nhipv4 and host['interfaces']['Loopback0']['ipv4']

How did you do it?

How did you verify/test it?

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

@mssonicbld
Copy link
Copy Markdown
Collaborator

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@sdszhang
Copy link
Copy Markdown
Contributor Author

@r12f

@mssonicbld
Copy link
Copy Markdown
Collaborator

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Copy Markdown
Collaborator

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@sdszhang sdszhang changed the title Fix isolated-v6 topo errors Fix t0-isolated-v6 topo errors Apr 18, 2025
Copy link
Copy Markdown
Collaborator

@StormLiangMS StormLiangMS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@StormLiangMS StormLiangMS merged commit 2486785 into sonic-net:master Apr 21, 2025
18 checks passed
@mssonicbld
Copy link
Copy Markdown
Collaborator

Cherry-pick PR to msft-202412: Azure/sonic-mgmt.msft#217

opcoder0 pushed a commit to opcoder0/sonic-mgmt that referenced this pull request Dec 8, 2025
What is the motivation for this PR?
Fix the following error

ipv6 address pattern
'route-id' typo
remove template dependencies for nhipv4 and host['interfaces']['Loopback0']['ipv4']

Signed-off-by: opcoder0 <110003254+opcoder0@users.noreply.github.com>
@markx-arista
Copy link
Copy Markdown
Contributor

markx-arista commented Dec 11, 2025

@sdszhang
Could you explain why ipv6_address_pattern: 2064:100:0::%02X%02X:%02X%02X:0/120 is added for v6 topo?
This pattern is used to generate routes in ansible/library/announce_routes.py.
And this makes test_acl.py fail in ipv6-ingress-uplink->downlink case on v6 topos because dest ip 20c0:a800::1 is not included in the pattern, so default route is used to forward the packet to the upstream port.
Non-v6 topo doesn't have ipv6_address_pattern set, so default IPV6_ADDRESS_PATTERN_DEFAULT_VALUE = '20%02X:%02X%02X:0:%02X::/64' is used, which covers the dest ip.
I think I can change the dest ip in test_acl.py to make it pass. I just wonder why we have the pattern set for v6 topos.

AharonMalkin pushed a commit to AharonMalkin/sonic-mgmt that referenced this pull request Dec 16, 2025
What is the motivation for this PR?
Fix the following error

ipv6 address pattern
'route-id' typo
remove template dependencies for nhipv4 and host['interfaces']['Loopback0']['ipv4']

Signed-off-by: Aharon Malkin <amalkin@nvidia.com>
gshemesh2 pushed a commit to gshemesh2/sonic-mgmt that referenced this pull request Dec 21, 2025
What is the motivation for this PR?
Fix the following error

ipv6 address pattern
'route-id' typo
remove template dependencies for nhipv4 and host['interfaces']['Loopback0']['ipv4']

Signed-off-by: Guy Shemesh <gshemesh@nvidia.com>
gshemesh2 pushed a commit to gshemesh2/sonic-mgmt that referenced this pull request Jan 26, 2026
What is the motivation for this PR?
Fix the following error

ipv6 address pattern
'route-id' typo
remove template dependencies for nhipv4 and host['interfaces']['Loopback0']['ipv4']

Signed-off-by: Guy Shemesh <gshemesh@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants