Remove unused arguments when calling testbed_config_vchassis playbook.#17999
Merged
rlhui merged 2 commits intosonic-net:masterfrom Apr 18, 2025
Merged
Remove unused arguments when calling testbed_config_vchassis playbook.#17999rlhui merged 2 commits intosonic-net:masterfrom
rlhui merged 2 commits intosonic-net:masterfrom
Conversation
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
ansible/testbed-cli.sh
Outdated
| if [[ $topo == *"t2"* ]]; then | ||
| ansible-playbook -i ${inv_name} testbed_config_vchassis.yml --vault-password-file="$passfile" -l "$duts" -e testbed_name="$testbed_name" \ | ||
| -e topo="$topo" -e testbed_file=$tbfile -e vm_file=$vmfile -e server="$server" $@ | ||
| ansible-playbook -i ${inv_name} testbed_config_vchassis.yml --vault-password-file="$passfile" -l "$duts" -e topo="$topo" |
Contributor
There was a problem hiding this comment.
I think the password file is saved in the variable ${passwd} in add_topo, not sure how important this is for this call.
Contributor
Author
There was a problem hiding this comment.
I just removed it.
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
arista-nwolfe
approved these changes
Apr 16, 2025
Contributor
Author
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
rlhui
approved these changes
Apr 18, 2025
opcoder0
pushed a commit
to opcoder0/sonic-mgmt
that referenced
this pull request
Dec 8, 2025
sonic-net#17999) * remove unused arguments when calling config_vchassis playbook. * remove unused --vault-password-file Signed-off-by: opcoder0 <110003254+opcoder0@users.noreply.github.com>
AharonMalkin
pushed a commit
to AharonMalkin/sonic-mgmt
that referenced
this pull request
Dec 16, 2025
sonic-net#17999) * remove unused arguments when calling config_vchassis playbook. * remove unused --vault-password-file Signed-off-by: Aharon Malkin <amalkin@nvidia.com>
gshemesh2
pushed a commit
to gshemesh2/sonic-mgmt
that referenced
this pull request
Dec 21, 2025
sonic-net#17999) * remove unused arguments when calling config_vchassis playbook. * remove unused --vault-password-file Signed-off-by: Guy Shemesh <gshemesh@nvidia.com>
gshemesh2
pushed a commit
to gshemesh2/sonic-mgmt
that referenced
this pull request
Jan 26, 2026
sonic-net#17999) * remove unused arguments when calling config_vchassis playbook. * remove unused --vault-password-file Signed-off-by: Guy Shemesh <gshemesh@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary: Previously, the testbed_config_vchassis.yml playbook was called with some unnecessary arguments which may cause failures for certain users depending on the user input. Now, we remove the unnecessary arguments to reduce the possibility caused by misinput.
Fixes #17922 (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
How did you do it?
How did you verify/test it?
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation