[tests_mark_conditions.yaml]: Skip GNMI/ZMQ test for isolated topology#17985
Merged
StormLiangMS merged 3 commits intosonic-net:masterfrom May 14, 2025
Merged
[tests_mark_conditions.yaml]: Skip GNMI/ZMQ test for isolated topology#17985StormLiangMS merged 3 commits intosonic-net:masterfrom
StormLiangMS merged 3 commits intosonic-net:masterfrom
Conversation
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
Can you add more context in PR description? |
Contributor
Author
@bingwang-ms Add more context in the motivation section, please check it. |
r12f
approved these changes
Apr 22, 2025
Contributor
Author
|
Hi @StormLiangMS , could you please help to review and merge this PR? |
StormLiangMS
reviewed
May 9, 2025
| reason: "Test is for smartswitch" | ||
| conditions: | ||
| - "'arista' in platform" | ||
| - "'isolated' in topo_name" |
Collaborator
There was a problem hiding this comment.
hi @Pterosaur should we add a OR condition in this case?
Contributor
Author
There was a problem hiding this comment.
Done, Please check it again.
Signed-off-by: Ze Gan <ganze718@gmail.com>
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
Cherry-pick PR to msft-202412: Azure/sonic-mgmt.msft#281 |
mssonicbld
added
Included in msft-202412 Branch
and removed
Created PR to msft-202412 Branch
labels
opcoder0
pushed a commit
to opcoder0/sonic-mgmt
that referenced
this pull request
Dec 8, 2025
sonic-net#17985) What is the motivation for this PR? GNMI ZMQ has an issue in isolated topology, but fixing it is not a priority because it isn't used in isolated topology. So, just skip this test. How did you do it? Add a condition in the skip file How did you verify/test it? Check locally Signed-off-by: opcoder0 <110003254+opcoder0@users.noreply.github.com>
AharonMalkin
pushed a commit
to AharonMalkin/sonic-mgmt
that referenced
this pull request
Dec 16, 2025
sonic-net#17985) What is the motivation for this PR? GNMI ZMQ has an issue in isolated topology, but fixing it is not a priority because it isn't used in isolated topology. So, just skip this test. How did you do it? Add a condition in the skip file How did you verify/test it? Check locally Signed-off-by: Aharon Malkin <amalkin@nvidia.com>
gshemesh2
pushed a commit
to gshemesh2/sonic-mgmt
that referenced
this pull request
Dec 21, 2025
sonic-net#17985) What is the motivation for this PR? GNMI ZMQ has an issue in isolated topology, but fixing it is not a priority because it isn't used in isolated topology. So, just skip this test. How did you do it? Add a condition in the skip file How did you verify/test it? Check locally Signed-off-by: Guy Shemesh <gshemesh@nvidia.com>
gshemesh2
pushed a commit
to gshemesh2/sonic-mgmt
that referenced
this pull request
Jan 26, 2026
sonic-net#17985) What is the motivation for this PR? GNMI ZMQ has an issue in isolated topology, but fixing it is not a priority because it isn't used in isolated topology. So, just skip this test. How did you do it? Add a condition in the skip file How did you verify/test it? Check locally Signed-off-by: Guy Shemesh <gshemesh@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
GNMI ZMQ has an issue in isolated topology, but fixing it is not a priority because it isn't used in isolated topology. So, just skip this test.
How did you do it?
Add a condition in the skip file
How did you verify/test it?
Check locally
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation