[DHCP] Add dhcp_server and dhcp_relay services to critical services if features are enabled#17976
Merged
Blueve merged 1 commit intosonic-net:masterfrom Apr 21, 2025
Merged
Conversation
…f features are enabled
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
xwjiang-ms
approved these changes
Apr 14, 2025
Contributor
Author
|
/azpw run Azure.sonic-mgmt |
Collaborator
|
/AzurePipelines run Azure.sonic-mgmt |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Blueve
approved these changes
Apr 21, 2025
opcoder0
pushed a commit
to opcoder0/sonic-mgmt
that referenced
this pull request
Dec 8, 2025
…f features are enabled (sonic-net#17976) What is the motivation for this PR? Sometimes dhcp containers are messed up by previous test, but sanity check cannot notice it because they are not critical services How did you do it? Add them to critical services if features are enabled How did you verify/test it? Run tests Signed-off-by: opcoder0 <[email protected]>
AharonMalkin
pushed a commit
to AharonMalkin/sonic-mgmt
that referenced
this pull request
Dec 16, 2025
…f features are enabled (sonic-net#17976) What is the motivation for this PR? Sometimes dhcp containers are messed up by previous test, but sanity check cannot notice it because they are not critical services How did you do it? Add them to critical services if features are enabled How did you verify/test it? Run tests Signed-off-by: Aharon Malkin <[email protected]>
gshemesh2
pushed a commit
to gshemesh2/sonic-mgmt
that referenced
this pull request
Dec 21, 2025
…f features are enabled (sonic-net#17976) What is the motivation for this PR? Sometimes dhcp containers are messed up by previous test, but sanity check cannot notice it because they are not critical services How did you do it? Add them to critical services if features are enabled How did you verify/test it? Run tests Signed-off-by: Guy Shemesh <[email protected]>
gshemesh2
pushed a commit
to gshemesh2/sonic-mgmt
that referenced
this pull request
Jan 26, 2026
…f features are enabled (sonic-net#17976) What is the motivation for this PR? Sometimes dhcp containers are messed up by previous test, but sanity check cannot notice it because they are not critical services How did you do it? Add them to critical services if features are enabled How did you verify/test it? Run tests Signed-off-by: Guy Shemesh <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
Sometimes dhcp containers are messed up by previous test, but sanity check cannot notice it because they are not critical services
How did you do it?
Add them to critical services if features are enabled
How did you verify/test it?
Run tests
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation