[action] [PR:17909] [dualtor_io] Allow duplications for link down downstream I/O#17970
Merged
mssonicbld merged 1 commit intosonic-net:202411from Apr 21, 2025
Merged
Conversation
…et#17909) What is the motivation for this PR? The following two link failure cases are failing on Cisco/MLNX: test_active_link_down_downstream_active test_active_link_down_downstream_active_soc The reason is that, after link down, between the fdb flush and tunnel route add (due to mux toggle-to-standby), the ASIC has no l2 information for server/soc neighbors, downstream traffic will flood to all vlan member ports on Cisco/MLNX platform. Those two testcase has no tolerance for packet duplications due to that, on Broadcom platform, traffic to neighbors with no l2 information will be simply dropped. Let's adapt to Cisco/MLNX platform, by allowing packet duplications for those two testcases. How did you verify/test it? dualtor_io/test_link_failure.py::test_active_link_down_downstream_active[active-active] PASSED [100%] dualtor_io/test_link_failure.py::test_active_link_down_downstream_active_soc[active-active] PASSED [100%] Signed-off-by: Longxiang Lyu <lolv@microsoft.com>
11 tasks
Collaborator
Author
|
Original PR: #17909 |
Collaborator
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
The following two link failure cases are failing on Cisco/MLNX:
The reason is that, after link down, between the fdb flush and tunnel route add (due to mux toggle-to-standby), the ASIC has no l2 information for server/soc neighbors, downstream traffic will flood to all vlan member ports on Cisco/MLNX platform.
Those two testcase has no tolerance for packet duplications due to that, on Broadcom platform, traffic to neighbors with no l2 information will be simply dropped.
Let's adapt to Cisco/MLNX platform, by allowing packet duplications for those two testcases.
Signed-off-by: Longxiang Lyu lolv@microsoft.com
How did you do it?
As the motivation.
How did you verify/test it?
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation