[action] [PR:17904] Increase timeout to 5 in verify_packet_any_port for background traffic#17921
Merged
mssonicbld merged 1 commit intosonic-net:202411from Apr 10, 2025
Merged
Conversation
sonic-net#17904) What is the motivation for this PR? The test is giving us a false negative msg = 'Did not receive expected packet on any of ports [7, 13, 17, 30, 27, 25, 5, 34, 21, 16, 24, 1, 33, 12, 4, 20, 2, 0, 11... 01 .............0..\n0050 00 AA BB CC DD EE ......\n==============================\n' self = <tests.common.plugins.ptfadapter.ptfadapter.PtfTestAdapter testMethod=runTest> /usr/lib/python3.8/unittest/case.py:753: AssertionError Although on a closer look we found that the DUTis forwarding the packet in a reasonable duration of time but for some reason testutils.verify_packet_any_port is taking longer to detect it. There is also another issue which doesn't cause any failure but defeats the purpose of testing. In case of active-active dualtor we call setup_standby_ports_on_rand_unselected_tor_unconditionally to put the system in active-standby mode. If this is called after background_traffic then the background trafffic flows through the unselected ToR which is not desired. How did you do it? Increase the timeout to 5s from system default for testutils.verify_packet_any_port Make the order of fixture execution deterministic so that setup_standby_ports_on_rand_unselected_tor_unconditionally is called before background_traffic How did you verify/test it? Verified on Arista-7050CX3 with dualtor-aa topology.
11 tasks
Collaborator
Author
|
Original PR: #17904 |
Collaborator
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary: Increase timeout to 5 in verify_packet_any_port for background traffic
Fixes #522, #496
Type of change
Back port request
Approach
What is the motivation for this PR?
The test is giving us a false negative
Although on a closer look we found that the DUTis forwarding the packet in a reasonable duration of time but for some reason
testutils.verify_packet_any_portis taking longer to detect it.There is also another issue which doesn't cause any failure but defeats the purpose of testing. In case of active-active dualtor we call
setup_standby_ports_on_rand_unselected_tor_unconditionallyto put the system in active-standby mode. If this is called afterbackground_trafficthen the background trafffic flows through the unselected ToR which is not desired.How did you do it?
Increase the timeout to 5s from system default for
testutils.verify_packet_any_portMake the order of fixture execution deterministic so that
setup_standby_ports_on_rand_unselected_tor_unconditionallyis called beforebackground_trafficHow did you verify/test it?
Verified on Arista-7050CX3 with dualtor-aa topology.
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation