Skip to content

DASH PL tests fixes#17881

Merged
bingwang-ms merged 2 commits intosonic-net:masterfrom
prabhataravind:paravind/dash-fixes
Apr 22, 2025
Merged

DASH PL tests fixes#17881
bingwang-ms merged 2 commits intosonic-net:masterfrom
prabhataravind:paravind/dash-fixes

Conversation

@prabhataravind
Copy link
Copy Markdown
Contributor

@prabhataravind prabhataravind commented Apr 7, 2025

  • Teardown configurations after the test
  • Make sure that vnet mapping is configured after routing_type is configured
  • Add an option to select the dpu to use for testing

Description of PR

Summary:
Fixes # (issue)

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • New Test case
    • Skipped for non-supported platforms
  • Test case improvement

Back port request

  • 202012
  • 202205
  • 202305
  • 202311
  • 202405
  • 202411

Approach

What is the motivation for this PR?

To make sure that configuration applied during the test is cleaned up properly at the end of the test.

How did you do it?

By adding cleanup logic for PL tests.

How did you verify/test it?

By running sonic-mgmt test PL test and verifying that the DASH objects programmed during the test are cleaned up at the end.

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

@mssonicbld
Copy link
Copy Markdown
Collaborator

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Copy Markdown
Collaborator

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Copy Markdown
Collaborator

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@prabhataravind prabhataravind marked this pull request as ready for review April 10, 2025 19:07
@mssonicbld
Copy link
Copy Markdown
Collaborator

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

 * Teardown configurations after the test
 * Add an option to select the dpu to use for testing

Signed-off-by: Prabhat Aravind <[email protected]>
 * Orchagent needs routing_type to be programmed before ca_to_pa mappings can
   be programmed. This was exposed when adding the changes in sonic-mgmt to
   cleanup configurations at the end of the test. The fix here merely avoids the
   problem by configuring objects in the right order but this will need an
   orchagent fix as well to avoid stale object being left behind in ASIC_DB.

Signed-off-by: Prabhat Aravind <[email protected]>
@mssonicbld
Copy link
Copy Markdown
Collaborator

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@prabhataravind
Copy link
Copy Markdown
Contributor Author

@mukeshmv please review. My PR had a conflict with yours.

Copy link
Copy Markdown
Contributor

@mukeshmv mukeshmv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@bingwang-ms bingwang-ms merged commit 8c888ce into sonic-net:master Apr 22, 2025
13 checks passed
opcoder0 pushed a commit to opcoder0/sonic-mgmt that referenced this pull request Dec 8, 2025
* DASH PL tests fixes

 * Teardown configurations after the test
 * Add an option to select the dpu to use for testing

Signed-off-by: Prabhat Aravind <[email protected]>
AharonMalkin pushed a commit to AharonMalkin/sonic-mgmt that referenced this pull request Dec 16, 2025
* DASH PL tests fixes

 * Teardown configurations after the test
 * Add an option to select the dpu to use for testing

Signed-off-by: Prabhat Aravind <[email protected]>

Signed-off-by: Aharon Malkin <[email protected]>
gshemesh2 pushed a commit to gshemesh2/sonic-mgmt that referenced this pull request Dec 21, 2025
* DASH PL tests fixes

 * Teardown configurations after the test
 * Add an option to select the dpu to use for testing

Signed-off-by: Prabhat Aravind <[email protected]>

Signed-off-by: Guy Shemesh <[email protected]>
gshemesh2 pushed a commit to gshemesh2/sonic-mgmt that referenced this pull request Jan 26, 2026
* DASH PL tests fixes

 * Teardown configurations after the test
 * Add an option to select the dpu to use for testing

Signed-off-by: Prabhat Aravind <[email protected]>

Signed-off-by: Guy Shemesh <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants