[PR#17130] - lldp - Changes for VOQ single-dut multi-asic#17837
Merged
rlhui merged 1 commit intosonic-net:masterfrom Apr 17, 2025
Merged
[PR#17130] - lldp - Changes for VOQ single-dut multi-asic#17837rlhui merged 1 commit intosonic-net:masterfrom
rlhui merged 1 commit intosonic-net:masterfrom
Conversation
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
11 tasks
tjchadaga
reviewed
Apr 8, 2025
| duthost.facts['switch_type'] == "voq" | ||
| is_chassis = duthost.get_facts().get("modular_chassis") | ||
| if duthost.facts['switch_type'] == "voq" and not is_chassis: | ||
| appl_db.append(SonicDbCli(duthost, APPL_DB)) |
Contributor
There was a problem hiding this comment.
why is this change needed? Since the disagg chassis is also multi-asic, is the current code not sufficient?
sanjair-git
commented
Apr 9, 2025
Contributor
Author
sanjair-git
left a comment
sanjair-git
left a comment
There was a problem hiding this comment.
Hi @tjchadaga, this change is needed for multi-asic disagg chassis. Because this has out-of-band management port (eth0) which is not present in line cards. For example,
admin@ixr-x3b-5:~$ show lldp table
Capability codes: (R) Router, (B) Bridge, (O) Other
LocalPort RemoteDevice RemotePortID Capability RemotePortDescr
----------- ---------------- -------------- ------------ ---------------
Ethernet48 ARISTA01T3 Ethernet1 BR
Ethernet96 ARISTA02T3 Ethernet1 BR
Ethernet104 ARISTA03T3 Ethernet1 BR
Ethernet192 ARISTA05T1 Ethernet1 BR
Ethernet200 ARISTA05T1 Ethernet2 BR
Ethernet272 ARISTA07T1 Ethernet1 BR
eth0 wfr-io-d-6-tor-1 35880960 BR 1/1/7, 10/100/G
--------------------------------------------------
Total entries displayed: 7
admin@ixr-x3b-5:~$
tjchadaga
approved these changes
Apr 10, 2025
arlakshm
approved these changes
Apr 17, 2025
Collaborator
|
Cherry-pick PR to msft-202503: Azure/sonic-mgmt.msft#201 |
mssonicbld
added
Included in msft-202503 Branch
and removed
Created PR to msft-202503 Branch
labels
opcoder0
pushed a commit
to opcoder0/sonic-mgmt
that referenced
this pull request
Dec 8, 2025
Split the original PR Reg: Changes of VOQ Single Dut Multi asic sonic-net#17130 into individual PRs for each test. This is an enhancement to support VOQ Single DUT Multi-ASIC setup for T2 topo. Signed-off-by: opcoder0 <[email protected]>
AharonMalkin
pushed a commit
to AharonMalkin/sonic-mgmt
that referenced
this pull request
Dec 16, 2025
Split the original PR Reg: Changes of VOQ Single Dut Multi asic sonic-net#17130 into individual PRs for each test. This is an enhancement to support VOQ Single DUT Multi-ASIC setup for T2 topo. Signed-off-by: Aharon Malkin <[email protected]>
gshemesh2
pushed a commit
to gshemesh2/sonic-mgmt
that referenced
this pull request
Dec 21, 2025
Split the original PR Reg: Changes of VOQ Single Dut Multi asic sonic-net#17130 into individual PRs for each test. This is an enhancement to support VOQ Single DUT Multi-ASIC setup for T2 topo. Signed-off-by: Guy Shemesh <[email protected]>
gshemesh2
pushed a commit
to gshemesh2/sonic-mgmt
that referenced
this pull request
Jan 26, 2026
Split the original PR Reg: Changes of VOQ Single Dut Multi asic sonic-net#17130 into individual PRs for each test. This is an enhancement to support VOQ Single DUT Multi-ASIC setup for T2 topo. Signed-off-by: Guy Shemesh <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
How did you do it?
How did you verify/test it?
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation