Added new hwskus Mellanox-SN5640-C512S2 Mellanox-SN5640-C448O16#17785
Closed
SavchukRomanLv wants to merge 2 commits intosonic-net:masterfrom
Closed
Added new hwskus Mellanox-SN5640-C512S2 Mellanox-SN5640-C448O16#17785SavchukRomanLv wants to merge 2 commits intosonic-net:masterfrom
SavchukRomanLv wants to merge 2 commits intosonic-net:masterfrom
Conversation
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
SavchukRomanLv
force-pushed
the
intruduce_scp5_hwskus
branch
from
1cd5184 to
2f422b0
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
11 tasks
liat-grozovik
previously approved these changes
May 28, 2025
Collaborator
|
@AharonMalkin need to resolve conflict and then i can also merge the other PR depends on this one |
Contributor
|
@liat-grozovik conflicts resolved |
illia-kotvitskyi
force-pushed
the
intruduce_scp5_hwskus
branch
from
0a3f76b to
1190d44
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
r12f
added
Request for msft-202412 Branch
and removed
Request for msft-202412 Branch
Cherry Pick Conflict_msft-202412
labels
r12f
approved these changes
Jun 11, 2025
r12f
reviewed
Jun 11, 2025
| 'Mellanox-SN5610N-C256S2', 'Mellanox-SN5610N-C224O8'] | ||
| mellanox_spc5_hwskus: [ 'Mellanox-SN5640-C512S2', 'Mellanox-SN5640-C448O16'] | ||
| mellanox_hwskus: "{{ mellanox_spc1_hwskus + mellanox_spc2_hwskus + mellanox_spc3_hwskus + mellanox_spc4_hwskus + mellanox_spc5_hwskus + mellanox_spc5_hwskus }}" | ||
| mellanox_spc5_hwskus: [ Mellanox-SN5640-C512S2', 'Mellanox-SN5640-C448O16'] |
Contributor
There was a problem hiding this comment.
Looks like there is a missing leading '.
Will go with this PR: #18921
Collaborator
|
@AharonMalkin please review the other PR mentioned. If it is good please approve it. and then we can close this one |
Contributor
|
Other PR approved, will close this one |
mssonicbld
added a commit
to mssonicbld/sonic-mgmt.msft
that referenced
this pull request
Jun 27, 2025
<!-- Please make sure you've read and understood our contributing guidelines; https://github.com/sonic-net/SONiC/blob/gh-pages/CONTRIBUTING.md Please provide following information to help code review process a bit easier: --> ### Description of PR <!-- - Please include a summary of the change and which issue is fixed. - Please also include relevant motivation and context. Where should reviewer start? background context? - List any dependencies that are required for this change. --> Summary: Introduced x86_64-nvidia_sn5640-r0 for platform tests Must be merged after sonic-net/sonic-mgmt#17785 ### Type of change <!-- - Fill x for your type of change. - e.g. - [x] Bug fix --> - [ ] Bug fix - [ ] Testbed and Framework(new/improvement) - [ ] New Test case - [ ] Skipped for non-supported platforms - [ ] Test case improvement ### Back port request - [ ] 202012 - [ ] 202205 - [ ] 202305 - [ ] 202311 - [ ] 202405 - [ ] 202411 ### Approach #### What is the motivation for this PR? Add new platform to be covered in sonic-mgmt #### How did you do it? Add appropriate data in sensors, psus, qos test data and test cases #### How did you verify/test it? Run sensors, psu, qos tests cases #### Any platform specific information? #### Supported testbed topology if it's a new test case? ### Documentation <!-- (If it's a new feature, new test case) Did you update documentation/Wiki relevant to your implementation? Link to the wiki page? -->
Merged
11 tasks
mssonicbld
added a commit
to Azure/sonic-mgmt.msft
that referenced
this pull request
Jun 28, 2025
…ests (#463) <!-- Please make sure you've read and understood our contributing guidelines; https://github.com/sonic-net/SONiC/blob/gh-pages/CONTRIBUTING.md Please provide following information to help code review process a bit easier: --> ### Description of PR <!-- - Please include a summary of the change and which issue is fixed. - Please also include relevant motivation and context. Where should reviewer start? background context? - List any dependencies that are required for this change. --> Summary: Introduced x86_64-nvidia_sn5640-r0 for platform tests Must be merged after sonic-net/sonic-mgmt#17785 ### Type of change <!-- - Fill x for your type of change. - e.g. - [x] Bug fix --> - [ ] Bug fix - [ ] Testbed and Framework(new/improvement) - [ ] New Test case - [ ] Skipped for non-supported platforms - [ ] Test case improvement ### Back port request - [ ] 202012 - [ ] 202205 - [ ] 202305 - [ ] 202311 - [ ] 202405 - [ ] 202411 ### Approach #### What is the motivation for this PR? Add new platform to be covered in sonic-mgmt #### How did you do it? Add appropriate data in sensors, psus, qos test data and test cases #### How did you verify/test it? Run sensors, psu, qos tests cases #### Any platform specific information? #### Supported testbed topology if it's a new test case? ### Documentation <!-- (If it's a new feature, new test case) Did you update documentation/Wiki relevant to your implementation? Link to the wiki page? -->
11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Added 2 new hwskus for Nvidia platforms
Type of change
Back port request
Approach
What is the motivation for this PR?
Introduce new NVIDIA platforms
How did you do it?
Added data to sonic-mgmt framework
How did you verify/test it?
Run regression with new HWSKUs
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation