Skip to content

Update show platform syseeprom test#17601

Merged
yxieca merged 1 commit intosonic-net:masterfrom
SavchukRomanLv:show_platfrom_syseeprom
Jun 10, 2025
Merged

Update show platform syseeprom test#17601
yxieca merged 1 commit intosonic-net:masterfrom
SavchukRomanLv:show_platfrom_syseeprom

Conversation

@SavchukRomanLv
Copy link

@SavchukRomanLv SavchukRomanLv commented Mar 19, 2025

Description of PR

Summary:
SONiC stop read from /usr/share/sonic/device/{}/plugins/eeprom.py starting from 2020x release
Introduce new comparison between cli and db

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • New Test case
    • Skipped for non-supported platforms
  • Test case improvement

Back port request

  • 202012
  • 202205
  • 202305
  • 202311
  • 202405
  • 202411

Approach

What is the motivation for this PR?

Avoid TC failure if file removed

How did you do it?

Update test_show_platform_syseeprom.
Introduce new comparison between cli and db

How did you verify/test it?

Run test, TC passed

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

@SavchukRomanLv SavchukRomanLv requested a review from prgeor as a code owner March 19, 2025 08:34
@mssonicbld
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@SavchukRomanLv SavchukRomanLv force-pushed the show_platfrom_syseeprom branch from 156980a to 9f336c0 Compare March 19, 2025 09:25
@mssonicbld
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@vvolam
Copy link
Contributor

vvolam commented Jun 3, 2025

plugins

@SavchukRomanLv Could you give more information on how the read of plugins dir file content stopped? Is there any relevant PR?

@keboliu
Copy link
Contributor

keboliu commented Jun 4, 2025

plugins

@SavchukRomanLv Could you give more information on how the read of plugins dir file content stopped? Is there any relevant PR?

If we look at the code of the CLI scripts, we can see that it has already been adapted to calling the platform API instead of using the plugin, https://github.com/sonic-net/sonic-utilities/blob/6ce5257459b6d36496bc98a282b5d78c5be5b530/scripts/decode-syseeprom#L31-L40 , relevant PR is here: sonic-net/sonic-utilities#1435

@liat-grozovik
Copy link
Collaborator

@prgeor kindly reminder to review and merge

@vvolam
Copy link
Contributor

vvolam commented Jun 10, 2025

oduce new comparison between cli and db

Thank you for providing the info. changes LGTM. Thank you

@yxieca yxieca merged commit e715427 into sonic-net:master Jun 10, 2025
17 checks passed
@mssonicbld
Copy link
Collaborator

Cherry-pick PR to msft-202412: Azure/sonic-mgmt.msft#386

mssonicbld pushed a commit to mssonicbld/sonic-mgmt that referenced this pull request Jun 11, 2025
Description of PR
Summary:
SONiC stop read from /usr/share/sonic/device/{}/plugins/eeprom.py starting from 2020x release
Introduce new comparison between cli and db

What is the motivation for this PR?
Avoid TC failure if file removed

How did you do it?
Update test_show_platform_syseeprom.
Introduce new comparison between cli and db

How did you verify/test it?
Run test, TC passed
@mssonicbld
Copy link
Collaborator

Cherry-pick PR to 202505: #18924

mssonicbld pushed a commit that referenced this pull request Jun 11, 2025
Description of PR
Summary:
SONiC stop read from /usr/share/sonic/device/{}/plugins/eeprom.py starting from 2020x release
Introduce new comparison between cli and db

What is the motivation for this PR?
Avoid TC failure if file removed

How did you do it?
Update test_show_platform_syseeprom.
Introduce new comparison between cli and db

How did you verify/test it?
Run test, TC passed
nissampa pushed a commit to nissampa/sonic-mgmt_dpu_test that referenced this pull request Aug 7, 2025
Description of PR
Summary:
SONiC stop read from /usr/share/sonic/device/{}/plugins/eeprom.py starting from 2020x release
Introduce new comparison between cli and db

What is the motivation for this PR?
Avoid TC failure if file removed

How did you do it?
Update test_show_platform_syseeprom.
Introduce new comparison between cli and db

How did you verify/test it?
Run test, TC passed
opcoder0 pushed a commit to opcoder0/sonic-mgmt that referenced this pull request Dec 8, 2025
Description of PR
Summary:
SONiC stop read from /usr/share/sonic/device/{}/plugins/eeprom.py starting from 2020x release
Introduce new comparison between cli and db

What is the motivation for this PR?
Avoid TC failure if file removed

How did you do it?
Update test_show_platform_syseeprom.
Introduce new comparison between cli and db

How did you verify/test it?
Run test, TC passed

Signed-off-by: opcoder0 <110003254+opcoder0@users.noreply.github.com>
AharonMalkin pushed a commit to AharonMalkin/sonic-mgmt that referenced this pull request Dec 16, 2025
Description of PR
Summary:
SONiC stop read from /usr/share/sonic/device/{}/plugins/eeprom.py starting from 2020x release
Introduce new comparison between cli and db

What is the motivation for this PR?
Avoid TC failure if file removed

How did you do it?
Update test_show_platform_syseeprom.
Introduce new comparison between cli and db

How did you verify/test it?
Run test, TC passed

Signed-off-by: Aharon Malkin <amalkin@nvidia.com>
gshemesh2 pushed a commit to gshemesh2/sonic-mgmt that referenced this pull request Dec 21, 2025
Description of PR
Summary:
SONiC stop read from /usr/share/sonic/device/{}/plugins/eeprom.py starting from 2020x release
Introduce new comparison between cli and db

What is the motivation for this PR?
Avoid TC failure if file removed

How did you do it?
Update test_show_platform_syseeprom.
Introduce new comparison between cli and db

How did you verify/test it?
Run test, TC passed

Signed-off-by: Guy Shemesh <gshemesh@nvidia.com>
venu-nexthop pushed a commit to venu-nexthop/sonic-mgmt that referenced this pull request Jan 13, 2026
Description of PR
Summary:
SONiC stop read from /usr/share/sonic/device/{}/plugins/eeprom.py starting from 2020x release
Introduce new comparison between cli and db

What is the motivation for this PR?
Avoid TC failure if file removed

How did you do it?
Update test_show_platform_syseeprom.
Introduce new comparison between cli and db

How did you verify/test it?
Run test, TC passed
gshemesh2 pushed a commit to gshemesh2/sonic-mgmt that referenced this pull request Jan 26, 2026
Description of PR
Summary:
SONiC stop read from /usr/share/sonic/device/{}/plugins/eeprom.py starting from 2020x release
Introduce new comparison between cli and db

What is the motivation for this PR?
Avoid TC failure if file removed

How did you do it?
Update test_show_platform_syseeprom.
Introduce new comparison between cli and db

How did you verify/test it?
Run test, TC passed

Signed-off-by: Guy Shemesh <gshemesh@nvidia.com>
ytzur1 pushed a commit to ytzur1/sonic-mgmt that referenced this pull request Feb 2, 2026
Description of PR
Summary:
SONiC stop read from /usr/share/sonic/device/{}/plugins/eeprom.py starting from 2020x release
Introduce new comparison between cli and db

What is the motivation for this PR?
Avoid TC failure if file removed

How did you do it?
Update test_show_platform_syseeprom.
Introduce new comparison between cli and db

How did you verify/test it?
Run test, TC passed

Signed-off-by: Yael Tzur <ytzur@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants