Skip to content

[loganalyzer] Address whitespace issue and write marker to syslog after update#1754

Merged
neethajohn merged 2 commits intosonic-net:masterfrom
neethajohn:fix_loganalyzer_update
Jun 11, 2020
Merged

[loganalyzer] Address whitespace issue and write marker to syslog after update#1754
neethajohn merged 2 commits intosonic-net:masterfrom
neethajohn:fix_loganalyzer_update

Conversation

@neethajohn
Copy link
Contributor

@neethajohn neethajohn commented Jun 10, 2020

Signed-off-by: Neetha John [email protected]

Description of PR

  1. Loganalyzer class currently includes a method to update a marker prefix after init. But it does not convert the user defined marker to a run id format or write it to the syslog.
  2. If a marker prefix is specified with whitespaces, replace them with underscore to avoid issues during test run.

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

What is the motivation for the PR?

PFC functional tests use loganalyzer to detect/restore storm on multiple ports one after the other. Marker prefix needs to be updated multiple times after init

How did you verify/test it?

Test run on local pfc functional test scripts passed

@neethajohn neethajohn changed the title [loganalyzer] Write marker to syslog after update [loganalyzer] Address whitespace issue and write marker to syslog after update Jun 11, 2020
@neethajohn neethajohn merged commit ece3b89 into sonic-net:master Jun 11, 2020
@neethajohn neethajohn deleted the fix_loganalyzer_update branch June 11, 2020 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants