fix: handle UnpicklingError in cache read#17536
Merged
yejianquan merged 1 commit intosonic-net:masterfrom Mar 18, 2025
Merged
Conversation
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
cyw233
force-pushed
the
handle-unpickling-error-in-cache-read
branch
from
dbc9468 to
db1bcc3
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
cyw233
force-pushed
the
handle-unpickling-error-in-cache-read
branch
from
db1bcc3 to
9115c7f
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
cyw233
force-pushed
the
handle-unpickling-error-in-cache-read
branch
from
9115c7f to
f3e836c
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Mar 18, 2025
Description of PR Handle UnpicklingError edge case in FactsCache::read() when parallel run is enabled. Summary: Fixes # (issue) Microsoft ADO 31839137 Approach What is the motivation for this PR? When parallel run is enabled, multiple processes may try to read/write the same cache file, so there will be a chance that a file is being read by multiple processes at the same time, causing UnpicklingError in some of the processes. Therefore, we decided to retry to read the file after a short random sleep. If we still get the same error after retrying, we will return NOTEXIST to overwrite the file. co-authorized by: jianquanye@microsoft.com
Collaborator
|
Cherry-pick PR to 202411: #17584 |
This was referenced Mar 18, 2025
Collaborator
|
Cherry-pick PR to msft-202405: Azure/sonic-mgmt.msft#152 |
cyw233
added
Included in msft-202405 Branch
and removed
Created PR to msft-202405 Branch
labels
mssonicbld
pushed a commit
that referenced
this pull request
Mar 20, 2025
Description of PR Handle UnpicklingError edge case in FactsCache::read() when parallel run is enabled. Summary: Fixes # (issue) Microsoft ADO 31839137 Approach What is the motivation for this PR? When parallel run is enabled, multiple processes may try to read/write the same cache file, so there will be a chance that a file is being read by multiple processes at the same time, causing UnpicklingError in some of the processes. Therefore, we decided to retry to read the file after a short random sleep. If we still get the same error after retrying, we will return NOTEXIST to overwrite the file. co-authorized by: jianquanye@microsoft.com
amulyan7
pushed a commit
to amulyan7/sonic-mgmt
that referenced
this pull request
Mar 31, 2025
Description of PR Handle UnpicklingError edge case in FactsCache::read() when parallel run is enabled. Summary: Fixes # (issue) Microsoft ADO 31839137 Approach What is the motivation for this PR? When parallel run is enabled, multiple processes may try to read/write the same cache file, so there will be a chance that a file is being read by multiple processes at the same time, causing UnpicklingError in some of the processes. Therefore, we decided to retry to read the file after a short random sleep. If we still get the same error after retrying, we will return NOTEXIST to overwrite the file. co-authorized by: jianquanye@microsoft.com
OriTrabelsi
pushed a commit
to OriTrabelsi/sonic-mgmt
that referenced
this pull request
Apr 1, 2025
Description of PR Handle UnpicklingError edge case in FactsCache::read() when parallel run is enabled. Summary: Fixes # (issue) Microsoft ADO 31839137 Approach What is the motivation for this PR? When parallel run is enabled, multiple processes may try to read/write the same cache file, so there will be a chance that a file is being read by multiple processes at the same time, causing UnpicklingError in some of the processes. Therefore, we decided to retry to read the file after a short random sleep. If we still get the same error after retrying, we will return NOTEXIST to overwrite the file. co-authorized by: jianquanye@microsoft.com
gshemesh2
pushed a commit
to gshemesh2/sonic-mgmt
that referenced
this pull request
Dec 21, 2025
Description of PR Handle UnpicklingError edge case in FactsCache::read() when parallel run is enabled. Summary: Fixes # (issue) Microsoft ADO 31839137 Approach What is the motivation for this PR? When parallel run is enabled, multiple processes may try to read/write the same cache file, so there will be a chance that a file is being read by multiple processes at the same time, causing UnpicklingError in some of the processes. Therefore, we decided to retry to read the file after a short random sleep. If we still get the same error after retrying, we will return NOTEXIST to overwrite the file. co-authorized by: jianquanye@microsoft.com Signed-off-by: Guy Shemesh <gshemesh@nvidia.com>
gshemesh2
pushed a commit
to gshemesh2/sonic-mgmt
that referenced
this pull request
Jan 26, 2026
Description of PR Handle UnpicklingError edge case in FactsCache::read() when parallel run is enabled. Summary: Fixes # (issue) Microsoft ADO 31839137 Approach What is the motivation for this PR? When parallel run is enabled, multiple processes may try to read/write the same cache file, so there will be a chance that a file is being read by multiple processes at the same time, causing UnpicklingError in some of the processes. Therefore, we decided to retry to read the file after a short random sleep. If we still get the same error after retrying, we will return NOTEXIST to overwrite the file. co-authorized by: jianquanye@microsoft.com Signed-off-by: Guy Shemesh <gshemesh@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Handle
UnpicklingErroredge case inFactsCache::read()when parallel run is enabled.Summary:
Fixes # (issue) Microsoft ADO 31839137
Type of change
Back port request
Approach
What is the motivation for this PR?
When parallel run is enabled, multiple processes may try to read/write the same cache file, so there will be a chance that a file is being read by multiple processes at the same time, causing UnpicklingError in some of the processes. Therefore, we decided to retry to read the file after a short random sleep. If we still get the same error after retrying, we will return NOTEXIST to overwrite the file.
How did you do it?
How did you verify/test it?
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation