[Mellanox] Skip the fib nvgre hash test on SPC1 with t1-lag topology#17527
[Mellanox] Skip the fib nvgre hash test on SPC1 with t1-lag topology#17527bingwang-ms merged 2 commits intosonic-net:masterfrom
Conversation
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azpw run |
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
congh-nvidia
force-pushed
the
skip_nvgre
branch
from
6c8a94c to
9143cf8
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azpw run |
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@kperumalbfn Can you help review? |
|
Hi @congh-nvidia, discussed with @kperumalbfn offline. Can you change the skip to xfail so that we know there is a limitation here? |
Hi @bingwang-ms, sure. One question, should I still keep the test issue open or close it and make the xfail static? |
|
I suggest keeping the issue open. |
congh-nvidia
force-pushed
the
skip_nvgre
branch
from
9143cf8 to
978e621
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
@bingwang-ms done, changed to xfail. |
|
/azpw run |
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
congh-nvidia
force-pushed
the
skip_nvgre
branch
from
978e621 to
bdc1ec3
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Hi @bingwang-ms , I have changed it to xfail, please review. |
|
@congh-nvidia PR conflicts with 202411 branch |
|
@congh-nvidia Could you raise another PR for 202411 branch to address conflict? |
|
@congh-nvidia Can you handle the cherry-pick conflict? |
Hi @bingwang-ms , this is the cherry-pick #18182, sorry that handled this late. |
…onic-net#17527) * Skip the nvgre hash test on SPC1 t1-lag * Change the skip for nvgre hash to xfail on SPC1 Signed-off-by: opcoder0 <110003254+opcoder0@users.noreply.github.com>
…onic-net#17527) * Skip the nvgre hash test on SPC1 t1-lag * Change the skip for nvgre hash to xfail on SPC1 Signed-off-by: Aharon Malkin <amalkin@nvidia.com>
…onic-net#17527) * Skip the nvgre hash test on SPC1 t1-lag * Change the skip for nvgre hash to xfail on SPC1 Signed-off-by: Guy Shemesh <gshemesh@nvidia.com>
…onic-net#17527) * Skip the nvgre hash test on SPC1 t1-lag * Change the skip for nvgre hash to xfail on SPC1 Signed-off-by: Guy Shemesh <gshemesh@nvidia.com>
6 participants
Description of PR
Summary:
The fib/test_fib.py::test_nvgre_hash is not fully supported on Mellanox SPC1 platforms.
I have opened an issue #17526 to enhance the test.
Skip the test based on the issue.
Fix #17526
Type of change
Back port request
Approach
What is the motivation for this PR?
How did you do it?
How did you verify/test it?
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation