[sonic-mgmt][BFD][issues/17418]fix bfd responder crash#17419
Merged
bingwang-ms merged 3 commits intosonic-net:masterfrom Mar 25, 2025
Merged
[sonic-mgmt][BFD][issues/17418]fix bfd responder crash#17419bingwang-ms merged 3 commits intosonic-net:masterfrom
bingwang-ms merged 3 commits intosonic-net:masterfrom
Conversation
Signed-off-by: Baorong Liu <96146196+baorliu@users.noreply.github.com>
Collaborator
|
/azp run |
|
Azure Pipelines will not run the associated pipelines, because the pull request was updated after the run command was issued. Review the pull request again and issue a new run command. |
baorliu
changed the title
|
@kevinwangsk - please review this |
bpar9
previously approved these changes
Mar 18, 2025
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
update comment format
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Fix format issue: bfd_responder.py:130:69: E225 missing whitespace around operator
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
@wangxin , could you please help rerun the azp? last failures is DUT host unreachable. thanks. |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
bpar9
approved these changes
Mar 24, 2025
Contributor
Author
|
hi @bingwang-ms, @prabhataravind, could you please help review this PR? |
bingwang-ms
approved these changes
Mar 25, 2025
amulyan7
pushed a commit
to amulyan7/sonic-mgmt
that referenced
this pull request
Mar 31, 2025
* fix bfd responder crash Signed-off-by: Baorong Liu <96146196+baorliu@users.noreply.github.com>
Contributor
|
@kevinskwang FYI |
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Apr 1, 2025
* fix bfd responder crash Signed-off-by: Baorong Liu <96146196+baorliu@users.noreply.github.com>
Collaborator
|
Cherry-pick PR to 202411: #17771 |
11 tasks
mssonicbld
pushed a commit
that referenced
this pull request
Apr 1, 2025
* fix bfd responder crash Signed-off-by: Baorong Liu <96146196+baorliu@users.noreply.github.com>
mssonicbld
added
Included in 202411 branch
and removed
Created PR to 202411 branch
labels
OriTrabelsi
pushed a commit
to OriTrabelsi/sonic-mgmt
that referenced
this pull request
Apr 1, 2025
* fix bfd responder crash Signed-off-by: Baorong Liu <96146196+baorliu@users.noreply.github.com>
opcoder0
pushed a commit
to opcoder0/sonic-mgmt
that referenced
this pull request
Dec 8, 2025
* fix bfd responder crash Signed-off-by: Baorong Liu <96146196+baorliu@users.noreply.github.com>
gshemesh2
pushed a commit
to gshemesh2/sonic-mgmt
that referenced
this pull request
Dec 21, 2025
* fix bfd responder crash Signed-off-by: Baorong Liu <96146196+baorliu@users.noreply.github.com> Signed-off-by: Guy Shemesh <gshemesh@nvidia.com>
gshemesh2
pushed a commit
to gshemesh2/sonic-mgmt
that referenced
this pull request
Jan 26, 2026
* fix bfd responder crash Signed-off-by: Baorong Liu <96146196+baorliu@users.noreply.github.com> Signed-off-by: Guy Shemesh <gshemesh@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
fix bug #17418
These 2 cases may cause BFD related mgmt test fails:
1, bfd responder can receive the packet it sent. and at the time of restart, partial packet could be process and cause it crash
2, In the case of bfd_responder restart and it get BFD UP packet, the packet become uninitialized, it cause socket sending packet error.
Summary:
Fixes # (issue)
#17418
Type of change
Back port request
Approach
What is the motivation for this PR?
How did you do it?
How did you verify/test it?
set a breakpoint in a sonic_mgmt test (test_bfd.py), using a separately python script to craft and send BFD packet from the DUT to bfd_responder. it can trigger the second issue listed in the description section.
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation