[testbed] Fix YAML spacing issue in config_sonic_based_on_testbed#1736
Merged
daall merged 2 commits intosonic-net:masterfrom Jun 5, 2020
Merged
[testbed] Fix YAML spacing issue in config_sonic_based_on_testbed#1736daall merged 2 commits intosonic-net:masterfrom
daall merged 2 commits intosonic-net:masterfrom
Conversation
Signed-off-by: Danny Allen <[email protected]>
Contributor
Author
|
@zhenggen-xu this should unblock your build-image PRs |
wangxin
approved these changes
Jun 5, 2020
nazariig
reviewed
Jun 5, 2020
| provider: selfsigned | ||
| become: true | ||
|
|
||
| - name: Creates telemetry directory |
Contributor
There was a problem hiding this comment.
@daall this is inconsistent with the original implementation and makes minigraph generator to fail:
TASK [copy server_key from local to remote] ***************************************************************************************************************************
Friday 05 June 2020 10:35:44 +0000 (0:00:00.360) 0:00:14.331 ***********
An exception occurred during task execution. To see the full traceback, use -vvv. The error was: If you are using a module and expect the file to exist on the remote, see the remote_src option
fatal: [sonic]: FAILED! => {"changed": false, "msg": "Could not find or access '/etc/sonic/telemetry/streamingtelemetryserver.key' on the Ansible Controller.\nIf you are using a module and expect the file to exist on the remote, see the remote_src option"}
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
…nic-net#7563) * [202012][swss/swss-common/utilities/platform-daemons] Update submodule sonic-swss - [flex-counters] Delay flex counters stats init for faster boot time [202012] (sonic-net#1736) sonic-swss-common - [swig] allow threads (sonic-net#477) sonic-utilities - [sfpshow] Gracefully handle improper 'specification_compliance' field (sonic-net#1594) sonic-platform-daemons - [xcvrd] Change the y_cable presence logic to use "mux_cable" table as identifier from Config DB (sonic-net#176) - [xcvrd] Enhance Media Settings (sonic-net#177) Signed-off-by: Danny Allen <[email protected]>
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
…#8355) To include following changes: * d84a8cc 2021-08-05 | [fast-reboot] revert the change of disabling counter polling before fast-reboot (sonic-net#1744) (HEAD -> 202012, github/202012) [Ying Xie] * e900bc5 2021-08-04 | Add script null_route_helper (sonic-net#1718) [bingwang-ms] * 85f14e1 2021-08-02 | disk_check updates: (sonic-net#1736) [Renuka Manavalan] * d68ac1c 2021-05-27 | [console][show] Force refresh all lines status during show line (sonic-net#1641) [Blueve] * a0e417f 2021-04-25 | [console] Display success message after line cleared (sonic-net#1579) [Blueve] * 0c6bb27 2021-04-07 | [console] Include Flow Control status in show line result (sonic-net#1549) [Blueve]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Danny Allen [email protected]
Description of PR
Summary: Fixes some YAML syntax errors in the config_sonic_based_on_testbed file to unblock the PR checker in sonic-buildimage.
Type of change
Approach
What is the motivation for this PR?
The PR tests in sonic-buildimage aren't running because Jenkins can't parse the YAML file as expected (example: https://sonic-jenkins.westus2.cloudapp.azure.com/job/vs/job/buildimage-vs-image-pr/4077/console).
How did you do it?
I converted the spacing from a recent PR to use 2 spaces to make sure it was consistent throughout.
How did you verify/test it?
I ran the file through http://www.yamllint.com/ to make sure it was parseable and I ran the config_sonic... ansible job to make sure it ran as expected.