feat: add option to toggle on FEC in minigraph#17295
Merged
yejianquan merged 2 commits intosonic-net:masterfrom Mar 27, 2025
Merged
feat: add option to toggle on FEC in minigraph#17295yejianquan merged 2 commits intosonic-net:masterfrom
yejianquan merged 2 commits intosonic-net:masterfrom
Conversation
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
auspham
force-pushed
the
austinpham/31623287-disable-fec-for-ixia-minigraph
branch
from
442f0e0 to
2e101ca
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
sdszhang
reviewed
Mar 3, 2025
auspham
force-pushed
the
austinpham/31623287-disable-fec-for-ixia-minigraph
branch
from
2e101ca to
2d4d222
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
auspham
force-pushed
the
austinpham/31623287-disable-fec-for-ixia-minigraph
branch
from
2d4d222 to
400d8c4
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
sdszhang
reviewed
Mar 21, 2025
|
|
||
| {%- if 'dualtor' in topo or (macsec_card is defined and macsec_card == True and 't2' in topo) -%} | ||
| {%- if 'dualtor' in topo or (macsec_card is defined and macsec_card == True and 't2' in topo) or ("ixia" in topo) -%} | ||
| {% set ns.link_metadata_defined = True %} |
Contributor
There was a problem hiding this comment.
does this mean all existing ixia topo need to update their links.csv file?
Contributor
Author
There was a problem hiding this comment.
@sdszhang this will make sure that this FEC feature toggle only available to IXIA, they don't need to update their links.csv but if they want to use, they can toggle it on.
Signed-off-by: Austin Pham <austinpham@microsoft.com>
auspham
force-pushed
the
austinpham/31623287-disable-fec-for-ixia-minigraph
branch
from
400d8c4 to
ec1b0d7
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
auspham
changed the title
Signed-off-by: Austin Pham <austinpham@microsoft.com>
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
sdszhang
approved these changes
Mar 26, 2025
Contributor
Author
|
Requesting on msft 202405 as turning off FEC is essential to run IXIA 100G. As of now, IXIA wont establish connection to port if FEC is on. @yejianquan |
amulyan7
pushed a commit
to amulyan7/sonic-mgmt
that referenced
this pull request
Mar 31, 2025
Description of PR Summary: Add option to toggle on FEC for minigraph in ixia topo Fixes # (issue) 31623287 Approach What is the motivation for this PR? When in ixia FEC enabled port doesn't work well in some breakout ports. We want an option to force turn off FEC. To use it, modify the links file. For example suppose we have the original _links.csv: StartDevice,StartPort,EndDevice,EndPort,BandWidth,VlanID,VlanMode,AutoNeg str-msn2700-01,Ethernet0,str-7260-10,Ethernet1,40000,1681,Access,on str-msn2700-01,Ethernet4,str-7260-10,Ethernet2,40000,1682,Access,on str-msn2700-01,Ethernet8,str-7260-10,Ethernet3,40000,1683,Access,on str-msn2700-01,Ethernet12,str-7260-10,Ethernet4,40000,1684,Access,on str-msn2700-01,Ethernet16,str-7260-10,Ethernet5,40000,1685,Access,on str-msn2700-01,Ethernet20,str-7260-10,Ethernet6,40000,1686,Access,on str-msn2700-01,Ethernet24,str-7260-10,Ethernet7,40000,1687,Access,on ... Let's say we want to force disable FEC on Ethernet24: StartDevice,StartPort,EndDevice,EndPort,BandWidth,VlanID,VlanMode,AutoNeg,FECDisable str-msn2700-01,Ethernet0,str-7260-10,Ethernet1,40000,1681,Access,on str-msn2700-01,Ethernet4,str-7260-10,Ethernet2,40000,1682,Access,on str-msn2700-01,Ethernet8,str-7260-10,Ethernet3,40000,1683,Access,on str-msn2700-01,Ethernet12,str-7260-10,Ethernet4,40000,1684,Access,on str-msn2700-01,Ethernet16,str-7260-10,Ethernet5,40000,1685,Access,on str-msn2700-01,Ethernet20,str-7260-10,Ethernet6,40000,1686,Access,on str-msn2700-01,Ethernet24,str-7260-10,Ethernet7,40000,1687,Access,on,true Note that in here we only add the header and modify the Ethernet24, the other lines we don't need to modify anything How did you do it? Add attribute in minigraph to disable at deploy-mg phase How did you verify/test it? T2 physical testbed Signed-off-by: Austin Pham <austinpham@microsoft.com>
nnelluri-cisco
pushed a commit
to nnelluri-cisco/sonic-mgmt
that referenced
this pull request
Mar 31, 2025
Description of PR Summary: Add option to toggle on FEC for minigraph in ixia topo Fixes # (issue) 31623287 Approach What is the motivation for this PR? When in ixia FEC enabled port doesn't work well in some breakout ports. We want an option to force turn off FEC. To use it, modify the links file. For example suppose we have the original _links.csv: StartDevice,StartPort,EndDevice,EndPort,BandWidth,VlanID,VlanMode,AutoNeg str-msn2700-01,Ethernet0,str-7260-10,Ethernet1,40000,1681,Access,on str-msn2700-01,Ethernet4,str-7260-10,Ethernet2,40000,1682,Access,on str-msn2700-01,Ethernet8,str-7260-10,Ethernet3,40000,1683,Access,on str-msn2700-01,Ethernet12,str-7260-10,Ethernet4,40000,1684,Access,on str-msn2700-01,Ethernet16,str-7260-10,Ethernet5,40000,1685,Access,on str-msn2700-01,Ethernet20,str-7260-10,Ethernet6,40000,1686,Access,on str-msn2700-01,Ethernet24,str-7260-10,Ethernet7,40000,1687,Access,on ... Let's say we want to force disable FEC on Ethernet24: StartDevice,StartPort,EndDevice,EndPort,BandWidth,VlanID,VlanMode,AutoNeg,FECDisable str-msn2700-01,Ethernet0,str-7260-10,Ethernet1,40000,1681,Access,on str-msn2700-01,Ethernet4,str-7260-10,Ethernet2,40000,1682,Access,on str-msn2700-01,Ethernet8,str-7260-10,Ethernet3,40000,1683,Access,on str-msn2700-01,Ethernet12,str-7260-10,Ethernet4,40000,1684,Access,on str-msn2700-01,Ethernet16,str-7260-10,Ethernet5,40000,1685,Access,on str-msn2700-01,Ethernet20,str-7260-10,Ethernet6,40000,1686,Access,on str-msn2700-01,Ethernet24,str-7260-10,Ethernet7,40000,1687,Access,on,true Note that in here we only add the header and modify the Ethernet24, the other lines we don't need to modify anything How did you do it? Add attribute in minigraph to disable at deploy-mg phase How did you verify/test it? T2 physical testbed Signed-off-by: Austin Pham <austinpham@microsoft.com>
OriTrabelsi
pushed a commit
to OriTrabelsi/sonic-mgmt
that referenced
this pull request
Apr 1, 2025
Description of PR Summary: Add option to toggle on FEC for minigraph in ixia topo Fixes # (issue) 31623287 Approach What is the motivation for this PR? When in ixia FEC enabled port doesn't work well in some breakout ports. We want an option to force turn off FEC. To use it, modify the links file. For example suppose we have the original _links.csv: StartDevice,StartPort,EndDevice,EndPort,BandWidth,VlanID,VlanMode,AutoNeg str-msn2700-01,Ethernet0,str-7260-10,Ethernet1,40000,1681,Access,on str-msn2700-01,Ethernet4,str-7260-10,Ethernet2,40000,1682,Access,on str-msn2700-01,Ethernet8,str-7260-10,Ethernet3,40000,1683,Access,on str-msn2700-01,Ethernet12,str-7260-10,Ethernet4,40000,1684,Access,on str-msn2700-01,Ethernet16,str-7260-10,Ethernet5,40000,1685,Access,on str-msn2700-01,Ethernet20,str-7260-10,Ethernet6,40000,1686,Access,on str-msn2700-01,Ethernet24,str-7260-10,Ethernet7,40000,1687,Access,on ... Let's say we want to force disable FEC on Ethernet24: StartDevice,StartPort,EndDevice,EndPort,BandWidth,VlanID,VlanMode,AutoNeg,FECDisable str-msn2700-01,Ethernet0,str-7260-10,Ethernet1,40000,1681,Access,on str-msn2700-01,Ethernet4,str-7260-10,Ethernet2,40000,1682,Access,on str-msn2700-01,Ethernet8,str-7260-10,Ethernet3,40000,1683,Access,on str-msn2700-01,Ethernet12,str-7260-10,Ethernet4,40000,1684,Access,on str-msn2700-01,Ethernet16,str-7260-10,Ethernet5,40000,1685,Access,on str-msn2700-01,Ethernet20,str-7260-10,Ethernet6,40000,1686,Access,on str-msn2700-01,Ethernet24,str-7260-10,Ethernet7,40000,1687,Access,on,true Note that in here we only add the header and modify the Ethernet24, the other lines we don't need to modify anything How did you do it? Add attribute in minigraph to disable at deploy-mg phase How did you verify/test it? T2 physical testbed Signed-off-by: Austin Pham <austinpham@microsoft.com>
Collaborator
|
hi @yejianquan , do you mind to help create a manual cherry pick to 202412 branch here? https://github.com/Azure/sonic-mgmt.msft/tree/202412 |
Contributor
Author
|
Hi @r12f, I raised a PR here Azure/sonic-mgmt.msft#231 |
auspham
added
Request for msft-202405 Branch
and removed
Request for msft-202405 Branch
labels
yejianquan
added a commit
to Azure/sonic-mgmt.msft
that referenced
this pull request
Apr 29, 2025
Conflict fix sonic-net/sonic-mgmt#17295 Description of PR Summary: Add option to toggle on FEC for minigraph in ixia topo Fixes # (issue) 31623287 Approach What is the motivation for this PR? When in ixia FEC enabled port doesn't work well in some breakout ports. We want an option to force turn off FEC. To use it, modify the links file. For example suppose we have the original _links.csv: StartDevice,StartPort,EndDevice,EndPort,BandWidth,VlanID,VlanMode,AutoNeg str-msn2700-01,Ethernet0,str-7260-10,Ethernet1,40000,1681,Access,on str-msn2700-01,Ethernet4,str-7260-10,Ethernet2,40000,1682,Access,on str-msn2700-01,Ethernet8,str-7260-10,Ethernet3,40000,1683,Access,on str-msn2700-01,Ethernet12,str-7260-10,Ethernet4,40000,1684,Access,on str-msn2700-01,Ethernet16,str-7260-10,Ethernet5,40000,1685,Access,on str-msn2700-01,Ethernet20,str-7260-10,Ethernet6,40000,1686,Access,on str-msn2700-01,Ethernet24,str-7260-10,Ethernet7,40000,1687,Access,on ... Let's say we want to force disable FEC on Ethernet24: StartDevice,StartPort,EndDevice,EndPort,BandWidth,VlanID,VlanMode,AutoNeg,FECDisable str-msn2700-01,Ethernet0,str-7260-10,Ethernet1,40000,1681,Access,on str-msn2700-01,Ethernet4,str-7260-10,Ethernet2,40000,1682,Access,on str-msn2700-01,Ethernet8,str-7260-10,Ethernet3,40000,1683,Access,on str-msn2700-01,Ethernet12,str-7260-10,Ethernet4,40000,1684,Access,on str-msn2700-01,Ethernet16,str-7260-10,Ethernet5,40000,1685,Access,on str-msn2700-01,Ethernet20,str-7260-10,Ethernet6,40000,1686,Access,on str-msn2700-01,Ethernet24,str-7260-10,Ethernet7,40000,1687,Access,on,true Note that in here we only add the header and modify the Ethernet24, the other lines we don't need to modify anything How did you do it? Add attribute in minigraph to disable at deploy-mg phase How did you verify/test it? T2 physical testbed
zhixzhu
pushed a commit
to zhixzhu/sonic-mgmt
that referenced
this pull request
May 1, 2025
Description of PR Summary: Add option to toggle on FEC for minigraph in ixia topo Fixes # (issue) 31623287 Approach What is the motivation for this PR? When in ixia FEC enabled port doesn't work well in some breakout ports. We want an option to force turn off FEC. To use it, modify the links file. For example suppose we have the original _links.csv: StartDevice,StartPort,EndDevice,EndPort,BandWidth,VlanID,VlanMode,AutoNeg str-msn2700-01,Ethernet0,str-7260-10,Ethernet1,40000,1681,Access,on str-msn2700-01,Ethernet4,str-7260-10,Ethernet2,40000,1682,Access,on str-msn2700-01,Ethernet8,str-7260-10,Ethernet3,40000,1683,Access,on str-msn2700-01,Ethernet12,str-7260-10,Ethernet4,40000,1684,Access,on str-msn2700-01,Ethernet16,str-7260-10,Ethernet5,40000,1685,Access,on str-msn2700-01,Ethernet20,str-7260-10,Ethernet6,40000,1686,Access,on str-msn2700-01,Ethernet24,str-7260-10,Ethernet7,40000,1687,Access,on ... Let's say we want to force disable FEC on Ethernet24: StartDevice,StartPort,EndDevice,EndPort,BandWidth,VlanID,VlanMode,AutoNeg,FECDisable str-msn2700-01,Ethernet0,str-7260-10,Ethernet1,40000,1681,Access,on str-msn2700-01,Ethernet4,str-7260-10,Ethernet2,40000,1682,Access,on str-msn2700-01,Ethernet8,str-7260-10,Ethernet3,40000,1683,Access,on str-msn2700-01,Ethernet12,str-7260-10,Ethernet4,40000,1684,Access,on str-msn2700-01,Ethernet16,str-7260-10,Ethernet5,40000,1685,Access,on str-msn2700-01,Ethernet20,str-7260-10,Ethernet6,40000,1686,Access,on str-msn2700-01,Ethernet24,str-7260-10,Ethernet7,40000,1687,Access,on,true Note that in here we only add the header and modify the Ethernet24, the other lines we don't need to modify anything How did you do it? Add attribute in minigraph to disable at deploy-mg phase How did you verify/test it? T2 physical testbed Signed-off-by: Austin Pham <austinpham@microsoft.com>
r12f
pushed a commit
to Azure/sonic-mgmt.msft
that referenced
this pull request
May 9, 2025
Description of PR Cherry-pick conflict sonic-net/sonic-mgmt#17295 Summary: Add option to toggle on FEC for minigraph in ixia topo Fixes # (issue) 31623287 Approach What is the motivation for this PR? When in ixia FEC enabled port doesn't work well in some breakout ports. We want an option to force turn off FEC. To use it, modify the links file. For example suppose we have the original _links.csv: ``` StartDevice,StartPort,EndDevice,EndPort,BandWidth,VlanID,VlanMode,AutoNeg str-msn2700-01,Ethernet0,str-7260-10,Ethernet1,40000,1681,Access,on str-msn2700-01,Ethernet4,str-7260-10,Ethernet2,40000,1682,Access,on str-msn2700-01,Ethernet8,str-7260-10,Ethernet3,40000,1683,Access,on str-msn2700-01,Ethernet12,str-7260-10,Ethernet4,40000,1684,Access,on str-msn2700-01,Ethernet16,str-7260-10,Ethernet5,40000,1685,Access,on str-msn2700-01,Ethernet20,str-7260-10,Ethernet6,40000,1686,Access,on str-msn2700-01,Ethernet24,str-7260-10,Ethernet7,40000,1687,Access,on ... Let's say we want to force disable FEC on Ethernet24: ``` ``` StartDevice,StartPort,EndDevice,EndPort,BandWidth,VlanID,VlanMode,AutoNeg,FECDisable str-msn2700-01,Ethernet0,str-7260-10,Ethernet1,40000,1681,Access,on str-msn2700-01,Ethernet4,str-7260-10,Ethernet2,40000,1682,Access,on str-msn2700-01,Ethernet8,str-7260-10,Ethernet3,40000,1683,Access,on str-msn2700-01,Ethernet12,str-7260-10,Ethernet4,40000,1684,Access,on str-msn2700-01,Ethernet16,str-7260-10,Ethernet5,40000,1685,Access,on str-msn2700-01,Ethernet20,str-7260-10,Ethernet6,40000,1686,Access,on str-msn2700-01,Ethernet24,str-7260-10,Ethernet7,40000,1687,Access,on,true Note that in here we only add the header and modify the Ethernet24, the other lines we don't need to modify anything ``` How did you do it? Add attribute in minigraph to disable at deploy-mg phase How did you verify/test it? T2 physical testbed Signed-off-by: Austin Pham <austinpham@microsoft.com>
r12f
added
Included in msft-202412 Branch
Approved for msft-202412 Branch
and removed
Cherry Pick Conflict_msft-202412
labels
opcoder0
pushed a commit
to opcoder0/sonic-mgmt
that referenced
this pull request
Dec 8, 2025
Description of PR Summary: Add option to toggle on FEC for minigraph in ixia topo Fixes # (issue) 31623287 Approach What is the motivation for this PR? When in ixia FEC enabled port doesn't work well in some breakout ports. We want an option to force turn off FEC. To use it, modify the links file. For example suppose we have the original _links.csv: StartDevice,StartPort,EndDevice,EndPort,BandWidth,VlanID,VlanMode,AutoNeg str-msn2700-01,Ethernet0,str-7260-10,Ethernet1,40000,1681,Access,on str-msn2700-01,Ethernet4,str-7260-10,Ethernet2,40000,1682,Access,on str-msn2700-01,Ethernet8,str-7260-10,Ethernet3,40000,1683,Access,on str-msn2700-01,Ethernet12,str-7260-10,Ethernet4,40000,1684,Access,on str-msn2700-01,Ethernet16,str-7260-10,Ethernet5,40000,1685,Access,on str-msn2700-01,Ethernet20,str-7260-10,Ethernet6,40000,1686,Access,on str-msn2700-01,Ethernet24,str-7260-10,Ethernet7,40000,1687,Access,on ... Let's say we want to force disable FEC on Ethernet24: StartDevice,StartPort,EndDevice,EndPort,BandWidth,VlanID,VlanMode,AutoNeg,FECDisable str-msn2700-01,Ethernet0,str-7260-10,Ethernet1,40000,1681,Access,on str-msn2700-01,Ethernet4,str-7260-10,Ethernet2,40000,1682,Access,on str-msn2700-01,Ethernet8,str-7260-10,Ethernet3,40000,1683,Access,on str-msn2700-01,Ethernet12,str-7260-10,Ethernet4,40000,1684,Access,on str-msn2700-01,Ethernet16,str-7260-10,Ethernet5,40000,1685,Access,on str-msn2700-01,Ethernet20,str-7260-10,Ethernet6,40000,1686,Access,on str-msn2700-01,Ethernet24,str-7260-10,Ethernet7,40000,1687,Access,on,true Note that in here we only add the header and modify the Ethernet24, the other lines we don't need to modify anything How did you do it? Add attribute in minigraph to disable at deploy-mg phase How did you verify/test it? T2 physical testbed Signed-off-by: Austin Pham <austinpham@microsoft.com>
gshemesh2
pushed a commit
to gshemesh2/sonic-mgmt
that referenced
this pull request
Dec 21, 2025
Description of PR Summary: Add option to toggle on FEC for minigraph in ixia topo Fixes # (issue) 31623287 Approach What is the motivation for this PR? When in ixia FEC enabled port doesn't work well in some breakout ports. We want an option to force turn off FEC. To use it, modify the links file. For example suppose we have the original _links.csv: StartDevice,StartPort,EndDevice,EndPort,BandWidth,VlanID,VlanMode,AutoNeg str-msn2700-01,Ethernet0,str-7260-10,Ethernet1,40000,1681,Access,on str-msn2700-01,Ethernet4,str-7260-10,Ethernet2,40000,1682,Access,on str-msn2700-01,Ethernet8,str-7260-10,Ethernet3,40000,1683,Access,on str-msn2700-01,Ethernet12,str-7260-10,Ethernet4,40000,1684,Access,on str-msn2700-01,Ethernet16,str-7260-10,Ethernet5,40000,1685,Access,on str-msn2700-01,Ethernet20,str-7260-10,Ethernet6,40000,1686,Access,on str-msn2700-01,Ethernet24,str-7260-10,Ethernet7,40000,1687,Access,on ... Let's say we want to force disable FEC on Ethernet24: StartDevice,StartPort,EndDevice,EndPort,BandWidth,VlanID,VlanMode,AutoNeg,FECDisable str-msn2700-01,Ethernet0,str-7260-10,Ethernet1,40000,1681,Access,on str-msn2700-01,Ethernet4,str-7260-10,Ethernet2,40000,1682,Access,on str-msn2700-01,Ethernet8,str-7260-10,Ethernet3,40000,1683,Access,on str-msn2700-01,Ethernet12,str-7260-10,Ethernet4,40000,1684,Access,on str-msn2700-01,Ethernet16,str-7260-10,Ethernet5,40000,1685,Access,on str-msn2700-01,Ethernet20,str-7260-10,Ethernet6,40000,1686,Access,on str-msn2700-01,Ethernet24,str-7260-10,Ethernet7,40000,1687,Access,on,true Note that in here we only add the header and modify the Ethernet24, the other lines we don't need to modify anything How did you do it? Add attribute in minigraph to disable at deploy-mg phase How did you verify/test it? T2 physical testbed Signed-off-by: Austin Pham <austinpham@microsoft.com> Signed-off-by: Guy Shemesh <gshemesh@nvidia.com>
gshemesh2
pushed a commit
to gshemesh2/sonic-mgmt
that referenced
this pull request
Jan 26, 2026
Description of PR Summary: Add option to toggle on FEC for minigraph in ixia topo Fixes # (issue) 31623287 Approach What is the motivation for this PR? When in ixia FEC enabled port doesn't work well in some breakout ports. We want an option to force turn off FEC. To use it, modify the links file. For example suppose we have the original _links.csv: StartDevice,StartPort,EndDevice,EndPort,BandWidth,VlanID,VlanMode,AutoNeg str-msn2700-01,Ethernet0,str-7260-10,Ethernet1,40000,1681,Access,on str-msn2700-01,Ethernet4,str-7260-10,Ethernet2,40000,1682,Access,on str-msn2700-01,Ethernet8,str-7260-10,Ethernet3,40000,1683,Access,on str-msn2700-01,Ethernet12,str-7260-10,Ethernet4,40000,1684,Access,on str-msn2700-01,Ethernet16,str-7260-10,Ethernet5,40000,1685,Access,on str-msn2700-01,Ethernet20,str-7260-10,Ethernet6,40000,1686,Access,on str-msn2700-01,Ethernet24,str-7260-10,Ethernet7,40000,1687,Access,on ... Let's say we want to force disable FEC on Ethernet24: StartDevice,StartPort,EndDevice,EndPort,BandWidth,VlanID,VlanMode,AutoNeg,FECDisable str-msn2700-01,Ethernet0,str-7260-10,Ethernet1,40000,1681,Access,on str-msn2700-01,Ethernet4,str-7260-10,Ethernet2,40000,1682,Access,on str-msn2700-01,Ethernet8,str-7260-10,Ethernet3,40000,1683,Access,on str-msn2700-01,Ethernet12,str-7260-10,Ethernet4,40000,1684,Access,on str-msn2700-01,Ethernet16,str-7260-10,Ethernet5,40000,1685,Access,on str-msn2700-01,Ethernet20,str-7260-10,Ethernet6,40000,1686,Access,on str-msn2700-01,Ethernet24,str-7260-10,Ethernet7,40000,1687,Access,on,true Note that in here we only add the header and modify the Ethernet24, the other lines we don't need to modify anything How did you do it? Add attribute in minigraph to disable at deploy-mg phase How did you verify/test it? T2 physical testbed Signed-off-by: Austin Pham <austinpham@microsoft.com> Signed-off-by: Guy Shemesh <gshemesh@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary: Add option to toggle on FEC for minigraph in ixia topo
Fixes # (issue) 31623287
Type of change
Back port request
Approach
What is the motivation for this PR?
When in ixia FEC enabled port doesn't work well in some breakout ports. We want an option to force turn off FEC.
To use it, modify the links file. For example suppose we have the original _links.csv:
Let's say we want to force disable FEC on Ethernet24:
Note that in here we only add the header and modify the Ethernet24, the other lines we don't need to modify anything
How did you do it?
Add attribute in minigraph to disable at deploy-mg phase
How did you verify/test it?
T2 physical testbed
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation